From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 123D5A0A02; Fri, 15 Jan 2021 12:51:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F3EC140FFF; Fri, 15 Jan 2021 12:51:56 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 132FA140FFE for <dev@dpdk.org>; Fri, 15 Jan 2021 12:51:54 +0100 (CET) IronPort-SDR: V8G653jP0FtWKIJ4ysl9Ljpf7PXDOuXcK6WPMCFFDUeMjvVnpFo0Xqf2n5HRSYaguZ5k00hXwg xEmSGh/IhNLg== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="175031977" X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="175031977" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 03:51:54 -0800 IronPort-SDR: wgafX9f/LqUgIRDvowzrG104IgsiCl1lsAZGKZHn9RIkktesYP+c9Z1wOhNNR94EbHA/JobUH8 o6+TtsOTG5Rw== X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="382638255" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.221.206]) ([10.213.221.206]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 03:51:51 -0800 To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org Cc: david.marchand@redhat.com, Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Yipeng Wang <yipeng1.wang@intel.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, Bernard Iremonger <bernard.iremonger@intel.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Ori Kam <orika@nvidia.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Olivier Matz <olivier.matz@6wind.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210115111052.16437-1-bruce.richardson@intel.com> <20210115111052.16437-17-bruce.richardson@intel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <9b696a65-2012-7ae8-d840-1515f8bf140b@intel.com> Date: Fri, 15 Jan 2021 11:51:49 +0000 MIME-Version: 1.0 In-Reply-To: <20210115111052.16437-17-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 1/15/2021 11:10 AM, Bruce Richardson wrote: > To verify that all DPDK headers are ok for inclusion directly in a C > file, and are not missing any other pre-requisite headers, we can > auto-generate for each header an empty C file that includes that header. > Compiling these files will throw errors if any header has unmet > dependencies. > > The list of headers to check is based of the "headers" value returned from > each library's meson.build file. However, since not all headers are for > direct inclusion, add a build variable "headers_no_chkincs" to list those > headers and skip checking them. > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > --- > > v2: > * add maintainers entry > * distribute exception list among meson.build files. > > MAINTAINERS | 4 ++++ > app/chkincs/gen_c_file_for_header.py | 12 ++++++++++ > app/chkincs/main.c | 4 ++++ > app/chkincs/meson.build | 28 ++++++++++++++++++++++++ +1 to have this kind of tool to check, but it is not an application like others in the 'app' folder, what do you think placing it under 'devtools' or 'buildtools'?