From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E6EFA052F; Wed, 29 Jan 2020 18:49:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40F4D1C065; Wed, 29 Jan 2020 18:49:47 +0100 (CET) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by dpdk.org (Postfix) with ESMTP id 9E1B51C026 for ; Wed, 29 Jan 2020 18:49:46 +0100 (CET) Received: by mail-lf1-f43.google.com with SMTP id c23so289846lfi.7 for ; Wed, 29 Jan 2020 09:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JrFmthLyV8L5zDJny97wC001kEEhU6iGZFwrQ130hWI=; b=RnJW9BI9fC4LiXQK12siuxGqfLH5QVdek7lRGw2W0rougBtGACkcn6VEGwNI+Nzdzo 1oaApgW7ad5IT/zJw2jep/7ips+OTGqIjhqPt1edbKIiyHsXoVYTrR2xGx9J0WoY2SaY b/kmEMHTNbA2e12EeliGFHRXluzN0cvdpwRWXZC2pjsuwbll5qKmVrWSQ7s3/MeasTZY diqf831stktLQiU6Bd3pTaFu1lg+rbkYlFCaaVG/fDfA8LuYKoJN8+V3/mcoyF1bMZi/ 3QowXu/9n2FhUHajXoP/P6xhoy1jSyUTUxW/0lmmbGKNc6E6GLm7r7mUDhkypruQXmPs RajQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JrFmthLyV8L5zDJny97wC001kEEhU6iGZFwrQ130hWI=; b=Bj53pGrH1tIibgakSOs1g8dxFaAXLXN8mjAzyrbX194J+Z+lu4HGaOzFgCp6ODaMCo wzhmYrG8WTgHcO+U0Yzsb0ZpUIPS3zUoif68nvE3iAo1ea7i8pIPzdiU32JuR+NGPJmK 7SeiMgUDu89F41v5flTA9Vmguhykqpzsj18Pqo1R4pV2w+aNH/qPqh4Oh1wxOemEUBcZ Y/xNyYjrQSzB9X3KhD5iOfD5Ri6GEfMfmi+gMbdgFfkKgrB2l/J6NJNrRHtutETsa4cE IHYCb5cbIPjI5momP5U2l2bkO0Q0BSAXyZqLBpkfEhCrNY+LdYdD7VM6442d4kaYCg/G sWDw== X-Gm-Message-State: APjAAAWwc0T9tJKp/fM959IiBMIhTp4IrSiuXZ2TieW81wrNFidZnyAK b1xuDFyxJsJmHKEoQ/o6YNjUTg== X-Google-Smtp-Source: APXvYqy3nigMDOIEQ3c2xvmSj5jweTEPOYLtfuZd8cW7izl4xJpMekV8W9SNeGQ3eWp/j5f/DW4CIA== X-Received: by 2002:ac2:5a43:: with SMTP id r3mr260356lfn.150.1580320186259; Wed, 29 Jan 2020 09:49:46 -0800 (PST) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d11sm1438392lfj.3.2020.01.29.09.49.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 09:49:45 -0800 (PST) To: Ferruh Yigit , Neil Horman , Cristian Dumitrescu , Eelco Chaudron Cc: dev@dpdk.org, Thomas Monjalon , Luca Boccassi , David Marchand , Bruce Richardson , Ian Stokes References: <20200129122953.2016199-1-ferruh.yigit@intel.com> <20200129164350.3724793-1-ferruh.yigit@intel.com> From: Andrzej Ostruszka Message-ID: <9b91630a-7480-3364-2c9f-99e23953c800@semihalf.com> Date: Wed, 29 Jan 2020 18:49:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200129164350.3724793-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/29/20 5:43 PM, Ferruh Yigit wrote: [...] > diff --git a/lib/librte_meter/rte_meter.c b/lib/librte_meter/rte_meter.c > index da01429a8..5244537fa 100644 > --- a/lib/librte_meter/rte_meter.c > +++ b/lib/librte_meter/rte_meter.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > > #include "rte_meter.h" > > @@ -119,8 +120,8 @@ rte_meter_trtcm_config(struct rte_meter_trtcm *m, > return 0; > } > > -int > -rte_meter_trtcm_rfc4115_profile_config( > +static int > +rte_meter_trtcm_rfc4115_profile_config_( > struct rte_meter_trtcm_rfc4115_profile *p, > struct rte_meter_trtcm_rfc4115_params *params) > { > @@ -145,7 +146,35 @@ rte_meter_trtcm_rfc4115_profile_config( > } > > int > -rte_meter_trtcm_rfc4115_config( > +rte_meter_trtcm_rfc4115_profile_config_s( > + struct rte_meter_trtcm_rfc4115_profile *p, > + struct rte_meter_trtcm_rfc4115_params *params); > +int > +rte_meter_trtcm_rfc4115_profile_config_s( > + struct rte_meter_trtcm_rfc4115_profile *p, > + struct rte_meter_trtcm_rfc4115_params *params) > +{ > + return rte_meter_trtcm_rfc4115_profile_config_(p, params); > +} > +BIND_DEFAULT_SYMBOL(rte_meter_trtcm_rfc4115_profile_config, _s, 20.0.1); You might want to mark these version symbols with __vsym macro. Without this shared lib build with LTO might remove them (due to long standing gcc bug - it does not have proper way to mark .symver in internal representation and so does not recognize that function is used). This comment is global - for all symbols mentioned in BIND_/VERSION_ macros. Out of curiosity - why do you need separate declaration just before definition? With regards Andrzej Ostruszka