From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB5DAA04B7; Wed, 2 Sep 2020 10:51:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9EA431C066; Wed, 2 Sep 2020 10:51:28 +0200 (CEST) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 4B8884C99 for ; Wed, 2 Sep 2020 10:51:27 +0200 (CEST) Received: by mail-lf1-f66.google.com with SMTP id w11so2387503lfn.2 for ; Wed, 02 Sep 2020 01:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=3G4QyS3M+c6wb1S9D3+my9p0Otz80MUjTowamE6KEpY=; b=hFuqX0C8wKyhY36nipLSxSToTHWKeHKPeQgGYGpIB9RzTi6EIGU1PkvQH8duaGrpUP 3bcz17RFk8PiJTDoBfrnSpoBqW1Nxtl/D8CkaNjbWxzgDdh0AwhA2iRWOJgIrMv+H71K zB6ItmYA1nQZa7bH1Y3gfcoST/6JKwwSCuI1LgvJzodg8UXHPWBsC7ZJACPeTirTDB4l 27RbqwdDh0UNtm/3lCbCFKZZLJx7VCTkB3JnVuuBl4BAgZcYzKBBXiI3G9gyfcdRLVEB cKOgnpoXs4Z8oqii+hgTPrRot75t2ZhZ8lAkIggXSXaY3uBx6/zvB2jtrXB+fYfgTRE2 KHKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=3G4QyS3M+c6wb1S9D3+my9p0Otz80MUjTowamE6KEpY=; b=bmJ5GQ/tp5/JnFrbS+5RnmLkQ+6zWT3R+M2MsjX7ZpI2ukl7yWzAOcMyq19EzLFs9g dHW4liINDCiTtxCZ8yxFO5RT7gF6nE9S9l3XVIIj+5bynhxxLAIxOKqIPm6vEVMSEGr9 ENDNbHpJ4SEuNCJWr2yu0roC8dAP6JQfhwjrRTz38mTyr7Nd/NkgadPItfmV/0xvL9XY fErsxgdWKCERKO/XPU22OyffrLvQz0Dx756f83Jbbdk1xWs4yddApQ5N/6FKECksrYie 6Y/2NbUmOpON4OkhSDSMJirsNKDpV5BN2n8KaERG5g/FWHT4NAnuMsvCrbYe8cjI6dcq Bm5Q== X-Gm-Message-State: AOAM5316wBq517k+hCNVf9fr8nEbTHHW5Wf582pWctMWpxRlCyfVoEtj twGoFG2tZ9Gt44WbyHmdsg0= X-Google-Smtp-Source: ABdhPJzlUcLhuo+g/a62WEA6jLXLmiQIkCv6h4g/iSXUMNMYvsHvrsNLZ5bvyPSKzfntcrvsFXDjrw== X-Received: by 2002:a19:f207:: with SMTP id q7mr2709890lfh.148.1599036686885; Wed, 02 Sep 2020 01:51:26 -0700 (PDT) Received: from [10.0.0.11] (84-10-19-38.static.chello.pl. [84.10.19.38]) by smtp.googlemail.com with ESMTPSA id w4sm827567ljm.50.2020.09.02.01.51.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2020 01:51:26 -0700 (PDT) To: "Zhang, Qi Z" , "dev@dpdk.org" Cc: "Zhao1, Wei" , "Guo, Jia" References: <20200810203108.28770-1-pawelwod@gmail.com> <039ED4275CED7440929022BC67E706115522E196@SHSMSX107.ccr.corp.intel.com> From: Pawel Wodkowski Message-ID: <9bca9caa-9cee-eb83-06aa-5b791f31e004@gmail.com> Date: Wed, 2 Sep 2020 10:51:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <039ED4275CED7440929022BC67E706115522E196@SHSMSX107.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 31.08.2020 05:46, Zhang, Qi Z wrote: > >> -----Original Message----- >> From: Pawel Wodkowski >> Sent: Tuesday, August 11, 2020 4:31 AM >> To: dev@dpdk.org >> Cc: Pawel Wodkowski ; Zhang, Qi Z >> ; Zhao1, Wei ; Guo, Jia >> >> Subject: [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW >> >> Flows like IP4 / UDP / RAW are not working because after parsing >> RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole >> parsing fail. >> >> Fixes: f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API") >> Cc: qi.z.zhang@intel.com >> Signed-off-by: Pawel Wodkowski >> --- >> drivers/net/ixgbe/ixgbe_flow.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c >> index b2a2bfc02..a2cb599b1 100644 >> --- a/drivers/net/ixgbe/ixgbe_flow.c >> +++ b/drivers/net/ixgbe/ixgbe_flow.c >> @@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev >> *dev, >> (((uint16_t)raw_spec->pattern[1]) << 8) | >> raw_spec->pattern[0]; >> rule->flex_bytes_offset = raw_spec->offset; >> + >> + item = next_no_fuzzy_pattern(pattern, item); > why we need to advance item pointer? > The next branch will advance it and compare with RTe_FLOW_ITEM_TYPE_END. > Can you double check if your pattern is IPv4/UDP/RAW/END ? True, pls ignore this patch. > >> } >> >> if (item->type != RTE_FLOW_ITEM_TYPE_END) { >> -- >> 2.17.1