From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 413BAA0C47; Tue, 12 Oct 2021 14:02:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D801541150; Tue, 12 Oct 2021 14:02:13 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 4F9FF41141 for ; Tue, 12 Oct 2021 14:02:13 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8C1B17F567; Tue, 12 Oct 2021 15:02:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8C1B17F567 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634040132; bh=XLK23T4Jr9CK7r5QJQKhOxztDjOGXbEk3CryuAdCliA=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=kVZhxG1a4h1ymnvjTE5adKrdhz0psPZx42SyrEXL29i64JTEeW8Vc9v2ronIIRES7 KBMbjPFctdw8NxWszSvX7utUUNrTn5Va874F0AGjuICuSYkbK5+ngw1RA6rLWWF8Kz pvMbQejTojmof+H2mGmyzCe6nHvtSJ+Vu8+MaDPw= To: Martin Havlik , Thomas Monjalon , Ferruh Yigit , "Min Hu (Connor)" , Ajit Khaparde , Xueming Li , Bing Zhao , Chengchang Tang Cc: Jan Viktorin , dev@dpdk.org, chas3@att.com, haiyue.wang@intel.com, ivan.ilchenko@oktetlabs.ru, aman.deep.singh@intel.com, kirankn@juniper.net, lirongqing@baidu.com, Ori Kam References: <20211005171914.2936-1-xhavli56@stud.fit.vutbr.cz> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <9bd1d5b2-3372-3f48-e739-ef4e5a8689ae@oktetlabs.ru> Date: Tue, 12 Oct 2021 15:02:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211005171914.2936-1-xhavli56@stud.fit.vutbr.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] lib/ethdev: introduce RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Summary prefix should be just "ethdev: " and summary should be human readable. It should not refer to defines etc. On 10/5/21 8:19 PM, Martin Havlik wrote: > Not all PMDs allow RTE flow rules to be created before start. > This capability will be set for the ones that allow it. > > Signed-off-by: Martin Havlik > --- > lib/ethdev/rte_ethdev.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index bef24173cf..3115a6fccf 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -1448,6 +1448,8 @@ struct rte_eth_conf { > #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001 > /** Device supports Tx queue setup after device started. */ > #define RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP 0x00000002 > +/** Device supports RTE Flow rule creation before device start. */ > +#define RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START 0x00000004 > /**@}*/ > > /* > I think that rte_flow_create() should check the capability in !dev->data->dev_started case and return error if capability is not advertised. The only problem here is to avoid dev_info get on each rte_flow_create() call.