From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 7939B1B1B4 for ; Thu, 1 Feb 2018 13:52:34 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id DE9B010005E; Thu, 1 Feb 2018 12:52:32 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 1 Feb 2018 12:52:26 +0000 To: Shreyansh Jain , CC: , , , , References: <20180201124439.21633-1-shreyansh.jain@nxp.com> <20180201124823.22621-1-shreyansh.jain@nxp.com> From: Andrew Rybchenko Message-ID: <9c03ab22-4da7-86ab-ca1f-a5c689621d89@solarflare.com> Date: Thu, 1 Feb 2018 15:52:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180201124823.22621-1-shreyansh.jain@nxp.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23634.003 X-TM-AS-Result: No--12.907400-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1517489554-IYSZ0iJ-j1Kn Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] doc: add preferred burst size support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 12:52:34 -0000 On 02/01/2018 03:48 PM, Shreyansh Jain wrote: > rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value > is smaller than requested, application can consider it end of packet > stream. Some hardware can only support smaller burst sizes which need > to be advertised. Similar is the case for Tx burst. > > This patch adds deprecation notice for rte_eth_dev_info structure as > two new members, for preferred Rx and Tx burst size would be added - > impacting the size of the structure. > > Signed-off-by: Shreyansh Jain > --- > * Refer: http://dpdk.org/dev/patchwork/patch/32112 for context > > v2: > - fix spelling error in deprecation notice > > doc/guides/rel_notes/deprecation.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index d59ad5988..fdc7656fa 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -59,3 +59,11 @@ Deprecation Notices > be added between the producer and consumer structures. The size of the > structure and the offset of the fields will remain the same on > platforms with 64B cache line, but will change on other platforms. > + > +* ethdev: Currently, if the rte_eth_rx_burst() function returns a value less > + than *nb_pkts*, the application will assume that no more packets are present. > + Some of the hw queue based hardware can only support smaller burst for RX > + and TX and thus break the expectation of the rx_burst API. Similar is the > + case for TX burst. ``rte_eth_dev_info`` will be added with two new > + parameters, ``uint16_t pref_rx_burst`` and ``uint16_t pref_tx_burst``, > + for preferred RX and TX burst sizes, respectively. Acked-by: Andrew Rybchenko