From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3411CA00C4;
	Sun,  6 Nov 2022 10:49:59 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D410640691;
	Sun,  6 Nov 2022 10:49:58 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 147804003C
 for <dev@dpdk.org>; Sun,  6 Nov 2022 10:49:58 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 6414162;
 Sun,  6 Nov 2022 12:49:56 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 6414162
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1667728196;
 bh=LPnYKOtGP9958eLtGNxw6LcSjThuxdSBdal2Wr6hoG0=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=Xa5QfG2sJhjgslKAyB8wG2Axh13ZpzeMwDu+6IZ+gjl6GdDZVZG4rUg6kX6DapUsW
 HTdFqolw6soAbTJC7OKxWVQQbljcaBx3d8WEiqVmIytqQZJnnAVgvcqtL8Pw4jVmrO
 ckoKyzZRLoO7w6zhA+KcabkUoBP+R1nuSFlj9fCI=
Message-ID: <9c27a0af-a6f8-fd0e-0b01-ed0d703ac20d@oktetlabs.ru>
Date: Sun, 6 Nov 2022 12:49:56 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] app/testpmd: fix MAC header in csum forward engine
Content-Language: en-US
To: "lihuisong (C)" <lihuisong@huawei.com>,
 Gregory Etelson <getelson@nvidia.com>, dev@dpdk.org
Cc: matan@nvidia.com, rasland@nvidia.com,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang
 <yuying.zhang@intel.com>, Chenbo Xia <chenbo.xia@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>
References: <20221026110721.26226-1-getelson@nvidia.com>
 <f95c5907-ab8d-950c-b255-9bb7db98c5b7@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <f95c5907-ab8d-950c-b255-9bb7db98c5b7@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 10/27/22 07:05, lihuisong (C) wrote:
> 
> 在 2022/10/26 19:07, Gregory Etelson 写道:
>> MLX5 SR-IOV TX engine will not transmit Ethernet frame
>> if destination MAC address matched local port address. The frame ether
>> looped-back to RX or dropped, depending on the port configuration.
>>
>> Application running over MLX5 SR-IOV port cannot transmit packet
>> polled from RX queue as-is. The packet Ethernet destination address
>> must be changed.
>>
>> The patch adds new run-time configuration parameter to the `csum`
>> forwarding engine to control MAC addresses configuration:
>>
>> testpmd> csum mac-swap on|off <port_id>
>>
>> `mac-swap on`  replace MAC addresses.
>> `mac-swap off` keep Ethernet header unchanged.
>>
>> Fixes: 9b4ea7ae77fa ("app/testpmd: revert MAC update in checksum 
>> forwarding")
>> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Huisong Li <lihuisong@huawei.com>

Applied to dpdk-next-net/main, thanks.