DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test: add missing cleanup to one of the failure paths
@ 2018-11-08 11:44 Anatoly Burakov
  2018-11-14  3:58 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Anatoly Burakov @ 2018-11-08 11:44 UTC (permalink / raw)
  To: dev; +Cc: bruce.richardson

One of the failure paths were not updated to clean up on exit,
most likely due to rebase error. Fix the failure path to clean
up instead of simply exiting.

Fixes: 3f9e31d71d63 ("test: clean up on exit")

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 test/test/test.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/test/test/test.c b/test/test/test.c
index 24df6299e..12fabd0ba 100644
--- a/test/test/test.c
+++ b/test/test/test.c
@@ -102,8 +102,10 @@ main(int argc, char **argv)
 		/* merge argc/argv and the environment args */
 		all_argc = argc + eargc;
 		all_argv = malloc(sizeof(*all_argv) * (all_argc + 1));
-		if (all_argv == NULL)
-			return -1;
+		if (all_argv == NULL) {
+			ret = -1;
+			goto out;
+		}
 
 		for (i = 0; i < argc; i++)
 			all_argv[i] = argv[i];
-- 
2.17.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] test: add missing cleanup to one of the failure paths
  2018-11-08 11:44 [dpdk-dev] [PATCH] test: add missing cleanup to one of the failure paths Anatoly Burakov
@ 2018-11-14  3:58 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-11-14  3:58 UTC (permalink / raw)
  To: Anatoly Burakov; +Cc: dev, bruce.richardson

08/11/2018 12:44, Anatoly Burakov:
> One of the failure paths were not updated to clean up on exit,
> most likely due to rebase error. Fix the failure path to clean
> up instead of simply exiting.
> 
> Fixes: 3f9e31d71d63 ("test: clean up on exit")
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-14  3:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 11:44 [dpdk-dev] [PATCH] test: add missing cleanup to one of the failure paths Anatoly Burakov
2018-11-14  3:58 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).