From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vfio: reformat logs
Date: Thu, 1 Apr 2021 12:24:41 +0100 [thread overview]
Message-ID: <9c5f5e42-6bda-56ac-cf4e-fe449e945113@intel.com> (raw)
In-Reply-To: <20210308222410.819751-1-thomas@monjalon.net>
On 08-Mar-21 10:24 PM, Thomas Monjalon wrote:
> The log messages had various issues:
> - split on 2 lines, making search (grep) difficult
> - long lines (can be split after the string)
> - indented for no good reason (parent message may have higher log level)
> - inconsistent use of __func__, not meaningful context for user
> - lack of context (general message not mentioning VFIO)
> - log level too high (more below)
>
> Message having its level decreased from WARNING to NOTICE:
> "not managed by VFIO driver, skipping"
> Message having its level decreased from INFO to DEBUG:
> "Probing VFIO support..."
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-04-01 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 22:24 Thomas Monjalon
2021-04-01 11:24 ` Burakov, Anatoly [this message]
2021-04-09 13:27 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c5f5e42-6bda-56ac-cf4e-fe449e945113@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).