From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F7AAA0579; Thu, 1 Apr 2021 13:25:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B87A2141078; Thu, 1 Apr 2021 13:25:01 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 48DC44067B for ; Thu, 1 Apr 2021 13:25:00 +0200 (CEST) IronPort-SDR: LBwS6xKY3zXZ2pY3BVqNRDbNSTRIWR5WpGlXA7G346//WGmKFY9CeWG/FAMCF1dNJ9eKg8AMDy ToznxjBL/CJg== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="256208047" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="256208047" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 04:24:43 -0700 IronPort-SDR: C57oxqBaqJeajLgn7PWnZ1XIEkXbBnGg+y9nRL8QcW+oKrluDJ2eZB+Yv8K3erNhgGr39Ju9HQ UEwppbE9qTYw== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="596301178" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.250.93]) ([10.213.250.93]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 04:24:42 -0700 To: Thomas Monjalon , dev@dpdk.org References: <20210308222410.819751-1-thomas@monjalon.net> From: "Burakov, Anatoly" Message-ID: <9c5f5e42-6bda-56ac-cf4e-fe449e945113@intel.com> Date: Thu, 1 Apr 2021 12:24:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210308222410.819751-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vfio: reformat logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08-Mar-21 10:24 PM, Thomas Monjalon wrote: > The log messages had various issues: > - split on 2 lines, making search (grep) difficult > - long lines (can be split after the string) > - indented for no good reason (parent message may have higher log level) > - inconsistent use of __func__, not meaningful context for user > - lack of context (general message not mentioning VFIO) > - log level too high (more below) > > Message having its level decreased from WARNING to NOTICE: > "not managed by VFIO driver, skipping" > Message having its level decreased from INFO to DEBUG: > "Probing VFIO support..." > > Signed-off-by: Thomas Monjalon > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly