DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bus/pci: set intr_handle type for secondary processes
Date: Thu, 18 Oct 2018 17:26:35 +0100	[thread overview]
Message-ID: <9c5faf3e-5a53-0ff4-9457-10165879689c@intel.com> (raw)
In-Reply-To: <1538051424-24172-1-git-send-email-alejandro.lucero@netronome.com>

On 27-Sep-18 1:30 PM, Alejandro Lucero wrote:
> Invoking rte_pci_read/write_config functions requires device with
> a intr_handle type for using VFIO or UIO driver related functions.
> 
> Secondary processes rely on primary processes for device initialization
> so they do not usually require using these functions. However, some PMDs,
> like NFP PMD, require using these functions even for secondary processes.
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---

Hi Alejandro,

I’m curious of consequences of setting intr handle to a valid value when 
we don’t have an interrupt thread. Something may try to use it (although 
I couldn’t find any such usage).

PCI config read really uses intr handle type to discover userspace 
driver type – this seems ever so slightly wrong, and looks like 
something that should be part of rte_device somewhere, independent of 
interrupt types. Do we have any other alternative to do the same thing 
(i.e. know what userspace driver is used for a particular PCI device)?

-- 
Thanks,
Anatoly

  reply	other threads:[~2018-10-18 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 12:30 Alejandro Lucero
2018-10-18 16:26 ` Burakov, Anatoly [this message]
2018-10-18 16:41   ` Alejandro Lucero
2018-10-19  8:02     ` Burakov, Anatoly
2018-10-19 14:57       ` Alejandro Lucero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c5faf3e-5a53-0ff4-9457-10165879689c@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).