From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id CF0B41B13C for ; Thu, 18 Oct 2018 18:26:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2018 09:26:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,397,1534834800"; d="scan'208";a="93091622" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.17.135]) ([10.252.17.135]) by orsmga003.jf.intel.com with ESMTP; 18 Oct 2018 09:26:35 -0700 To: Alejandro Lucero , dev@dpdk.org References: <1538051424-24172-1-git-send-email-alejandro.lucero@netronome.com> From: "Burakov, Anatoly" Message-ID: <9c5faf3e-5a53-0ff4-9457-10165879689c@intel.com> Date: Thu, 18 Oct 2018 17:26:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1538051424-24172-1-git-send-email-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] bus/pci: set intr_handle type for secondary processes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 16:26:38 -0000 On 27-Sep-18 1:30 PM, Alejandro Lucero wrote: > Invoking rte_pci_read/write_config functions requires device with > a intr_handle type for using VFIO or UIO driver related functions. > > Secondary processes rely on primary processes for device initialization > so they do not usually require using these functions. However, some PMDs, > like NFP PMD, require using these functions even for secondary processes. > > Signed-off-by: Alejandro Lucero > --- Hi Alejandro, I’m curious of consequences of setting intr handle to a valid value when we don’t have an interrupt thread. Something may try to use it (although I couldn’t find any such usage). PCI config read really uses intr handle type to discover userspace driver type – this seems ever so slightly wrong, and looks like something that should be part of rte_device somewhere, independent of interrupt types. Do we have any other alternative to do the same thing (i.e. know what userspace driver is used for a particular PCI device)? -- Thanks, Anatoly