From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>, dev <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
"Chen, Zhaoyan" <zhaoyan.chen@intel.com>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v5 8/8] net/igc: refine debug build option
Date: Thu, 25 Mar 2021 15:43:54 +0000 [thread overview]
Message-ID: <9c61411a-7088-45fd-7085-e6fe1f8b4af1@intel.com> (raw)
In-Reply-To: <CAJFAV8yTG++85u0Xw1vYSgmPJB2F98qqLQOQ_txenCxJPdE9yA@mail.gmail.com>
On 3/24/2021 8:31 PM, David Marchand wrote:
> On Wed, Mar 24, 2021 at 8:27 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 3/23/2021 11:07 AM, Qi Zhang wrote:
>>> 1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX.
>>> 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX.
>>> 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX
>>>
>>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>>
>> CI is reporting a build error [1], I don't reproduce the error and I assume it
>> is false positive but can you please check it?
>>
>> Also cc'ed Zhaoyan & Aaron for the possible CI issue.
>>
>> [1]
>> http://mails.dpdk.org/archives/test-report/2021-March/184153.html
>>
>
> Not sure what gcc+debug target is, but I guess it passes the old config item.
> The compat stuff should be placed in rte_config.h (or something
> similar to config/rte_compatibility_defines.h) and not in
> lib/librte_ethdev/rte_ethdev.h.
>
> To reproduce:
> $ meson configure $HOME/builds/build-gcc-static/
> -Dc_args="-DRTE_LIBRTE_ETHDEV_DEBUG=1"
> $ ./devtools/test-meson-builds.sh
Thanks for the steps, I can reproduce it. The alias is not working because
'rte_ethdev.h' where the alias is defined is not included in this path.
Following update should fix it, what do you think?
diff --git a/drivers/net/e1000/base/meson.build
b/drivers/net/e1000/base/meson.build
index d13f693d3eb8..a9f92cbc4770 100644
--- a/drivers/net/e1000/base/meson.build
+++ b/drivers/net/e1000/base/meson.build
@@ -33,6 +33,6 @@ foreach flag: error_cflags
endforeach
base_lib = static_library('e1000_base', sources,
- dependencies: static_rte_eal,
+ dependencies: [static_rte_eal,static_rte_ethdev],
c_args: c_args)
base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/e1000/e1000_logs.h b/drivers/net/e1000/e1000_logs.h
index 86f546b0f9ed..210c3447c66c 100644
--- a/drivers/net/e1000/e1000_logs.h
+++ b/drivers/net/e1000/e1000_logs.h
@@ -7,6 +7,9 @@
#include <rte_log.h>
+/* included because of RTE_LIBRTE_ETHDEV_DEBUG alias */
+#include <rte_ethdev.h>
+
extern int e1000_logtype_init;
#define PMD_INIT_LOG(level, fmt, args...) \
next prev parent reply other threads:[~2021-03-25 15:44 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 12:16 [dpdk-dev] [PATCH 0/8] ether: refine debug compile option Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 1/8] " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 2/8] net/fm10k: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 3/8] net/e1000: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 4/8] net/i40e: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 5/8] net/iavf: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 6/8] net/ice: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 7/8] net/ixgbe: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 8/8] net/igc: " Qi Zhang
2021-03-10 12:35 ` [dpdk-dev] [PATCH 0/8] ether: " Ferruh Yigit
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 1/8] " Qi Zhang
2021-03-16 13:05 ` Ferruh Yigit
2021-03-16 13:39 ` Thomas Monjalon
2021-03-16 14:12 ` Bruce Richardson
2021-03-16 23:29 ` Zhang, Qi Z
2021-03-16 16:37 ` Ferruh Yigit
2021-03-22 17:24 ` Ferruh Yigit
2021-03-23 8:43 ` Zhang, Qi Z
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 2/8] net/fm10k: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 3/8] net/e1000: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 4/8] net/i40e: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 5/8] net/iavf: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 6/8] net/ice: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 7/8] net/ixgbe: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 8/8] net/igc: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 0/9] ether: refine debug build option Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 1/9] " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 2/9] net: replace " Qi Zhang
2021-03-17 21:47 ` Ferruh Yigit
2021-03-17 22:00 ` Thomas Monjalon
2021-03-18 0:58 ` Zhang, Qi Z
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 3/9] net/fm10k: refine debug " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 4/9] net/e1000: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 5/9] net/i40e: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 6/9] net/iavf: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 7/9] net/ice: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 8/9] net/ixgbe: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 9/9] net/igc: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 0/8] ether: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 1/8] " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 2/8] net/fm10k: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 3/8] net/e1000: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 4/8] net/i40e: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 5/8] net/iavf: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 6/8] net/ice: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 7/8] net/ixgbe: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 8/8] net/igc: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 0/8] ether: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 1/8] " Qi Zhang
2021-03-23 14:44 ` Ferruh Yigit
2021-03-23 21:14 ` Thomas Monjalon
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 2/8] net/fm10k: " Qi Zhang
2021-03-23 14:45 ` Ferruh Yigit
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 3/8] net/e1000: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 4/8] net/i40e: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 5/8] net/iavf: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 6/8] net/ice: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 7/8] net/ixgbe: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 8/8] net/igc: " Qi Zhang
2021-03-24 19:27 ` Ferruh Yigit
2021-03-24 20:31 ` David Marchand
2021-03-25 15:43 ` Ferruh Yigit [this message]
2021-03-30 14:06 ` Ferruh Yigit
2021-03-23 11:08 ` [dpdk-dev] [PATCH v5 0/8] ether: " Zhang, Qi Z
2021-03-23 14:47 ` Ferruh Yigit
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 1/8] " Qi Zhang
2021-04-01 14:30 ` Ferruh Yigit
2021-05-05 11:45 ` Ferruh Yigit
2021-05-05 12:21 ` Michał Krawczyk
2021-05-05 14:38 ` Ferruh Yigit
2021-05-06 11:09 ` [dpdk-dev] [EXT] " Rasesh Mody
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 2/8] net/fm10k: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 3/8] net/e1000: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 4/8] net/i40e: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 5/8] net/iavf: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 6/8] net/ice: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 7/8] net/ixgbe: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 8/8] net/igc: " Qi Zhang
2021-04-01 14:11 ` [dpdk-dev] [PATCH v6 0/8] ether: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c61411a-7088-45fd-7085-e6fe1f8b4af1@intel.com \
--to=ferruh.yigit@intel.com \
--cc=aconole@redhat.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=thomas@monjalon.net \
--cc=xiao.w.wang@intel.com \
--cc=zhaoyan.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).