From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 388B4952
 for <dev@dpdk.org>; Mon,  6 Mar 2017 11:24:23 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 06 Mar 2017 02:24:23 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,253,1484035200"; d="scan'208";a="232743563"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.191.192])
 ([10.254.191.192])
 by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2017 02:24:21 -0800
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
References: <1488469608-2252-1-git-send-email-arybchenko@solarflare.com>
 <1488469608-2252-6-git-send-email-arybchenko@solarflare.com>
Cc: Ivan Malov <ivan.malov@oktetlabs.ru>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9c7df3cc-d35b-39b0-3bde-5458224ffec0@intel.com>
Date: Mon, 6 Mar 2017 10:24:20 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <1488469608-2252-6-git-send-email-arybchenko@solarflare.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 5/6] net/sfc: port must not fail to start if
 Rx mode is rejected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Mar 2017 10:24:24 -0000

On 3/2/2017 3:46 PM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>

Hi Ivan,

Can you please update patch title to indicate what has been done,
starting with a verb. It is harder to understand patch content from
statements.

Thanks,
ferruh


> 
> If Rx mode is unacceptable, in particular, when promiscuous
> or all-multicast filters are not allowed while running over
> PCI function which is not a member of appropriate privilege
> groups, the driver has to cope with the failures gracefully
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Reviewed-by: Andrew Lee <alee@solarflare.com>
<...>