From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6EBFE293B for ; Thu, 23 Aug 2018 11:35:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2018 02:35:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,278,1531810800"; d="scan'208";a="84253447" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga001.jf.intel.com with ESMTP; 23 Aug 2018 02:35:35 -0700 From: Ferruh Yigit To: "Wiles, Keith" , "Kurakin, Ilia" Cc: DPDK , "Richardson, Bruce" , "Khatko, Roman P" References: <1530623488-69056-1-git-send-email-ilia.kurakin@intel.com> <1532002902-25187-1-git-send-email-ilia.kurakin@intel.com> <4a3974e2-6116-0855-44a6-1795d485fcbf@intel.com> Openpgp: preference=signencrypt Message-ID: <9c8b6e92-40e1-f769-248e-0cca0fbed15c@intel.com> Date: Thu, 23 Aug 2018 10:35:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4a3974e2-6116-0855-44a6-1795d485fcbf@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] ethdev: change vtune profiling approach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 09:35:43 -0000 On 8/22/2018 6:13 PM, Ferruh Yigit wrote: > On 7/24/2018 2:17 PM, Wiles, Keith wrote: >> >> >>> On Jul 19, 2018, at 7:21 AM, ilia.kurakin@intel.com wrote: >>> >>> From: Ilia Kurakin >>> >>> The patch changes rx_burst profiling approach: >>> 1. VTune's instrumentation is removed >>> 2. empty hook callback for profiling is added >>> This way all VTune-specific logic moves to the VTune side. >>> Hook is enabled only when CONFIG_RTE_ETHDEV_PROFILE_WITH_VTUNE option >>> is turned on. VTune uses this hook to attach to the polling cycle. It >>> is not possible to attach to the rx_burst directly, as it is inline. >>> >>> Signed-off-by: Ilia Kurakin >>> >>> --- >>> >>> -v2 change: >>> fix coding style issue, re-merge >>> >>> config/common_base | 2 +- >>> doc/guides/prog_guide/profile_app.rst | 34 ++--------- >>> lib/librte_ethdev/ethdev_profile.c | 103 +++++----------------------------- >>> lib/librte_ethdev/ethdev_profile.h | 6 +- >>> lib/librte_ethdev/rte_ethdev.c | 4 +- >>> 5 files changed, 25 insertions(+), 124 deletions(-) >>> >> >> Looks good and a cleaner method. >> >> Acked-by: Keith Wiles > > Acked-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.