From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mukawa@igel.co.jp>
Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com
 [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 7EDAAC532
 for <dev@dpdk.org>; Thu, 16 Jun 2016 04:03:55 +0200 (CEST)
Received: by mail-pa0-f53.google.com with SMTP id hl6so12901801pac.2
 for <dev@dpdk.org>; Wed, 15 Jun 2016 19:03:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=igel-co-jp.20150623.gappssmtp.com; s=20150623;
 h=subject:to:references:cc:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-transfer-encoding;
 bh=7F/ABFkmShLsqdcJ/V/5UWsvdglLuKRs9hUzhx6eOc0=;
 b=C1xhQYy1znspTVkhvw/av0EJkuGZmOv/qeeJP68wFQnvetvlsyWJifkh0LWuOmzcXs
 sBH33iffnf8EYfl66wp3kbCBGxucuTTf4Hb+RwKRYUxRvJS7WVjaRB/AB202WwgPu4wR
 r/6fSdu6D2wFSKmP1DqKXrYdnrKXzg7M4CgiwJAyIn6CccA/I1lGTsMRi1bcSPjon9fZ
 mWf4IOna3n8dC+6WAwgNJrrEI60qJZiw/HxdzXS88qgTaIpPAHOvvbpyfgVKuPFJ/6dB
 36002tCs7bELfPGJ3sDu065XpULtw/33o2c2ZTRDDqhyNd+Y7CLEXHyjUGGvceXO8dcA
 /G0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:subject:to:references:cc:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-transfer-encoding;
 bh=7F/ABFkmShLsqdcJ/V/5UWsvdglLuKRs9hUzhx6eOc0=;
 b=btNAt2ukdMASjE/BSV5fyGdGhY6GDxiZCD1LjSIEJWJo1btJNIBdJGb6rz2x8qb5dM
 bynxpS8gFfJn+c7BYVUvFvPUidPN1rucTsgleX20lWsptWw0UVwH+kj2ZjIkscBp1hVh
 HvxcdvKJLTWKnTTsue0oVivn9DEL4Xdzl7SI7J2rOiXbk/q3S0n5vCT/pXdeiM7eIt+5
 wijISC0Q0bnjCiBQ+xSdH4MhvvFzrfZJ9o49mbFKJcxFNyXZXC4AmYRbf6VhR/oc6KfM
 gaF7505WkidFYlxpDxBGmw3AFwhjJzgdSRmzzxzn55BCxISY3yjMSVJCw+CsNxELavH+
 Cdog==
X-Gm-Message-State: ALyK8tIvAvSnStoqDmMpjf3ZCgaBMHparVPUoUBtoWZdjRG52HSFaSJKT7LITUV7NiyJGw==
X-Received: by 10.66.132.72 with SMTP id os8mr2089550pab.63.1466042634840;
 Wed, 15 Jun 2016 19:03:54 -0700 (PDT)
Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132])
 by smtp.googlemail.com with ESMTPSA id e20sm48449388pfk.1.2016.06.15.19.03.51
 (version=TLSv1/SSLv3 cipher=OTHER);
 Wed, 15 Jun 2016 19:03:54 -0700 (PDT)
To: David Marchand <david.marchand@6wind.com>
References: <1465961209-28309-1-git-send-email-mukawa@igel.co.jp>
 <CALwxeUttO=rSFB9eo4vD5hz68ZT1KMSp1KETo2RvT0rvvQUVhw@mail.gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Mcnamara, John"
 <john.mcnamara@intel.com>, michalx.k.jastrzebski@intel.com
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Message-ID: <9c9be936-ab19-166b-56ec-65ffc809fc95@igel.co.jp>
Date: Thu, 16 Jun 2016 11:03:50 +0900
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <CALwxeUttO=rSFB9eo4vD5hz68ZT1KMSp1KETo2RvT0rvvQUVhw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] eal: Fix wrong error checking of
 rte_eal_parse_devargs_str()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2016 02:03:55 -0000

On 2016/06/15 23:48, David Marchand wrote:
> On Wed, Jun 15, 2016 at 5:26 AM, Tetsuya Mukawa <mukawa@igel.co.jp> wrote:
>> Currently, a return value of strdup() isn't checked correctly.
>> The patch fixes it.
>>
>> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> 
> Idem, the title does not need the function name to describe what is going wrong.
> 
> This might deserve a fixline, I traced this to 0fe11ec592b2 ("eal: add
> vdev init and uninit").

Will add it.

Thanks,
Tetsuya