From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, Wei Hu <xavier.huwei@huawei.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Chengchang Tang <tangchengchang@huawei.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: rename FEC API parameters
Date: Fri, 29 Jan 2021 16:54:38 +0000 [thread overview]
Message-ID: <9cc5b878-fc98-82a6-cb2d-88045134f2fc@intel.com> (raw)
In-Reply-To: <6b95ed0f-a6ec-a259-37fc-3ce6b74dd43b@huawei.com>
On 1/16/2021 1:48 AM, Min Hu (Connor) wrote:
> Hi, Ferruh,
> this change origin from the opinions by Andrew Rybchenko
> <arybchenko@solarflare.com>. snippets like this:
>
> > +__rte_experimental
> > +int rte_eth_fec_get(uint16_t port_id, uint32_t *mode);
> > +
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
> > + *
> > + * Set Forward Error Correction(FEC) mode.
> > + *
> > + * @param port_id
> > + * The port identifier of the Ethernet device.
> > + * @param mode
> > + * The FEC mode.
>
> mode -> fec_capa
> A bitmask of enabled FEC modes. If AUTO bit is set, other
> bits specify FEC modes which may be negotiated. If AUTO
> bit is clear, specify FEC modes to be used (only one valid
> mode per speed may be set).
>
> > + * @return
> > + * - (0) if successful.
> > + * - (-EINVAL) if the FEC mode is not valid.
>
> Much more info could be referred to the patch:
> Re: [dpdk-dev] [PATCH V13 1/3] ethdev: introduce FEC API
> from arybchenko@solarflare.com
>
> thanks.
>
Got it, if the parameter name explicitly selected this way, dropping this patch.
prev parent reply other threads:[~2021-01-29 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 15:52 Ferruh Yigit
2021-01-15 16:48 ` Ajit Khaparde
2021-01-16 1:48 ` Min Hu (Connor)
2021-01-29 16:54 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cc5b878-fc98-82a6-cb2d-88045134f2fc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=humin29@huawei.com \
--cc=tangchengchang@huawei.com \
--cc=thomas@monjalon.net \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).