From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03AD645777; Fri, 9 Aug 2024 11:21:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CAFB142DC9; Fri, 9 Aug 2024 11:21:56 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 14F1B402A5 for <dev@dpdk.org>; Fri, 9 Aug 2024 11:21:55 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4WgJGD2z2tz20lBn; Fri, 9 Aug 2024 17:17:24 +0800 (CST) Received: from kwepemf500004.china.huawei.com (unknown [7.202.181.242]) by mail.maildlp.com (Postfix) with ESMTPS id CA7AD1A016C; Fri, 9 Aug 2024 17:21:52 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemf500004.china.huawei.com (7.202.181.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 9 Aug 2024 17:21:52 +0800 Message-ID: <9cdec652-203b-1a17-043d-2e874cbd3191@huawei.com> Date: Fri, 9 Aug 2024 17:21:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 0/3] bugfix about KEEP CRC offload From: Jie Hai <haijie1@huawei.com> To: <dev@dpdk.org>, <stephen@networkplumber.org>, <ferruh.yigit@amd.com>, <mb@smartsharesystems.com>, <andrew.rybchenko@oktetlabs.ru> CC: <huangdengdui@huawei.com>, <fengchengwen@huawei.com>, <lihuisong@huawei.com> References: <20240206011030.2007689-1-haijie1@huawei.com> <20240719090415.1513301-1-haijie1@huawei.com> In-Reply-To: <20240719090415.1513301-1-haijie1@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemf500004.china.huawei.com (7.202.181.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org All maintainers, Hi, kindly ping for review. Thanks, Jie Hai On 2024/7/19 17:04, Jie Hai wrote: > For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is > still be stripped in rare scenarios. Some users of hns3 are > already using this feature. So driver has to recaculate packet CRC. > In addition, in the mbuf, the data that exceeds the length specified > by pkt_len is invalid. Therefore, if the packet contains CRC data, > pkt_len should contain the CRC data length. However, almost of drivers > supported KEEP CRC feature didn't add the CRC data length to pkt_len. > > This patch adds description for KEEP CRC offload. > > Dengdui Huang (3): > ethdev: add description for KEEP CRC offload > net/hns3: fix packet length do not contain CRC data length > net/hns3: fix Rx packet without CRC data > > drivers/net/hns3/hns3_ethdev.c | 5 + > drivers/net/hns3/hns3_ethdev.h | 23 +++++ > drivers/net/hns3/hns3_rxtx.c | 134 ++++++++++++++++---------- > drivers/net/hns3/hns3_rxtx.h | 3 + > drivers/net/hns3/hns3_rxtx_vec.c | 3 +- > drivers/net/hns3/hns3_rxtx_vec_neon.h | 19 ---- > drivers/net/hns3/hns3_rxtx_vec_sve.c | 3 +- > lib/ethdev/rte_ethdev.h | 6 ++ > 8 files changed, 124 insertions(+), 72 deletions(-) >