From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0E4842B71; Mon, 22 May 2023 14:13:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60E39410D7; Mon, 22 May 2023 14:13:49 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 41A5640EE7; Mon, 22 May 2023 14:13:47 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QPx7w0yfRz18Lf1; Mon, 22 May 2023 20:09:16 +0800 (CST) Received: from [10.67.103.235] (10.67.103.235) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 22 May 2023 20:13:42 +0800 Subject: Re: [PATCH 0/5] ] net/hns3: add some features and bugfixes To: Ferruh Yigit , , , , References: <20230518112944.32276-1-liudongdong3@huawei.com> <77673fea-9dcf-3c21-f552-5941638e2025@amd.com> CC: , , From: Dongdong Liu Message-ID: <9cdf050d-8ef9-bd59-cd63-51feab6bf1e3@huawei.com> Date: Mon, 22 May 2023 20:13:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <77673fea-9dcf-3c21-f552-5941638e2025@amd.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.235] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh Many thanks for your review. On 2023/5/22 19:57, Ferruh Yigit wrote: > On 5/18/2023 12:29 PM, Dongdong Liu wrote: >> This patchset contains some features and bugfixes for hns3. >> >> Chengwen Feng (1): >> net/hns3: fix receive multiple firmware reset interrupts >> >> Dengdui Huang (2): >> net/hns3: fix loop code variable type mismatch >> net/hns3: add Tx/Rx descriptor logs >> >> Huisong Li (2): >> net/hns3: fix never set MAC flow control >> net/hns3: add flow control autoneg for fiber and backplane port > > > Can you please address following check-git-log [1] warnings: > > Headline too long: > net/hns3: add flow control autoneg for fiber and backplane port > Missing 'Fixes' tag: > net/hns3: fix loop code variable type mismatch > net/hns3: fix Rx multiple firmware reset interrupts > Thanks for pointing this, will fix. Thanks, Dongdong > > [1] > ./devtools/check-git-log.sh > . >