From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5A6A6A0510;
Sun, 8 May 2022 15:07:28 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 02030406B4;
Sun, 8 May 2022 15:07:28 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 3DD3A4068F
for <dev@dpdk.org>; Sun, 8 May 2022 15:07:26 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1652015245;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=GPhpSHWUzi2W4JUFmtJ9kHjLijRiFQXs0+TZVO4sYZE=;
b=bPtkOfGz/gCBfBhQZhk6Dz7zr9TORDxzhO6F4AXGoic7vmh5USZ8rfXYl+c74iYmbtbvL5
hiRxK4pTjwKEz/5+ISXzmxz2z2AR+TcWsGz0O0yZy6PXIaztEty2f+VR8tADItzM+4huvk
m+jd4z47MG0kcxsIJXjIWcTnt/Pxqsc=
Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com
[209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-669-BgRHziWkPM-d3pw7VSZWNw-1; Sun, 08 May 2022 09:07:24 -0400
X-MC-Unique: BgRHziWkPM-d3pw7VSZWNw-1
Received: by mail-qt1-f198.google.com with SMTP id
cn8-20020a05622a248800b002f3c7be2744so5218769qtb.17
for <dev@dpdk.org>; Sun, 08 May 2022 06:07:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:subject:to:cc:references:from:message-id:date
:user-agent:mime-version:in-reply-to:content-transfer-encoding
:content-language;
bh=GPhpSHWUzi2W4JUFmtJ9kHjLijRiFQXs0+TZVO4sYZE=;
b=4HC4LHttKAJPxb/FV2O/LEzzZ0xAzBMn/X8ErhK4tdVbhnThZxxCfR5xA1E8+BFvrd
1YwrrQwWtNcS699Q4HfwSgwblDIL7yEwOAndVWc4GnR7f6R0rlvV6QDWfCZSMiNjVUtl
apbiRexakRpotc7CVP97h3LtfxeRlW6AdNawb5YYj3GsxyJA0KVrctrLRUI8cLcAi1v4
00g0s86bGXEToE21qfUe6/BulByjR2vi1RG3GWv+j7xWeqwgps6tJO6L1ljyDUTcJkNV
IMOKLXDHnFyWqc3xqNgTdunWXI0bk+u4+QtBUsU50fqVHobGRKlt31ey3N7g7ArPNSek
Quyg==
X-Gm-Message-State: AOAM5318fE+NntNxwjji3TUpi2lR8taBIWVSTunHkZVNaT8qSXxJCC5/
07Hv8rUh6LnnPo7TaMy3/3SwXXDCDwOtnNzbPO/JPqdDQrOhffa4ML0dkjcmIPN7MkItuQnehiC
BZEU=
X-Received: by 2002:ae9:ef03:0:b0:6a0:5e42:2fa9 with SMTP id
d3-20020ae9ef03000000b006a05e422fa9mr3917363qkg.424.1652015244011;
Sun, 08 May 2022 06:07:24 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxYfR8LwfI/FVatybs969Ze5xG/i1JfmyXLrq8xWcOipu7zIjaC36i50PMsl3C51UeRlNVczQ==
X-Received: by 2002:ae9:ef03:0:b0:6a0:5e42:2fa9 with SMTP id
d3-20020ae9ef03000000b006a05e422fa9mr3917348qkg.424.1652015243823;
Sun, 08 May 2022 06:07:23 -0700 (PDT)
Received: from localhost.localdomain (024-205-208-113.res.spectrum.com.
[24.205.208.113]) by smtp.gmail.com with ESMTPSA id
o28-20020a05620a0d5c00b0069fc167df92sm5333811qkl.82.2022.05.08.06.07.21
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Sun, 08 May 2022 06:07:23 -0700 (PDT)
Subject: Re: [PATCH v2 2/5] baseband/acc100: modify validation code for ACC101
To: Nicolas Chautru <nicolas.chautru@intel.com>, dev@dpdk.org,
gakhil@marvell.com
Cc: thomas@monjalon.net, ray.kinsella@intel.com, bruce.richardson@intel.com,
hemant.agrawal@nxp.com, mingshan.zhang@intel.com, david.marchand@redhat.com
References: <1651083423-33202-1-git-send-email-nicolas.chautru@intel.com>
<1651083423-33202-3-git-send-email-nicolas.chautru@intel.com>
From: Tom Rix <trix@redhat.com>
Message-ID: <9cfd0654-d5b1-4bb8-eb9f-8709b95367db@redhat.com>
Date: Sun, 8 May 2022 06:07:20 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <1651083423-33202-3-git-send-email-nicolas.chautru@intel.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 4/27/22 11:17 AM, Nicolas Chautru wrote:
> The validation requirement is different for the two
> devices.
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 40 ++++++++++++++++++++++----------
> 1 file changed, 28 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index fca27ef..daf2ce0 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -1293,6 +1293,14 @@
> return (q->d->device_variant == ACC100_VARIANT);
> }
>
> +#ifdef RTE_LIBRTE_BBDEV_DEBUG
> +static inline bool
> +validate_op_required(struct acc100_queue *q)
There isn't an #else case so this will fail to build.
This i believe could be another function in private data fops i
suggested in the first patch.
Tom
> +{
> + return is_acc100(q);
> +}
> +#endif
> +