From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6564A09E4; Wed, 27 Jan 2021 13:48:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AAB1140D52; Wed, 27 Jan 2021 13:48:13 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A146C140D24; Wed, 27 Jan 2021 13:48:11 +0100 (CET) IronPort-SDR: d2QX0q5aQGSEAnr334I9KYzHwmXnPJ8b8c7kxm09OylHAOiwAf21qn+lmK9gQDsGcxMUKZzfye fYbAlNLt4yQQ== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="177495902" X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="177495902" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:48:10 -0800 IronPort-SDR: 7OCJmAGYBwafq9y+jfcVo8WS+bfJ0QfUMODKPsZW2lLKwd/tEFLgZgN0dQpTa/AUa3txAIBtXQ Anhyzc9gRNIQ== X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="430089218" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.215]) ([10.213.208.215]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:48:08 -0800 From: Ferruh Yigit To: Viacheslav Ovsiienko , dev@dpdk.org Cc: rasland@nvidia.com, matan@nvidia.com, orika@nvidia.com, thomas@monjalon.net, akozyrev@nvidia.com, stable@dpdk.org, Kevin Traynor , Luca Boccassi References: <1608311697-31529-1-git-send-email-viacheslavo@nvidia.com> <1611335529-26503-1-git-send-email-viacheslavo@nvidia.com> <1611335529-26503-2-git-send-email-viacheslavo@nvidia.com> Message-ID: <9d0d6047-9c72-2c98-8d01-88d6141f6fac@intel.com> Date: Wed, 27 Jan 2021 12:48:06 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] net/mlx5: optimize inline mbuf freeing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/27/2021 12:44 PM, Ferruh Yigit wrote: > On 1/22/2021 5:12 PM, Viacheslav Ovsiienko wrote: >> The mlx5 PMD supports packet data inlining by pushing data >> to the transmit descriptor. If packet is short enough and all >> data are inline, the mbuf is not needed for data send anymore >> and can be freed. >> >> The mbuf free was performed in the most inner loop building >> the transmit descriptors. This patch postpones the mbuf free >> transaction to the tx_burst routine exit, optimizing the loop >> and allowing the bulk freeing for the multiple mbufs in single >> pool API call. >> >> Cc: stable@dpdk.org >> > > Hi Slava, > > This patch is optimization for inline mbufs, right, it is not a fix, should it > be backported? > > cc'ed LTS maintainers. > cc'ed now. > I am dropping the stable to for now in the next-net, can add it later based on > discussion result. > >> Signed-off-by: Viacheslav Ovsiienko >