From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35B3BA04D7; Thu, 3 Sep 2020 11:18:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74AD01C0AF; Thu, 3 Sep 2020 11:18:01 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 1E2D5E07 for ; Thu, 3 Sep 2020 11:17:59 +0200 (CEST) IronPort-SDR: DGu3a2nSMAakOl2pQFAcaqbUhOn2yQ15GbzUpOwEDZ6WObC8P8CyFm+45ZBjt9T4pv6W7u1L8o BtIELUYCJUyw== X-IronPort-AV: E=McAfee;i="6000,8403,9732"; a="137595897" X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="137595897" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 02:17:59 -0700 IronPort-SDR: aSaPUSkQyOgI+Rnc/lfAEIx2ee9nMnMPkL/Pf+xj7VWlImUc9+V7kcXhZuhX+Zth7/LD6kkVSq Y5kvVMJA/dJg== X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="477984385" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.246.71]) ([10.213.246.71]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 02:17:57 -0700 To: "Xu, Rosen" , "Chautru, Nicolas" , "dev@dpdk.org" , "akhil.goyal@nxp.com" Cc: "Richardson, Bruce" References: <1597796731-57841-1-git-send-email-nicolas.chautru@intel.com> <1597796731-57841-3-git-send-email-nicolas.chautru@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <9d2d489f-0cf6-7c51-85ec-f7d8015620a6@intel.com> Date: Thu, 3 Sep 2020 10:17:54 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 02/11] baseband/acc100: add register definition file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/3/2020 3:15 AM, Xu, Rosen wrote: > Hi, > >> -----Original Message----- >> From: Chautru, Nicolas >> Sent: Sunday, August 30, 2020 1:40 >> To: Xu, Rosen ; dev@dpdk.org; akhil.goyal@nxp.com >> Cc: Richardson, Bruce >> Subject: RE: [dpdk-dev] [PATCH v3 02/11] baseband/acc100: add register >> definition file >> >> Hi Rosen, >> >>> From: Xu, Rosen >>> >>> Hi, >>> >>>> -----Original Message----- >>>> From: dev On Behalf Of Nicolas Chautru >>>> Sent: Wednesday, August 19, 2020 8:25 >>>> To: dev@dpdk.org; akhil.goyal@nxp.com >>>> Cc: Richardson, Bruce ; Chautru, Nicolas >>>> >>>> Subject: [dpdk-dev] [PATCH v3 02/11] baseband/acc100: add register >>>> definition file >>>> >>>> Add in the list of registers for the device and related >>>> HW specs definitions. >>>> >>>> Signed-off-by: Nicolas Chautru <...> >>>> @@ -0,0 +1,1068 @@ >>>> +/* SPDX-License-Identifier: BSD-3-Clause >>>> + * Copyright(c) 2017 Intel Corporation >>>> + */ >>>> + >>>> +#ifndef ACC100_PF_ENUM_H >>>> +#define ACC100_PF_ENUM_H >>>> + >>>> +/* >>>> + * ACC100 Register mapping on PF BAR0 >>>> + * This is automatically generated from RDL, format may change with >> new >>>> RDL >>>> + * Release. >>>> + * Variable names are as is >>>> + */ >>>> +enum { >>>> + HWPfQmgrEgressQueuesTemplate = 0x0007FE00, >>>> + HWPfQmgrIngressAq = 0x00080000, >>>> + HWPfQmgrArbQAvail = 0x00A00010, <...> >>>> + HwPfPcieGpexPexPioArcacheControl = 0x00D9C304, >>>> + HwPfPcieGpexPabObSizeControlVc0 = 0x00D9C310 >>>> +}; >>> >>> Why not macro definition but enum? >>> >> >> Well both would "work". The main reason really is that this long enum is >> automatically generated from RDL output from the chip design. >> But still in that case I would argue enum is cleaner so that to put all these >> incremental addresses together. >> This can also helps when debugging as this is kept post compilation as both >> value and enum var. >> Any concern or any BKM from other PMDs? > > Can you read DPDK coding style firstly? > https://doc.dpdk.org/guides-16.11/contributing/coding_style.html > It's not make sense to define HW address in your way. Both works as Nicolas said, and I agree enum is better for the reasons Nicolas mentioned. Also coding style says: " Wherever possible, enums and inline functions should be preferred to macros, since they provide additional degrees of type-safety and can allow compilers to emit extra warnings about unsafe code. " What is the concern to have enum instead of macro?