From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C23AA0C40; Tue, 8 Jun 2021 15:42:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E988740689; Tue, 8 Jun 2021 15:42:24 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id AC2604067A for ; Tue, 8 Jun 2021 15:42:23 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 37A227F4FE; Tue, 8 Jun 2021 16:42:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 37A227F4FE DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1623159743; bh=SZ0k9yVSDSUvQ/EJglmspN34Ub1b90j583Y8Lop6+GY=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=ZIT9rIfQsOVVf0uUwY99leoMWRsYvfxrcu2p9votMczn4NaK5h3ymrlVd98AqRy8e axe1QkdiW8TqFF3Wpc+eZz6bo4agVVsHgcxJuLSrGRwYrQlAtiXHRojeDByMGTiyUr u6QXLhXteiKbVLoiasitRVmKoV+fWa4Pmv4d/nf8= To: Apeksha Gupta , ferruh.yigit@intel.com Cc: dev@dpdk.org, hemant.agrawal@nxp.com, sachin.saxena@nxp.com References: <20210430043424.19752-1-apeksha.gupta@nxp.com> <20210430043424.19752-5-apeksha.gupta@nxp.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <9d446ed8-a0b9-055c-b272-d24da6dd3cc5@oktetlabs.ru> Date: Tue, 8 Jun 2021 16:42:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210430043424.19752-5-apeksha.gupta@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/4] drivers/net/enetfec: add enqueue and dequeue support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/30/21 7:34 AM, Apeksha Gupta wrote: > This patch supported checksum offloads and add burst enqueue and > dequeue operations to the enetfec PMD. > > Loopback mode is added, compile time flag 'ENETFEC_LOOPBACK' is > used to enable this feature. By default loopback mode is disabled. > Basic features added like promiscuous enable, basic stats. Please, apply style fixes from the previous patches to the patch as well. > > Signed-off-by: Sachin Saxena > Signed-off-by: Apeksha Gupta > --- > doc/guides/nics/enetfec.rst | 4 + > doc/guides/nics/features/enetfec.ini | 5 + > drivers/net/enetfec/enet_ethdev.c | 212 +++++++++++- > drivers/net/enetfec/enet_rxtx.c | 499 +++++++++++++++++++++++++++ > 4 files changed, 719 insertions(+), 1 deletion(-) > create mode 100644 drivers/net/enetfec/enet_rxtx.c > > diff --git a/doc/guides/nics/enetfec.rst b/doc/guides/nics/enetfec.rst > index 10f495fb9..adbb52392 100644 > --- a/doc/guides/nics/enetfec.rst > +++ b/doc/guides/nics/enetfec.rst > @@ -75,6 +75,10 @@ ENETFEC driver. > ENETFEC Features > ~~~~~~~~~~~~~~~~~ > > +- Basic stats > +- Promiscuous > +- VLAN offload > +- L3/L4 checksum offload > - ARMv8 > > Supported ENETFEC SoCs > diff --git a/doc/guides/nics/features/enetfec.ini b/doc/guides/nics/features/enetfec.ini > index 570069798..fcc217773 100644 > --- a/doc/guides/nics/features/enetfec.ini > +++ b/doc/guides/nics/features/enetfec.ini > @@ -4,5 +4,10 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Features] > +Basic stats = Y > +Promiscuous mode = Y > +VLAN offload = Y > +L3 checksum offload = Y > +L4 checksum offload = Y I don't understand why all above features are in the patch. It looks like all could be added one by one after the patch with adds basic Rx/Tx suppport.