From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22E8E4292C; Thu, 13 Apr 2023 05:44:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A520E40A84; Thu, 13 Apr 2023 05:44:42 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id D54094021F for <dev@dpdk.org>; Thu, 13 Apr 2023 05:44:41 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PxljX07Lrz17SHy; Thu, 13 Apr 2023 11:41:04 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 13 Apr 2023 11:44:38 +0800 Subject: Re: [PATCH] dmadev: add tracepoints To: Bruce Richardson <bruce.richardson@intel.com> CC: <thomas@monjalon.net>, Kevin Laatz <kevin.laatz@intel.com>, <dev@dpdk.org> References: <20230412024808.41339-1-fengchengwen@huawei.com> <ZDZ/cXrhDvT8w+8/@bricha3-MOBL.ger.corp.intel.com> From: fengchengwen <fengchengwen@huawei.com> Message-ID: <9dbabadc-c2e6-1f5b-d7b3-d6b23b874c1d@huawei.com> Date: Thu, 13 Apr 2023 11:44:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <ZDZ/cXrhDvT8w+8/@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2023/4/12 17:52, Bruce Richardson wrote: > On Wed, Apr 12, 2023 at 02:48:08AM +0000, Chengwen Feng wrote: >> Add tracepoints at important APIs for tracing support. >> >> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> >> --- >> lib/dmadev/meson.build | 2 +- >> lib/dmadev/rte_dmadev.c | 39 ++++++-- >> lib/dmadev/rte_dmadev.h | 56 ++++++++--- >> lib/dmadev/rte_dmadev_trace.h | 133 +++++++++++++++++++++++++++ >> lib/dmadev/rte_dmadev_trace_fp.h | 113 +++++++++++++++++++++++ >> lib/dmadev/rte_dmadev_trace_points.c | 59 ++++++++++++ >> lib/dmadev/version.map | 10 ++ >> 7 files changed, 391 insertions(+), 21 deletions(-) >> create mode 100644 lib/dmadev/rte_dmadev_trace.h >> create mode 100644 lib/dmadev/rte_dmadev_trace_fp.h >> create mode 100644 lib/dmadev/rte_dmadev_trace_points.c >> > For completeness, do you have any numbers for the performance impact (if > any) to the DMA dataplane APIs with this tracing added? No, because: The dataplane trace points was disable default (unless the RTE_ENABLE_TRACE_FP is set), so there will no trace-points code default. So I think it will not impact performance default. > > /Bruce > > . >