From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id E820F23D; Wed, 25 Jul 2018 20:19:58 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 59A428197001; Wed, 25 Jul 2018 18:19:58 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-208.ams2.redhat.com [10.36.117.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1122E2026D68; Wed, 25 Jul 2018 18:19:56 +0000 (UTC) To: Shaopeng He , dev@dpdk.org Cc: qi.z.zhang@intel.com, "stable@dpdk.org" References: <20180710103727.209243-1-shaopeng.he@intel.com> From: Kevin Traynor Organization: Red Hat Message-ID: <9dc88a4d-310a-e2f9-f73c-aec60b3dc56b@redhat.com> Date: Wed, 25 Jul 2018 19:19:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180710103727.209243-1-shaopeng.he@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 25 Jul 2018 18:19:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 25 Jul 2018 18:19:58 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ktraynor@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 18:19:59 -0000 On 07/10/2018 11:37 AM, Shaopeng He wrote: > Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats > mbuf fast free offloading as No-simple, which is classified as simple tx > in i40e_set_tx_function_flag. This inconsistent behavior causes tx queue > setup fail after queue was stopped. This patch fixes this bug. > > Fixes: 399421100e08 ("net/i40e: fix missing mbuf fast free offload") Is it missing Cc: stable@dpdk.org tag for 18.05 stable branch? > > Signed-off-by: Shaopeng He > --- > drivers/net/i40e/i40e_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 6032d5541..2bbb82fc3 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -2087,7 +2087,7 @@ i40e_dev_tx_queue_setup_runtime(struct rte_eth_dev *dev, > } > /* check simple tx conflict */ > if (ad->tx_simple_allowed) { > - if (txq->offloads != 0 || > + if ((txq->offloads & ~DEV_TX_OFFLOAD_MBUF_FAST_FREE) != 0 || > txq->tx_rs_thresh < RTE_PMD_I40E_TX_MAX_BURST) { > PMD_DRV_LOG(ERR, "No-simple tx is required."); > return -EINVAL; >