From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 91CEE1B1A0 for ; Thu, 4 Oct 2018 12:29:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 03:29:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,338,1534834800"; d="scan'208";a="262791439" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga005.jf.intel.com with ESMTP; 04 Oct 2018 03:29:53 -0700 To: Igor Russkikh , "dev@dpdk.org" Cc: Pavel Belous References: <43067ae0-bb4f-5f6d-22dd-7d24b7409ae1@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <9dc8e261-e322-aaae-0703-d1f774449b56@intel.com> Date: Thu, 4 Oct 2018 11:29:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 00/22] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 10:29:56 -0000 On 10/4/2018 10:42 AM, Igor Russkikh wrote: > Hi Ferruh, > > Thanks again for the review, we'll investigate and work on your comments! > >>> +CONFIG_RTE_LIBRTE_ATLANTIC_PMD=y >> Just to check, default enable in "common_base" means PMD supports all >> architectures (x86_64, i686, arm, ppc) and both Linux and FreeBSD. >> If this is not the case, please disable in common_base and enable in whatever >> supported. > > We actually don't have an ability to test and verify on PPC. > We are pretty confident on x86_64, i686 and arm. > > Thus, will it be ok to add `N` into defconfig_ppc_64-power8-linuxapp-gcc only? If FreeBSD is also supported yes, above will be OK. > >> Thanks for the update. But a reminder, each patch should be build and >> functional, there are build errors when first patch applied. I think build is >> broken until 7/22. >> >> Can you please re-work the patchset to make each patch compiles? > > Thats strange because we explicitly tested that. > CI also states its OK: > http://patchwork.dpdk.org/project/dpdk/list/?series=1598&submitter=&state=*&q=&archive=&delegate= > > Could it be some custom build environment on your side, or may be you do apply it > on different base, not master? I double checked, after fist patch applied getting following build error [1], and it seems valid because "atl_eth_dev_ops" not used at all. [1] .../drivers/net/atlantic/atl_ethdev.c:63:33: error: unused variable 'atl_eth_dev_ops' [-Werror,-Wunused-const-variable] static const struct eth_dev_ops atl_eth_dev_ops = { ^