From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90975A04DD; Sat, 21 Nov 2020 00:33:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6CF5F90; Sat, 21 Nov 2020 00:33:50 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0357FDED for ; Sat, 21 Nov 2020 00:33:47 +0100 (CET) IronPort-SDR: ytkm5xt1fXacuRAx5I7JF8b5QH4JhenJXDHfGGf+xSzyBzhY6eAfo55lIhqvNKChLmqdNHShYY sbx5Iz442/Pg== X-IronPort-AV: E=McAfee;i="6000,8403,9811"; a="189665161" X-IronPort-AV: E=Sophos;i="5.78,357,1599548400"; d="scan'208";a="189665161" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 15:33:46 -0800 IronPort-SDR: 25ZA+dAnhaDikeniBPMsnP3LepKFkY1zwBAJHt0yedHSwVl4CBmlhTgEwM38wkzeNSgNK1PLYs 24PTBG1E0W5g== X-IronPort-AV: E=Sophos;i="5.78,357,1599548400"; d="scan'208";a="331498835" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.243.199]) ([10.213.243.199]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 15:33:44 -0800 To: Stephen Hemminger Cc: "Min Hu (Connor)" , dev@dpdk.org, bruce.richardson@intel.com, thomas.monjalon@6wind.com, lihuisong@huawei.com References: <531504ce-0547-48c2-4e34-c2ed6cb12e57@intel.com> <1605873002-51934-1-git-send-email-humin29@huawei.com> <94a17751-c71a-a1c0-7cfd-d7990ff265e5@intel.com> <20201120152137.37d11e99@hermes.local> From: Ferruh Yigit Message-ID: <9dca1ddf-1842-7087-7f04-98604536340e@intel.com> Date: Fri, 20 Nov 2020 23:33:40 +0000 MIME-Version: 1.0 In-Reply-To: <20201120152137.37d11e99@hermes.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/20/2020 11:21 PM, Stephen Hemminger wrote: > On Fri, 20 Nov 2020 17:26:55 +0000 > Ferruh Yigit wrote: > >> On 11/20/2020 11:50 AM, Min Hu (Connor) wrote: >>> From: Huisong Li >>> >>> Currently, the queue stats mapping has the following problems: >>> 1) Many PMD drivers don't support queue stats mapping. But there is no >>> failure message after executing the command "set stat_qmap rx 0 2 2". >>> 2) Once queue mapping is set, unrelated and unmapped queues are also >>> displayed. >>> 3) The configuration result does not take effect or can not be queried >>> in real time. >>> 4) The mapping arrays, "tx_queue_stats_mappings_array" & >>> "rx_queue_stats_mappings_array" are global and their sizes are based on >>> fixed max port and queue size assumptions. >>> 5) These record structures, 'map_port_queue_stats_mapping_registers()' >>> and its sub functions are redundant for majority of drivers. >>> 6) The display of the queue stats and queue stats mapping is mixed >>> together. >>> >>> Since xstats is used to obtain queue statistics, we have made the following >>> simplifications and adjustments: >>> 1) If PMD requires and supports queue stats mapping, configure to driver in >>> real time by calling ethdev API after executing the command >>> "set stat_qmap rx/tx ...". If not, the command can not be accepted. >>> 2) Based on the above adjustments, these record structures, >>> 'map_port_queue_stats_mapping_registers()' and its sub functions can be >>> removed. "tx-queue-stats-mapping" & "rx-queue-stats-mapping" parameters, >>> and 'parse_queue_stats_mapping_config()' can be removed too. >>> 3) remove display of queue stats mapping in 'fwd_stats_display()' & >>> 'nic_stats_display()', and obtain queue stats by xstats. >>> Since the record structures are removed, 'nic_stats_mapping_display()' >>> can be deleted. >>> >>> Fixes: 4dccdc789bf4b ("app/testpmd: simplify handling of stats mappings error") >>> Fixes: 013af9b6b64f6 ("app/testpmd: various updates") >>> Fixes: ed30d9b691b21 ("app/testpmd: add stats per queue") >>> >>> Signed-off-by: Huisong Li >> >> Overall looks good to me. >> I did a quick test didn't see anything unexpected. 'xstats' or 'dpdk-proc-info' >> app still can be used to get queue stats and "set stat_qmap ..." is working as >> expected. >> >> But it is a little late for this release cycle, would you be OK to get this at >> the beginning of next release? > > Could we plan to deprecate queue stats mapping in future when xstats work is done? > Even queue stats moved to xstats, a few PMDs still need this configuration and API. And this patch already cleans the queue stats mapping noise from testpmd. What is the benefit/motivation to deprecate the queue stats mapping API?