* [dpdk-dev] [PATCH] ethdev: fix missing imissed counter in xstats
@ 2017-12-14 14:23 Olivier Matz
2017-12-14 17:41 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2017-12-14 14:23 UTC (permalink / raw)
To: dev, Thomas Monjalon; +Cc: stable, Thibaut Collet
imissed counter has been set as deprecated in commit 49f386542af4
("ethdev: remove driver specific stats") and removed from the
rte_eth_xstats_name_off structure.
The imissed counter has been restored few commits later but has not been
restored in the rte_eth_stats structure. Add it back.
Fixes: 4eadb8ba11b7 ("ethdev: do not deprecate imissed counter")
Cc: stable@dpdk.org
Signed-off-by: Thibaut Collet <thibaut.collet@6wind.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_ether/rte_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 318af2869..4f492e3db 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -93,6 +93,7 @@ static const struct rte_eth_xstats_name_off rte_stats_strings[] = {
{"tx_good_packets", offsetof(struct rte_eth_stats, opackets)},
{"rx_good_bytes", offsetof(struct rte_eth_stats, ibytes)},
{"tx_good_bytes", offsetof(struct rte_eth_stats, obytes)},
+ {"rx_missed_errors", offsetof(struct rte_eth_stats, imissed)},
{"rx_errors", offsetof(struct rte_eth_stats, ierrors)},
{"tx_errors", offsetof(struct rte_eth_stats, oerrors)},
{"rx_mbuf_allocation_errors", offsetof(struct rte_eth_stats,
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix missing imissed counter in xstats
2017-12-14 14:23 [dpdk-dev] [PATCH] ethdev: fix missing imissed counter in xstats Olivier Matz
@ 2017-12-14 17:41 ` Ferruh Yigit
2017-12-16 2:12 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-12-14 17:41 UTC (permalink / raw)
To: Olivier Matz, dev, Thomas Monjalon; +Cc: stable, Thibaut Collet
On 12/14/2017 6:23 AM, Olivier Matz wrote:
> imissed counter has been set as deprecated in commit 49f386542af4
> ("ethdev: remove driver specific stats") and removed from the
> rte_eth_xstats_name_off structure.
>
> The imissed counter has been restored few commits later but has not been
> restored in the rte_eth_stats structure. Add it back.
>
> Fixes: 4eadb8ba11b7 ("ethdev: do not deprecate imissed counter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thibaut Collet <thibaut.collet@6wind.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix missing imissed counter in xstats
2017-12-14 17:41 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2017-12-16 2:12 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-12-16 2:12 UTC (permalink / raw)
To: Olivier Matz, dev, Thomas Monjalon; +Cc: stable, Thibaut Collet
On 12/14/2017 9:41 AM, Ferruh Yigit wrote:
> On 12/14/2017 6:23 AM, Olivier Matz wrote:
>> imissed counter has been set as deprecated in commit 49f386542af4
>> ("ethdev: remove driver specific stats") and removed from the
>> rte_eth_xstats_name_off structure.
>>
>> The imissed counter has been restored few commits later but has not been
>> restored in the rte_eth_stats structure. Add it back.
>>
>> Fixes: 4eadb8ba11b7 ("ethdev: do not deprecate imissed counter")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Thibaut Collet <thibaut.collet@6wind.com>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-16 2:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-14 14:23 [dpdk-dev] [PATCH] ethdev: fix missing imissed counter in xstats Olivier Matz
2017-12-14 17:41 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-12-16 2:12 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).