From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/af_xdp: don't allow umem sharing for xsks with same ctx
Date: Tue, 13 Oct 2020 16:57:07 +0100 [thread overview]
Message-ID: <9ddb5852-f08a-fb91-2b77-08b2426ef08c@intel.com> (raw)
In-Reply-To: <20201013131008.4070-1-ciara.loftus@intel.com>
On 10/13/2020 2:10 PM, Ciara Loftus wrote:
> AF_XDP PMDs who wish to share a UMEM must have a unique context
> (ctx) ie. netdev,qid tuple. For instance, the following will not
> work since both PMDs' contexts are identical.
>
> --vdev net_af_xdp0,iface=ens786f1,start_queue=0,shared_umem=1
> --vdev net_af_xdp1,iface=ens786f1,start_queue=0,shared_umem=1
>
> Supporting this scenario would require locks, which would impact
> the performance of the more typical cases - xsks with different
> netdev,qid tuples.
>
> Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM")
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-10-13 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 9:17 [dpdk-dev] [PATCH] net/af_xdp: Don't allow umem sharing for xsks with same netdev, qid Ciara Loftus
2020-10-08 11:55 ` Ferruh Yigit
2020-10-13 8:52 ` Ferruh Yigit
2020-10-13 13:37 ` Loftus, Ciara
2020-10-13 13:10 ` [dpdk-dev] [PATCH v2] net/af_xdp: don't allow umem sharing for xsks with same ctx Ciara Loftus
2020-10-13 15:57 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ddb5852-f08a-fb91-2b77-08b2426ef08c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).