From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93A5BA04B7; Tue, 13 Oct 2020 17:57:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C99941DC24; Tue, 13 Oct 2020 17:57:16 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 4330A1DC1D for ; Tue, 13 Oct 2020 17:57:14 +0200 (CEST) IronPort-SDR: vMdpL7fpKTYvOOxHg/SgoMktEsVRqHBrCbx4stYTT05w4Hyp0kQV/Qi9MJl068omEEZZYVCb82 yvqMkA/NRddg== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="227574749" X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="227574749" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 08:57:11 -0700 IronPort-SDR: n8o3eED+4UeVFNwGVy98FOY5QZDQjQlp2Q4HCbRVKxbfZ6ekXIEO3Jhn7SK+vpO6KPEsuBBy6G TwWHhsyJHmPw== X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="530447079" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.214.64]) ([10.213.214.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 08:57:10 -0700 To: Ciara Loftus , dev@dpdk.org References: <20201008091729.4321-1-ciara.loftus@intel.com> <20201013131008.4070-1-ciara.loftus@intel.com> From: Ferruh Yigit Message-ID: <9ddb5852-f08a-fb91-2b77-08b2426ef08c@intel.com> Date: Tue, 13 Oct 2020 16:57:07 +0100 MIME-Version: 1.0 In-Reply-To: <20201013131008.4070-1-ciara.loftus@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/af_xdp: don't allow umem sharing for xsks with same ctx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2020 2:10 PM, Ciara Loftus wrote: > AF_XDP PMDs who wish to share a UMEM must have a unique context > (ctx) ie. netdev,qid tuple. For instance, the following will not > work since both PMDs' contexts are identical. > > --vdev net_af_xdp0,iface=ens786f1,start_queue=0,shared_umem=1 > --vdev net_af_xdp1,iface=ens786f1,start_queue=0,shared_umem=1 > > Supporting this scenario would require locks, which would impact > the performance of the more typical cases - xsks with different > netdev,qid tuples. > > Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM") > > Signed-off-by: Ciara Loftus > Applied to dpdk-next-net/main, thanks.