Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix quit to stop all ports before close

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 1/4/2019 1:47 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Dumitrescu, Cristian
>> Sent: Friday, January 4, 2019 12:29 PM
>> To: dev@dpdk.org
>> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>;
>> stable@dpdk.org
>> Subject: [PATCH v2] app/testpmd: fix quit to stop all ports before close
>>
>> This patch proposes a slightly different test-pmd quit operation: stop all devices
>> before starting to close any device. Basically, stop all moving parts before
>> beginning to remove them. The current test-pmd quit is stopping and closing
>> each device before moving to the next device.
>>
>> If all devices in the system are independent of each other, this difference is
>> usually not important. In case of Soft NIC devices, any such virtual device
>> typically depends on one or more physical devices being alive, as it accesses
>> their queues, so this difference becomes important.
>>
>> Without this straightforward fix, all the Soft NIC devices need to be manually
>> stopped before the quit command is issued, otherwise the quit command can
>> sometimes crash the test-pmd application.
>>
>> Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

Applied to dpdk-next-net/master, thanks.