From: "Kinsella, Ray" <mdr@ashroe.eu>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com,
kevin.laatz@intel.com, bruce.richardson@intel.com,
hemant.agrawal@nxp.com, Honnappa.Nagarahalli@arm.com,
Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] doc: add section describing new abi versions
Date: Wed, 12 Aug 2020 12:19:44 +0100 [thread overview]
Message-ID: <9e09b791-23fc-dd06-3143-2dfc40cacf1a@ashroe.eu> (raw)
In-Reply-To: <9342681.kHEo2Z4vZq@thomas>
v4 on the way, other notes are below.
On 12/08/2020 11:40, Thomas Monjalon wrote:
[SNIP]
>> Experimental
>> ------------
>>
>> +Major ABI versions are usually but not always declared aligned with a
>> +:ref:`LTS release <stable_lts_releases>`.
>
> Why adding this sentence here?
Will remove.
>
>
>> +
>> APIs
>> ~~~~
>>
>> diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/contributing/abi_versioning.rst
>> index b1d09c7..3d35b1a 100644
>> --- a/doc/guides/contributing/abi_versioning.rst
>> +++ b/doc/guides/contributing/abi_versioning.rst
>> @@ -673,9 +673,9 @@ symbols.
>> -BIND_DEFAULT_SYMBOL(rte_acl_create, _v20, 20);
>> +BIND_DEFAULT_SYMBOL(rte_acl_create, _v21, 21);
>
> Why updating the version here? A lot of examples are given with v20.
I didn't change this then - and + are in the documentation.
>
>
>> -Lastly, any VERSION_SYMBOL macros that point to the old version node should be
>> -removed, taking care to keep, where need old code in place to support newer
>> -versions of the symbol.
>> +Lastly, any VERSION_SYMBOL macros that point to the old version nodes should be
>> +removed, taking care to preserve any code that is shared with the new version
>> +node.
>
>
>
next prev parent reply other threads:[~2020-08-12 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 15:16 [dpdk-dev] [PATCH] " Ray Kinsella
2020-08-11 16:36 ` Ray Kinsella
2020-08-11 16:39 ` [dpdk-dev] [PATCH v3] " Ray Kinsella
2020-08-12 10:40 ` Thomas Monjalon
2020-08-12 11:19 ` Kinsella, Ray [this message]
2020-08-12 12:14 ` Thomas Monjalon
2020-08-12 11:26 ` [dpdk-dev] [PATCH v4] " Ray Kinsella
2020-08-12 13:22 ` Thomas Monjalon
2020-08-12 13:56 ` Kinsella, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e09b791-23fc-dd06-3143-2dfc40cacf1a@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=john.mcnamara@intel.com \
--cc=kevin.laatz@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).