From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
stephen@networkplumber.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] eal: fix proc type auto detection
Date: Tue, 30 Jul 2019 10:19:38 +0100 [thread overview]
Message-ID: <9e0f822f-4ee4-5ed3-30e7-b72dd57d010e@intel.com> (raw)
In-Reply-To: <3981792.lQiNHBRo4J@xps>
On 30-Jul-19 9:13 AM, Thomas Monjalon wrote:
> 24/07/2019 18:07, Anatoly Burakov:
>> Currently, primary process holds an exclusive lock on the config
>> file, thereby preventing other primaries from spinning up. However,
>> when the primary dies, the lock is no longer being held, even though
>> there might be other secondary processes still running.
>>
>> The fix is two-fold. First of all, downgrade the primary process's
>> exclusive lock to a shared lock once we have it. Second of all,
>> also take out shared locks on the config from the secondaries. We
>> are using fcntl() locks, which get dropped when the file handle is
>> closed, so also remove the closure of config file handle.
>>
>> Fixes: af75078fece3 ("first public release")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> This is not a new bug, and the fix is a bit complex,
> so it is deferred to 19.11 cycle. OK?
>
Yes, i'm OK with that.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-07-30 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 13:19 [dpdk-dev] [PATCH] " Anatoly Burakov
2019-07-23 18:38 ` Stephen Hemminger
2019-07-24 10:04 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2019-07-24 16:04 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2019-07-24 16:07 ` [dpdk-dev] [PATCH v4] " Anatoly Burakov
2019-07-30 8:13 ` Thomas Monjalon
2019-07-30 9:19 ` Burakov, Anatoly [this message]
2019-08-12 10:03 ` David Marchand
2019-08-12 10:21 ` Van Haaren, Harry
2019-08-12 13:30 ` Burakov, Anatoly
2019-08-12 13:31 ` Burakov, Anatoly
2019-10-24 16:07 ` Burakov, Anatoly
2019-10-27 19:41 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e0f822f-4ee4-5ed3-30e7-b72dd57d010e@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).