From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10075.outbound.protection.outlook.com [40.107.1.75]) by dpdk.org (Postfix) with ESMTP id E3A2F1B494 for ; Tue, 9 Oct 2018 13:12:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p5DDq76/ffg6v2F7Wwe9E24R82tOUFsVE0MLzxxjzBo=; b=qUkMQnQ/l6EOPBFV0qr/21ScC3x9iImiC1cnojbzGPfknGvMt1COsijGmkj/NRTiUhbpD9hLpHwsB2au/7XyxXlzQZedOTjAIy4Jcxb2mc1p6jrsuZ+zDy0QABEyX+dmwvs0/LbCm1kyhHth8uC7bRLOkJMj5zZeuDtiA+WTC+o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.143.30.134) by AM6PR04MB4885.eurprd04.prod.outlook.com (2603:10a6:20b:6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Tue, 9 Oct 2018 11:11:54 +0000 To: yoursunny Cc: Junxiao Shi , dev@dpdk.org References: <201810022008.w92K8B2r031185@lectura.cs.arizona.edu> From: Akhil Goyal Message-ID: <9e19271f-714f-514d-4d0f-096f553654f3@nxp.com> Date: Tue, 9 Oct 2018 16:41:40 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: BMXPR01CA0041.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::27) To AM6PR04MB4885.eurprd04.prod.outlook.com (2603:10a6:20b:6::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74110dba-b47e-4eb9-3975-08d62dd80606 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4885; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4885; 3:8qYZ/tVDYBoNEODgUqRNKK2iTFZUmxv09vZF5vlPJNwYom0Py9s6XV36kayzdjOw7NED4i+SRjpQX73v0PWLfV1r2n0DXHwmpPew1DcQPSWbwACaek8Ky22VAKmV3w7LaU+6cyRE/HrnOhWsp8Q2MRf8a/V7SkEKVNu3/MgMoQX8wwYSVWndYMsZ99i8Wp/wQynBgB2ZnUXlGZMdjrzTCSSIInWjtjuzcU2XLFoM9k9dXGL9qGGmHhMbLfqhc8LU; 25:RPhpXoDGh/IQMXr7WfHhCSTKRcSdYwSMcJHDqSxyiyvCWH+/8ygbfYcsTjyn/53wtdSWmcvOYkWveib+Kz96pERlA2HmhwqRoFkMC9rJdi+BA3ZEvdKyFvOLIKYlu2bEiR7Ce1sBeNproB0vd1XUyn1PKeZ0xJIv7KYLgkYA3CCSuZo74hROrF0iX/NKbAH1njwPp6Pym0cyIH9t0F3Q6dVWwofQmTJCNDvKEoFNbRNPA9r4EB0P7YMTE09VetJ/dbb1qPz+P4bxuAN12+H6RU1sRjzTWB1bVWflouuIup6x4z0/tOBVkKEqRqSAnr9T/Hyqye4hWStdtCDqcm5qHw==; 31:ky/uYVMvVpcHD9jN/v3E1SV32nTXlWoAJ2Dek53607mlL0MIMrAW+SDhwosr7TjrEF9apZkY2w8p7QJNZabnKlESXjTd2G701CC0rxH/oYfFv/lPJS4k8f2pUnrnhwbZNDC0DMEp3lvBnRb3iwr+t37l+yubIqZioyeYHvHu+IogsmL8L+NLe11T0OCe9oUkje3TW6+sqiegsNIxrZNnUhM2IjN+YSFKLLBPPajD5z0= X-MS-TrafficTypeDiagnostic: AM6PR04MB4885: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4885; 20:ec4/w/Lk/SfY5Y6mt3woDWtQxniEIYVSIw3Q3HrbAMUJSgi+m2GVWX6+/P7UBGAB+01XdzfLt53PADywCesENKdF3uvLCaaU37CvtyWzuiAtVxf/vAlR0TRO4i8pVTRGo2u54MP66hSZef8QSWxESW8rPx6sJeHHMSlSsG26+ygWPDZ/wld+HLYv2rUdW42V7Cwo3K7wuF7EsQ4Drt5u1O4vTDJUuRosVw4y2+FZNL1bMhqukl3AgaCOs2aie8UXPpaLmYRmTE5IlOAyVj1gBWcE3SReRdfpU+t2hA86okqUg8KCqF8GQ/F6iTiZPn6WqxTFDr5nOYcNg7h4LW5E0DDrKgWaksKVnlJhVZep2Z/Fsv3Btf+R7cMVDA1wV9h5/f58bVyXKqPf6AV7BlBLBvYbrHJVmOWDRairII+683KF8uQhX3ogN6cJdEvlyy4KFIMiUnpTIMZPAPxe5YlVmSSUwbZxtR7fK6Y/XVKDbECbeU80Nc1ZxBMaYRUXqRMp; 4:o0d6Ix3GnMhiX+nQcMuVZIdOypvYnGKB9rOlL5mvjPx6P03DhiikdsjzuMr7eSy2bYDRtqHXsnXmxztIS66HiaSJk8+dHFkkM/a+f9A8JAIMQqZ9AJniE916vlMwHhahzIGkOJfMY1IXUywZ4U2Skw0GA54HwSzGZfIwrcWqctJHdUMxzAB1MKu5hYh0B+e7FBgbudr1ilnMhioulOzJi+ACNVKFJiBef5dR4982sZK6qdfATGJMZNpeaKXxsJqpmaLmCHL7OBft3Tm33ajzE++dqdz2aRSjzrRPtXfZtYfgJCr/e2Lya0hhXe4Gm2vj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991055); SRVR:AM6PR04MB4885; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4885; X-Forefront-PRVS: 08200063E9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(136003)(346002)(39860400002)(376002)(366004)(396003)(199004)(189003)(186003)(386003)(64126003)(67846002)(77096007)(55236004)(76176011)(52116002)(26005)(52146003)(23676004)(2486003)(31696002)(39060400002)(86362001)(575784001)(53546011)(16526019)(6486002)(4326008)(2616005)(476003)(229853002)(44832011)(305945005)(11346002)(7736002)(486006)(956004)(446003)(5009440100003)(58126008)(8936002)(47776003)(65806001)(68736007)(65826007)(106356001)(16576012)(1411001)(81166006)(50466002)(6666003)(105586002)(36756003)(2906002)(53936002)(97736004)(65956001)(81156014)(66066001)(316002)(8676002)(6916009)(5660300001)(31686004)(478600001)(3260700006)(3846002)(6246003)(6116002)(230700001)(25786009)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4885; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTZQUjA0TUI0ODg1OzIzOmQxUkFpbDlWWHFrYmFCUk5BNzJ3bUpnWFR6?= =?utf-8?B?blNpVTFGRHNyTnpkNWlxMkhSUFlOTW9BSVJxWUxRZVhhRVQwcTZpY1Fzb2NW?= =?utf-8?B?UWdPNlJBU2d6WDk2M0s2dGZvRmh1NGJIZ0pJak5jY1FCREFZaCtXcGN1eXNY?= =?utf-8?B?ZVlRWGJqN3E3cisvSDFnVW5zcGRKRVdKakE0bFpOd2Vmdy96RUVSWUhRM3Nj?= =?utf-8?B?YUhhWUpqSVBaQmJXR25rUUN0RXRhdFYyYnlYeXJpdDZNdTZtN1NjYjBhU29u?= =?utf-8?B?b3VTRE5uRXdLODZielZVdi9mSFZLTUZCNElwYTBjQmRId3UxZEEwRG45Nkxs?= =?utf-8?B?eG5tOWdzTndSOTliOEpaalBlVUZVLzlOVnBNMzdTVzUxVGd5dytQa3RnZGMv?= =?utf-8?B?Mkp0dXBkTDZ1SWFDbUtzSjY5OGtzczBuYkhpNzA3UnFKQ2dwYjZpZmVBYzJV?= =?utf-8?B?UzJJazhnN2wvMm1zOEUxMU4xZnBxZC9kVm8xMVJ4d2JUYXZRMFRibS9xTTgx?= =?utf-8?B?bk53TURIbzJkcWhkM1JBK0x6dzdQTXJrcmtSb1lMd2lSKzA3VGNwMTZQd05j?= =?utf-8?B?WWdORlpxdnp3VjJaWDlld3RCMVVHY2RZWmxmNTNZb0FaNy9odm1SRFQrd0N5?= =?utf-8?B?WU1acUM0blY0NkpwbytqVUdyWXdvcFB4M0ZrcG5ZSzNBN1BtYXViWTJicUww?= =?utf-8?B?R0w0OWg0dVV0c0M3VGhVRzdsMm1BR1R4YzhpeHBqaHk5dGVRays5bGM0SFNP?= =?utf-8?B?RW14bG9LeUZLL1ZaRkNUSElvMThTVmc5RGJaNHhuOTc3MkYrSHZxbmpwTTFj?= =?utf-8?B?NmpHRUp6aXp4SVk3UE40bFpyZHYwK3I0WnRkajBpdm1zcW5oK2luWUtmZ3VQ?= =?utf-8?B?eStxcnZ2ZmNzLzZ6aVNNOUViYURnczUySFljVjV1cFROMmFpY1pRNXo2ajRz?= =?utf-8?B?TW5mM08rQjh0TDF4T3F4cnhNQitUeUVSRjVUMk5JUlRiR1hoSmVsaG90b2c3?= =?utf-8?B?R2o3MFd0ZVdieDJuUzBGNFBZY1VtOFJWRTk0cXdIR0pweXFxbTBTdExUUFlV?= =?utf-8?B?RVF6M1o5aEI5ZmgrTTA4L25zRWFRUWVJNkJ4Z3g3UlFnRUZPSk1zb1AwcVhq?= =?utf-8?B?dXRoMFYraTNIdEZrV0ZYK21WNEgwY3gxK1ZUSG5FcTQ2aXdWS0JJNVh4MkRt?= =?utf-8?B?MFpFelVHaUZWaTJYemtQNEdjTnVEUWpuRUhQQkwyL21hTkFLejFZWmpmRE4y?= =?utf-8?B?cmVQZENHTEloNmJwMmNNWlVURnZ2NHRwRUZyNlliWVNHdGZXVzAvcEZ5RXpR?= =?utf-8?B?VDd4OU8rUnhzcWEwZ2w4WHYzQU1YQnpqV1J3aklPQnRqeUdGNTRaT3RxZXov?= =?utf-8?B?Y2h3Y1gxb3NPTmxYbE00Q2NtcVJDbzlBOFN1SWxibklMbi8wclNrWm9XYTE1?= =?utf-8?B?bjdncUlrZ0xETlFCMVVndlQ3Q2pBbFpGMDRDUnBQeXE3TnNtNDE3U2hoMjBK?= =?utf-8?B?Z0ZOUDdJN05ydGdEd2gwWWFLeVZyTG0wYlg0NjVub2ZBS1B5a0JTN1VNQTZY?= =?utf-8?B?UlRZMW1xdkR1TThtOTlDUlZoaFBKWFVLc2RhOUgwQUNwVHM1Y1l3VjdxTUo3?= =?utf-8?B?bm1ucXVUNmlRcjM0NW9xcm5HZGJXMmxENVZQSHJrNmg5U2NHWkhvV3NGdWIv?= =?utf-8?B?blkwNEhKVmxsYzk2U0VoejZGZGN2cWh2N2pwMFZ0TUdZT0U5SXpIU2k4N0Vq?= =?utf-8?B?cUJHOEhXQ2oyL3FxNzBpS2VnZUVtRzVvUEs1QmVDVy92Z2NXVTZ3Vkg2b2RQ?= =?utf-8?B?MVZCUEp1d1RGa1V5QW1CSkVtZFBXRE5BMmdQNWE5RzBselArK3N1T3Y4TFZ1?= =?utf-8?B?MkxHMmk1VTlVdWhvaDV2Z2xyRVNncXNJZlFLdFhCOGJFYnVjV3BpUEdPeWxQ?= =?utf-8?B?amJxSVZBa1ZzTnRvRVlGL1FMamNIMHROTnlrTUsxMm5wd3ZXeGEyUU5WMlNZ?= =?utf-8?B?M0IvOUdDem9FU3c3cy85dkRwRVErZ3BjR1ZvUjdsc2pTQ0I2dmdyYWVkNXo5?= =?utf-8?B?azZTRVhCRGZubWEwUlBBOTBLQjVkaUZzd2s1Z1J6VEpOZEtzOTNVeFJIY3VD?= =?utf-8?B?TmdyZnY5ZXc3L1pMNnh0U2poZW1DMGxBR2lsa2NXNGsrbTcxUkdTZDBhR0hC?= =?utf-8?B?NUVDT29iYTFjeDEvMzdmczlUc0FBPT0=?= X-Microsoft-Antispam-Message-Info: C6Yr+qz/iPrhRo8qSxE3Huf9IVHCB09eUK7cqxiKevoQGeWqpyIvHkHnLNY0sBNg2PShMjeZuoPiRqy2Jm83ZQ7L0hEWOl+tzteSs68J4soqWMaXgfuVMf9XxEAXZtkiIzBs/I98yt5+Xs3Y5N1UJl4rz5SGb/k6CgsRBNQfyyCwZRTlmxH7HwUD+n6pWMvJpivNuTyUhZfBJsY8baWiQ9I5xwiU26LtS/lBFsT4ECMEfrZqOFB8vSEkOCvNyuO9AlVotEt6fla+fg5BJpLCk2wIVKUFwx5X6xBTFWrglsnRBBTO9MUDCYEZUvRdFMquitNLUFSdBVUMtRSZnGpjWRUiGkZkR3jgZtbIuDsiatA= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4885; 6:lGOPGpl/ncRvqFsw8NkTTwIiZSE1GBhhL+hQsfXxPIX7cUXs53KoS4TDWOlUD4rXgVSVWmBgOwT5tmM0Aq/0T8yc5NK42CwBjUrF41e1RY9hmbB7YIwZsk9ocoGhde2h29I5i3AexmtNqGBXp680ri7My+NnLhxok2lg0W4a5wJTb5uYVenND1Y4GTMSbm+cDMh8wCcJurQisT2Os6TihgirAU4TD4Fmycl70dvsBiZXNBKWyDMEhMOVl/bohBttKClFj0A0IoZQMb9OeYGMqssWfJHIBumSFGlKV96Ng3hrS+W5apq1UCyMIHoQfqiWza9BMTQMDpht7IBoZToIdiB/1jmu+OGXiIuMv7Muqs7ZFXH4uWifQYmW5bmfdL2dvRZJ20LU3duzs7JFbdN/LW1R25w94ccADLXDqKJQkeF3UtJ7R2xLTO+N0UvC9ew/DeSe8fwnNnMTcYxyANcGVA==; 5:b35aUYzojgL/JoMwa6eVHZ54ViDOIddXJUup7J4qXloICY9tSpGuLNsZ4a86AlRl+4fVj7gvb2c0Dg9cXTdZVupjUKnwo1wLIeuMr3tJ3EyBcQpObHIeSHk9LliD5GjfOzucYboOfBz7pcYctO6M2L72heNo3V7uRSdG8w+Cgmo=; 7:zucTF83JknbtfRXvojKPrHJ5GMDxm6VI0mZXyiPJ7FhJEVZdSdCxXcr2GafsGKrQbsCxFRmsZL84JJhu3vMaETxjAlVXb3T1z2njGMve8ZCQrt3tqTvXPWpnM+p0T2PQ0aj+nqewRwFTcvfBm2RUoCpmi7wP4912hNnTmLG8UGvEhlv6jzsYRdBOr/lrR90XUdtEoag2PGHdCzy1tBthC6GU+SMaIvr1kEYADhdwC0wx4L2kWKzrC3fwYrZ4HbCN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2018 11:11:54.8479 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74110dba-b47e-4eb9-3975-08d62dd80606 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4885 Subject: Re: [dpdk-dev] [PATCH] crypto: recognize OP_TYPE_UNDEFINED in rte_crypto_op_pool_create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 11:12:01 -0000 On 10/9/2018 4:28 PM, yoursunny wrote: > Hi Akhil > > The documentation of rte_crypto_op_pool_create indicates that _UNDEFINED > creates a pool that supports both symmetric and assymetric crypto. This > change makes the code consistent with documentation. > > Yours, Junxiao Please add this information in the patch description and this should be marked as a fix. Please also add Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented") and cc stable@dpdk.org > On Tue, Oct 9, 2018 at 06:51 Akhil Goyal wrote: > >> Hi Junxiao, >> >> On 10/3/2018 12:35 AM, Junxiao Shi wrote: >>> Signed-off-by: Junxiao Shi >>> --- >>> lib/librte_cryptodev/rte_cryptodev.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/lib/librte_cryptodev/rte_cryptodev.c >> b/lib/librte_cryptodev/rte_cryptodev.c >>> index 63ae23f..3d6f474 100644 >>> --- a/lib/librte_cryptodev/rte_cryptodev.c >>> +++ b/lib/librte_cryptodev/rte_cryptodev.c >>> @@ -1477,6 +1477,8 @@ rte_crypto_op_pool_create(const char *name, enum >> rte_crypto_op_type type, >>> elt_size += sizeof(struct rte_crypto_sym_op); >>> } else if (type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) { >>> elt_size += sizeof(struct rte_crypto_asym_op); >>> + } else if (type == RTE_CRYPTO_OP_TYPE_UNDEFINED) { >>> + elt_size += RTE_MAX(sizeof(struct rte_crypto_sym_op), >> sizeof(struct rte_crypto_asym_op)); >>> } else { >>> CDEV_LOG_ERR("Invalid op_type\n"); >>> return NULL; >> Could you please explain the need for this change. If there is some type >> which is missing, we can add that. >> defining the size of undefined op type does not make sense. >> >> -Akhil >>