DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: ferruh.yigit@intel.com, keesang.song@amd.com,
	anatoly.burakov@intel.com, david.marchand@redhat.com,
	bruce.richardson@intel.com,
	David Christensen <drc@linux.vnet.ibm.com>,
	dmitry.kozliuk@gmail.com, ruifeng.wang@arm.com
Subject: Re: [dpdk-dev] NUMA node/socket
Date: Sun, 4 Jul 2021 11:27:11 +0300	[thread overview]
Message-ID: <9e359fe9-f993-ef6c-1b51-1e08fec5ff9b@oktetlabs.ru> (raw)
In-Reply-To: <12700395.j6fn4b5UDm@thomas>

On 7/4/21 4:53 AM, Thomas Monjalon wrote:
> 04/07/2021 03:38, Thomas Monjalon:
>> There are some mix between NUMA node and socket IDs in DPDK.
>> Examples:
>> 	* rte_eth_dev_socket_id() returns the NUMA node.
>> 	* rte_malloc use sockets to allocate the memory
>>
>> Is it critical?
> 
> There is a function, implemented for Windows only,
> which distinguishes clearly node and socket
> but it assumes there is only 1 node per socket:
> 
> unsigned int
> eal_socket_numa_node(unsigned int socket_id)
> {
>     return cpu_map.sockets[socket_id].node_id;
> }
> 
> Reminder: AMD can be configured to have multiple nodes per socket.

Taking the reminder into account the topic definitely
requires improvements.

I apologize for my ignorance, but
Is socket ID really interesting to anybody in DPDK?
If no, we should just clarify terminology and switch
to NUMA node everywhere.

  reply	other threads:[~2021-07-04  8:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-04  1:38 Thomas Monjalon
2021-07-04  1:53 ` Thomas Monjalon
2021-07-04  8:27   ` Andrew Rybchenko [this message]
2021-07-04  9:28     ` Thomas Monjalon
2021-07-04 16:18       ` Stephen Hemminger
2021-07-04 16:27       ` Dmitry Kozlyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e359fe9-f993-ef6c-1b51-1e08fec5ff9b@oktetlabs.ru \
    --to=andrew.rybchenko@oktetlabs.ru \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=drc@linux.vnet.ibm.com \
    --cc=ferruh.yigit@intel.com \
    --cc=keesang.song@amd.com \
    --cc=ruifeng.wang@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).