From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA92743A0F; Tue, 30 Jan 2024 18:19:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C983641140; Tue, 30 Jan 2024 18:19:17 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2072.outbound.protection.outlook.com [40.107.244.72]) by mails.dpdk.org (Postfix) with ESMTP id E41014113D for ; Tue, 30 Jan 2024 18:19:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m095tZEAylZp3PJkv3jSgLanJDewzGLnLhHv7YhW3bpbYk35Bl/GXDKm9IwvT/EBSGwIktcpuWvX7O5ugoIIrvFBS8nkUd4edN9fnemhjHp93rDTyMXHzS1HJ1CHkfjuT8x7jCEVwmLEGwvXazYGZ4md0yNwe5P7n5gQpaamYj18VFTlPr9/PLHFC2kFBc59cga3shh68VgEyrzJajXZLB5KG98pEN9CYlhu6HcyBqHXNzZqWaaNPpLrrh6URqWa29UXRc7lSAeS88EWh9GlnzL13m3jyLMskd+P0z4xUH1SJHb95akNao3OAfIHIW2Ct5pFuesA82D3RK+o+kNANg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c/jZIMJYIDTgYga3BKG0Ku476l25To2ndRuRZhk4F5k=; b=MFD56pbgWA1jHXu4uYS3GuhRQbfAlUrWIPU8Rmyb/Q5dmKg6vZzcwtlASvyw8nZiFnWNVEstB8NCxqOpyONqrmTdGsmWfF2lEJfHYT5CSd0bI1NyHtFEoqHlYKTLGWMZ5f1nhu5VuVzT05GG/YD8xmqZ31HGdzNK1/BMzqxlV6Usb+V7ZM+uyzgKnfK6pXbD/+0OR5Hgmggl2FTbtqmM0O1NzbLGxYYtpr3wQKv4KagqlvABxOppcl3OzWSR4JMvB65jWJKEDuN5+O4EvxNOK2P0dPQV/zjAYJe1r5xzCQXWsA2UHLs6b4UH0+PoiNmNLHvo3s/FDnvliTcxVYdJhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c/jZIMJYIDTgYga3BKG0Ku476l25To2ndRuRZhk4F5k=; b=qC4ONK19z1pXcGhhrE8ZCYrj4+1OFnJgqmdnmADKcGN2dp70RmKfQBz9cSV4ZHA18OmzXbNmJA/pcCIv/F/hsamIDQlDvQ8mtWYGDdyy7QPPWMVXRVmzs6ptGU5IIjufI9ocQpmiOFTu1OCPUzDXHETYb3NREGiZPi+Tu726NMg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV3PR12MB9267.namprd12.prod.outlook.com (2603:10b6:408:211::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Tue, 30 Jan 2024 17:19:13 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7228.029; Tue, 30 Jan 2024 17:19:13 +0000 Message-ID: <9e38221e-285c-4cf6-a170-c3ee2f8b1786@amd.com> Date: Tue, 30 Jan 2024 17:19:07 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] ethdev: rename action modify field data structure Content-Language: en-US To: Suanming Mou , orika@nvidia.com, Aman Singh , Yuying Zhang , Dariusz Sosnowski , Viacheslav Ovsiienko , Matan Azrad , Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org References: <20231219013337.531548-1-suanmingm@nvidia.com> <20240115091318.1053433-1-suanmingm@nvidia.com> <20240115091318.1053433-2-suanmingm@nvidia.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240115091318.1053433-2-suanmingm@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR5P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f1::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV3PR12MB9267:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d10b730-e8cc-438d-8213-08dc21b79445 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lt6GLjn/28GImPKTlEIGT6xdWMgImFgszKxQiy2y1sQ/Og2JQJ1G5H/JUwqC7UiwGKM3LLaeHwIYsOnGzptRX8pWGtB1cwthY3NsMSQDyTN4iHObEFwV2AJSIOEVAEBQ+h+TNRk+IK+fVo5Kd6km3oqfcj26XRJ+OGaaOSSzva93rQbFvMJlidqLQ/6HII8s4RRiWVa/NCottD1QYRtJ+zGsaQwPuNiWdKZJXcuCkKgC2QiZa3E/i4OfQvhLi7/qKQi0uUFq4507R9PDyF+z48+NTOTcP6wond0c+g5ueKDuReL+6gO/NxJrXbrrJfb5MyM6FMs0cs8HgBRsoawdkvxBcD0t3+5JBe/cvXjZjlHuu1bRiFosQntGOhx8oDrhUeTU7+0OtyGi40LZPZv35P+8OOGM3XL3f1XNHXpisIFAwyljzLywY9CeaS3feEjeKfQVTytKetJ0pVSAyhPamrca5ihd2xEm31V6ltR1UN+QKPj7QJ2TBKa25hJEVpibRSU3dFwX475jLAsPEWWJDlU1l5/VH/t2IZRukRdw7g0l/+utWitsb1UfsZ83cE2NioL8YppIguvBlmOxZ6iU4vmL1uuUms3iHS3vuyumI/CUhADmaiBcEQg7I8gBImbGpGWUSIESN1nk6vSYoXZ4wNCrCghfHBOKvqfTB5UhaPxBuTFPnHfomdzx1kbt4vMN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(136003)(396003)(39860400002)(230173577357003)(230922051799003)(230273577357003)(451199024)(1800799012)(64100799003)(186009)(316002)(66476007)(8936002)(4326008)(66946007)(66556008)(7416002)(8676002)(110136005)(83380400001)(31686004)(478600001)(86362001)(6666004)(31696002)(5660300002)(38100700002)(44832011)(2906002)(6486002)(2616005)(6512007)(53546011)(6506007)(36756003)(26005)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3l6VmdGdjJoOVpHT0NGQmdFS3VHS2xYYk9MdkJZckVaM2l5ZjU1Mkl6L2tN?= =?utf-8?B?dWE2SmYvQVpaUnlwckxvcjFBUE1uMlZtclIzVDk5R0piTnZsQ0FiTThsSmZS?= =?utf-8?B?YzJHVjNodTdsTDhJZ0gvbnNxdWwxbFl5UzFMMjIrMkJPMmc5aDRHQlhXekps?= =?utf-8?B?dFpEdXVvcXFDOEovOENwSGs4Zy9qVTNSSC9iV0YvZ2JQSDlHUjNSTlZLV3VP?= =?utf-8?B?cXVJWXE2Kzhydkx6eldTNWlPdjRpcC9pclc5bHd2eGV0dHlWNHIxVXhHMmxK?= =?utf-8?B?cTY2TEUyVm04VGVDcThoSy96MkRZNldha0h6amdIZG4yOWkwNU9nVDhmRlA3?= =?utf-8?B?V2Q3aHRMMGJaN3JpS1ZxZXBibHFXa2t2ajdOb2JVRlJwdFpyNW8vZGE2K0dn?= =?utf-8?B?L2RxVlF2T0tWeGVCNFJPdTFGRzBERmFoTkFRREViM3Bia1RaRXNIaU02VGhD?= =?utf-8?B?Zlh5V1J4VXN6WW1Pbnk4Z1Y4NWZYc0lGbXZYWnAybE8zem83amRKYVFrMHA3?= =?utf-8?B?K0ppNFY1Zk5ETlB0M2ltb2xCOEcyUk1IVXBvOWRhcUhsYTJwUlFPMkY2RmJ4?= =?utf-8?B?M1VvK3BPRTJDZXcvSzUyT2V5R2lCS3crQzM0MlpVWWR4M3F2bGtKNThMU1RG?= =?utf-8?B?eHhkL2JueG9mbkVzcDkrU2FDajFLK2hta0hsWE1aTVN3b1BqSjVsa1pPWUdo?= =?utf-8?B?djlnVTRGaVE2aS9lVDhpT2IvbVU2Z242NzdCUUZ1R3phTVR6RnhRN2FlaWhW?= =?utf-8?B?VEVrRVNnc1FKL1lkbnBiNEI1eVpIWC84ejRTNjUrSDg0d0lPdHB6bVAxYnlT?= =?utf-8?B?cVpVZjR1L1RUUU1XbTZmb252YkxrcVVoTDZRV1hnL0F2VnBheUJ4ZDhXTUQ4?= =?utf-8?B?Njc1aW5DbWRlVlZRbkFEdkdPMTdNbndRWkdzalRvSmpObHFFNEVhQ0ZwMk5W?= =?utf-8?B?TERwK2djeG1IQ0xPZ205QVVsUWE3Q1JqclFsSUEzMW1seFJ3d2ltSzlJbXI0?= =?utf-8?B?MklFNUtvMUpYK2ltc2hlZTZOdFlzOWt5dEQvNDFWc3k1YkRDUkFFaGVMb0do?= =?utf-8?B?a0Y5WEZJWFhIaU5XK1ROL1dvd3RCa0VZNDh1bWoyazhrODNldUZSZXRrL0E0?= =?utf-8?B?Y1FLQkxNSXQ2VCtvdndGWENiYzU5OE1TbFN3TTlURVppMzUzVkVHK3NCWGxP?= =?utf-8?B?S1ZRYWZ4Qkk4SWpUVHBMWkhEY0xybThMcjUzUHZJL2RBeVpaM3czUWxTNGFa?= =?utf-8?B?N0pDd2J5UjAzSkdocU9CWlg2bjk5anV5eTVPcVpTYjJ1Uks2ZFE1bi9BOGEr?= =?utf-8?B?MGVGUnNFTVJvcDU3SHRDckN0dGlBUnl2Q3BUd2QzNU5wOE1pS0NsUGh3SzZR?= =?utf-8?B?ZkFMeXJBR1B4LzB2VWE3YWg1N3QwbUlPakIraytBUXlORXlPZmtQU016U0sv?= =?utf-8?B?M3dFckN1UFRDU2tsbk9sRFZvU0dBVmlpenFMZ3BuU1hORTJjcS9ZZGFUeWt6?= =?utf-8?B?Uk5kVXJKNDZ5SU9BU3RwaDNIZkJFQk50VDRmVzQrWDEwN3RUTE9iMmJJRVpt?= =?utf-8?B?VnNqT2VZcUUzbHprQWluMkFkdmQycWZZZnNhQ3RLbHFYM3FNakJrS011a2x5?= =?utf-8?B?RzA5Q1prUWVKSFhWMmh2V3FCQVRDaEhQdHBNZWZTWFNaS1JsNmdjbFp0MjFE?= =?utf-8?B?N3pWMEpBUjVnYmFZdnowN2JEZzRlUW1kUWNFK3lFc1JkQTVvQ3NwUnA5eG1O?= =?utf-8?B?MWluS256anZnS2lSRFJ3a2ZmMDZSdW1CRHFSRjczSHd1b0NJNUhZem02SGFu?= =?utf-8?B?SUVOakpDQzJpSDQyMDBuN3E2cXI4ZCsxYjUwL1B5RlFab3BuNmVIUE1EdzRV?= =?utf-8?B?SEJreUtmZytQUk1BOC9TbzREM2VFdGxCMENqMTdoSFE2dENaU0o4T2JuYUtk?= =?utf-8?B?Znl3WVNQekxZdXRJQzJVdkJWUzFRSndVcWVvU3NTWmQ1SkZTcHRJQWdHNjU1?= =?utf-8?B?WjBEZ0FmbE9ZWUFOUlFFUVN2YndnZEU5Rmd6a093SzVPbDFXZzJGRitEUS9S?= =?utf-8?B?dDhxa1Z3dUkrcFVGUHdUOU5CMFczb1dKTTMzSDhFR1dPSDNDRHRqbGZwT2Qv?= =?utf-8?Q?PyTQ=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d10b730-e8cc-438d-8213-08dc21b79445 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 17:19:13.3131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZJ8bS+0AbkUKS65gOcrcAeJE4SNvFodP+bwEmDCXqneixGmjNtfcvk5zN2qWqq+2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9267 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/15/2024 9:13 AM, Suanming Mou wrote: > Current rte_flow_action_modify_data struct describes the pkt > field perfectly and is used only in action. > > It is planned to be used for item as well. This commit renames > it to "rte_flow_field_data" making it compatible to be used by item. > ack to rename struct to use in pattern. > Signed-off-by: Suanming Mou > Acked-by: Ori Kam > Acked-by: Andrew Rybchenko > --- > app/test-pmd/cmdline_flow.c | 2 +- > doc/guides/prog_guide/rte_flow.rst | 2 +- > doc/guides/rel_notes/release_24_03.rst | 1 + > drivers/net/mlx5/mlx5_flow.c | 4 ++-- > drivers/net/mlx5/mlx5_flow.h | 6 +++--- > drivers/net/mlx5/mlx5_flow_dv.c | 10 +++++----- > lib/ethdev/rte_flow.h | 8 ++++---- > 7 files changed, 17 insertions(+), 16 deletions(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index ce71818705..3725e955c7 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -740,7 +740,7 @@ enum index { > #define ITEM_RAW_SIZE \ > (sizeof(struct rte_flow_item_raw) + ITEM_RAW_PATTERN_SIZE) > > -/** Maximum size for external pattern in struct rte_flow_action_modify_data. */ > +/** Maximum size for external pattern in struct rte_flow_field_data. */ > #define ACTION_MODIFY_PATTERN_SIZE 32 > What do you think to update 'ACTION_MODIFY_PATTERN_SIZE' here too, instead of next patch? <...> > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index affdc8121b..40f6dcaacd 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3910,9 +3910,9 @@ enum rte_flow_field_id { > * @warning > * @b EXPERIMENTAL: this structure may change without prior notice > * > - * Field description for MODIFY_FIELD action. > + * Field description for packet field. > New note is not very helpful, how can we make it more useful? Does it make sense to keep 'MODIFY_FIELD' and add 'COMPARE ITEM' in next patch, to clarify the intended usage for the struct, otherwise it is too generic.