From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id EA9E6A057C;
Fri, 27 Mar 2020 12:44:27 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id B8BB31C117;
Fri, 27 Mar 2020 12:44:27 +0100 (CET)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
[209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 6EC401C117
for <dev@dpdk.org>; Fri, 27 Mar 2020 12:44:26 +0100 (CET)
Received: by mail-wm1-f66.google.com with SMTP id b12so11088141wmj.3
for <dev@dpdk.org>; Fri, 27 Mar 2020 04:44:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=accelercomm-com.20150623.gappssmtp.com; s=20150623;
h=subject:to:references:from:message-id:date:user-agent:mime-version
:in-reply-to:content-transfer-encoding:content-language;
bh=7f3MYO4zoycLgn4kLAi/W681WbjUuSFflScvGfWSevE=;
b=2FV+oMTV4oARMdCMPz9lkogIeVSFc8KRuw5h/VJpqU02NyNEBuohOlcX6D6QTTbMOj
CpW/QwO4zkPmtikCFHNWzwrrwOKTbEbU9wzVaKHHCd41qe61N4HTbp+x4vG6oEXP3qW2
6lG/escQFCuPYiH+VT119wAxNtWDugmaUz39zs1pZJ5ezvHiZZ8nPA84IELT/iRns4c4
Xszf2WfP18gXSLGBxVrHmlMTQIIYzDCYDoFpg3RLcvxPIT8DMtSEisb29BqpOiiAHDnR
DS9RzQ8KOkLhDt+qiKfTtwB8Z8wCQ7UQdGiBxlQ48PST+s1oO0WJluGOuq8Lpr2jM3Et
Mc3g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:subject:to:references:from:message-id:date
:user-agent:mime-version:in-reply-to:content-transfer-encoding
:content-language;
bh=7f3MYO4zoycLgn4kLAi/W681WbjUuSFflScvGfWSevE=;
b=tsBJLFyLuFAZPU0KWuLktgyHdQ4YKZ4NuA2n82OY4uOTmOZgkyf6tNPL67uzHeqD+D
+p0FQ1TVl7khOuAy3hz/nf5sMn562q2AsLNQDrNhRwELM7rurbCw5BEfBquTnPwh5ePV
2FuhOdnAQ7JBqRluWRV4AQQXns2Q6rFWTaY+qGOumoX607jIErYbiJ7exXOTc6nPkr0a
ibMpQ9gDDANuDl4tVQ1dePXErr1WLXhd1r7QGYC32XEE73hsPRFtYV3vmDVxFOjn9sdM
ccUFaesOBd047xDxgSVrq57kmypYwbbEfh0OvseoeHvP5uaabfLG8cJbzOaqG9Lj22qJ
JRdQ==
X-Gm-Message-State: ANhLgQ2vzsKcNO9vYI0MRt5tyjJpgYQYpYEYGywNk8Y5ITKeWotN0MZl
xkhU/Sh01dWzlH2XGJVNgvKX3A==
X-Google-Smtp-Source: ADFU+vv6hYtx8vPlY/xbzEcEmip2hu99Xx3Ya+0bWMeiF30DIclVT9KneUhpcCYX462RxncetemQpA==
X-Received: by 2002:a1c:2603:: with SMTP id m3mr5271069wmm.105.1585309466131;
Fri, 27 Mar 2020 04:44:26 -0700 (PDT)
Received: from ?IPv6:2a00:23c4:cf2d:a200:6023:b810:2491:c6a9?
([2a00:23c4:cf2d:a200:6023:b810:2491:c6a9])
by smtp.gmail.com with ESMTPSA id s131sm7706743wmf.35.2020.03.27.04.44.25
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Fri, 27 Mar 2020 04:44:25 -0700 (PDT)
To: dev@dpdk.org
References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com>
<1585193268-74468-1-git-send-email-nicolas.chautru@intel.com>
<1585193268-74468-2-git-send-email-nicolas.chautru@intel.com>
From: Dave Burley <dave.burley@accelercomm.com>
Message-ID: <9e3cbbe3-e606-8dfc-ec29-893edc1a778b@accelercomm.com>
Date: Fri, 27 Mar 2020 11:44:25 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <1585193268-74468-2-git-send-email-nicolas.chautru@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v5 01/10] bbdev: add capability flag for
filler bits inclusion in HARQ
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Acked-by: Dave Burley <dave.burley@accelercomm.com>
On 26/03/2020 03:27, Nicolas Chautru wrote:
> From: Nic Chautru <nicolas.chautru@intel.com>
>
> Adding capability flag for device variants when HARQ buffer
> may or may not include the filler bits.
> Minor cosmetic changes in same file.
>
> Signed-off-by: Nic Chautru <nicolas.chautru@intel.com>
> ---
> lib/librte_bbdev/rte_bbdev.h | 2 ++
> lib/librte_bbdev/rte_bbdev_op.h | 12 ++++++++++--
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h
> index 591fb79..b2da190 100644
> --- a/lib/librte_bbdev/rte_bbdev.h
> +++ b/lib/librte_bbdev/rte_bbdev.h
> @@ -607,6 +607,7 @@ struct __rte_cache_aligned rte_bbdev {
> * @param ops
> * Pointer array where operations will be dequeued to. Must have at least
> * @p num_ops entries
> + * ie. A pointer to a table of void * pointers (ops) that will be filled.
> * @param num_ops
> * The maximum number of operations to dequeue.
> *
> @@ -638,6 +639,7 @@ struct __rte_cache_aligned rte_bbdev {
> * @param ops
> * Pointer array where operations will be dequeued to. Must have at least
> * @p num_ops entries
> + * ie. A pointer to a table of void * pointers (ops) that will be filled.
> * @param num_ops
> * The maximum number of operations to dequeue.
> *
> diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h
> index 1e119a7..c8a354e 100644
> --- a/lib/librte_bbdev/rte_bbdev_op.h
> +++ b/lib/librte_bbdev/rte_bbdev_op.h
> @@ -31,8 +31,11 @@
> #define RTE_BBDEV_TURBO_MAX_TB_SIZE (391656)
> /* Maximum size of Code Block (36.212, Table 5.1.3-3) */
> #define RTE_BBDEV_TURBO_MAX_CB_SIZE (6144)
> -/* Maximum size of Code Block */
> +/* Maximum size of Code Block */
> #define RTE_BBDEV_LDPC_MAX_CB_SIZE (8448)
> +/* Minimum size of Code Block */
> +#define RTE_BBDEV_LDPC_MIN_CB_SIZE (40)
> +
> /* Minimum size of Code Block (36.212, Table 5.1.3-3) */
> #define RTE_BBDEV_TURBO_MIN_CB_SIZE (40)
> /* Maximum size of circular buffer */
> @@ -177,7 +180,12 @@ enum rte_bbdev_op_ldpcdec_flag_bitmasks {
> /** Set if a device supports loop-back access to
> * HARQ internal memory. Intended for troubleshooting.
> */
> - RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK = (1ULL << 17)
> + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK = (1ULL << 17),
> + /** Set if a device includes LLR filler bits in the circular buffer
> + * for HARQ memory. If not set, it is assumed the filler bits are not
> + * in HARQ memory and handled directly by the LDPC decoder.
> + */
> + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS = (1ULL << 18)
> };
>
> /** Flags for LDPC encoder operation and capability structure */