Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto

[Akhil Goyal <akhil.goyal@nxp.com>]

Hi Shally,
On 6/18/2018 11:10 AM, Verma, Shally wrote:
> Hi Pablo
>
>> -----Original Message-----
>> From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
>> Sent: 18 June 2018 01:01
>> To: Verma, Shally <Shally.Verma@cavium.com>
>> Cc: Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad
>> <NarayanaPrasad.Athreya@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>
>> Subject: RE: [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
>>
>> External Email
>>
> //snip
>
>>>>>  ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
>>>>>  ifeq ($(CONFIG_RTE_LIBRTE_COMPRESSDEV),y)
>>>>>  LDLIBS += -lz
>>>>
>>> [Shally] You mean add another config option for Asymmetric test?
>>
>> At least check for CRYPTODEV, but since this is enabled by default,
>> I think we need an RTE_CRYPTODEV_ASYM_TEST flag.
>
> [Shally] OK. Will look into this.
>
>>
>>>
>>>> ..
>
> //snip
>
>>>>> +#pragma GCC diagnostic pop
>>>>> +
>>>>> +static int
>>>>> +test_rsa(struct rsa_test_data *t)
>>>>
>>>> ...
>>>>
>>>>> +     rsa->n =
>>>>> +             BN_bin2bn(
>>>>> +                     (const unsigned char *)rsa_xform.rsa.n.data,
>>>>> +                     rsa_xform.rsa.n.length,
>>>>> +                     rsa->n);
>>>>
>>>> I am getting a compilation error:
>>>>
>>>> /test/test/test_cryptodev_asym.c:322:5: error:
>>>> dereferencing pointer to incomplete type 'RSA {aka struct rsa_st}'
>>>>  rsa->n =
>>>>     ^~
>>>>
>>>> My OpenSSL version is 1.1.0h.
>>>>
>>> [Shally] This library is tested with version 1.0.2m (mentioned above) and also
>>> one supported by openssl PMD . So, you need to take similar version.
>>
>> I'd say we should support the latest stable version of OpenSSL.
>> Could you get the latest 1.1.0?
> [Shally] Openssl PMD uses 1.0.2h. If we move test to 1.1.0 then dpdk would need to be set
> to link to two different version of libcrypto whenever openssl PMD is enabled which seems like a cumbersome process for users.
> So I recommend for now to stick to one version.
>

OpenSSL PMD can get compiled/linked with any of the versions 1.0.2 or 
1.1. We cannot control the above applications which version it is using. 
So we should not add limitation for openssl version. Please check below 
snippet in the PMD if this is suitable in your case.

+#if (OPENSSL_VERSION_NUMBER < 0x10100000L)
+static HMAC_CTX *HMAC_CTX_new(void)
+{
+       HMAC_CTX *ctx = OPENSSL_malloc(sizeof(*ctx));
+
+       if (ctx != NULL)
+               HMAC_CTX_init(ctx);
+       return ctx;
+}
+
+static void HMAC_CTX_free(HMAC_CTX *ctx)
+{
+       if (ctx != NULL) {
+               HMAC_CTX_cleanup(ctx);
+               OPENSSL_free(ctx);
+       }
+}
+#endif


> Thanks
> Shally
>
>>
>> Thanks,
>> Pablo