From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A2EDC378E for ; Mon, 19 Sep 2016 19:00:44 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 19 Sep 2016 10:00:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,362,1470726000"; d="scan'208";a="763367448" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.115]) ([10.237.220.115]) by FMSMGA003.fm.intel.com with ESMTP; 19 Sep 2016 10:00:42 -0700 From: Ferruh Yigit To: Xiao Wang , wenzhuo.lu@intel.com References: <1472312902-16963-1-git-send-email-xiao.w.wang@intel.com> <1472312902-16963-2-git-send-email-xiao.w.wang@intel.com> Cc: dev@dpdk.org Message-ID: <9e4205ae-1d41-4956-ad3e-115ef0006c11@intel.com> Date: Mon, 19 Sep 2016 18:00:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1472312902-16963-2-git-send-email-xiao.w.wang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 01/39] net/ixgbe/base: fix delta check for setting VFTA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 17:00:45 -0000 On 8/27/2016 4:47 PM, Xiao Wang wrote: > The delta value rather than vfta_delta pointer should be checked. > > Fixes: b978f7b38c14 ("net/ixgbe/base: simplify VLAN management") > > Signed-off-by: Xiao Wang > --- > drivers/net/ixgbe/base/ixgbe_82598.c | 6 +++--- > drivers/net/ixgbe/base/ixgbe_api.c | 7 ++++--- > drivers/net/ixgbe/base/ixgbe_common.c | 2 +- > 3 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ixgbe/base/ixgbe_82598.c b/drivers/net/ixgbe/base/ixgbe_82598.c > index db80880..724dcbb 100644 > --- a/drivers/net/ixgbe/base/ixgbe_82598.c > +++ b/drivers/net/ixgbe/base/ixgbe_82598.c > @@ -995,19 +995,19 @@ STATIC s32 ixgbe_clear_vmdq_82598(struct ixgbe_hw *hw, u32 rar, u32 vmdq) > * @vlan: VLAN id to write to VLAN filter > * @vind: VMDq output index that maps queue to VLAN id in VFTA > * @vlan_on: boolean flag to turn on/off VLAN in VFTA > - * @bypass_vlvf: boolean flag - unused > + * @vlvf_bypass: boolean flag - unused bypass_vlvf -> vlvf_bypass belongs to different patch > * > * Turn on/off specified VLAN in the VLAN filter table. > **/ > s32 ixgbe_set_vfta_82598(struct ixgbe_hw *hw, u32 vlan, u32 vind, > - bool vlan_on, bool bypass_vlvf) > + bool vlan_on, bool vlvf_bypass) > { > u32 regindex; > u32 bitindex; > u32 bits; > u32 vftabyte; > > - UNREFERENCED_1PARAMETER(bypass_vlvf); > + UNREFERENCED_1PARAMETER(vlvf_bypass); > > DEBUGFUNC("ixgbe_set_vfta_82598"); > > diff --git a/drivers/net/ixgbe/base/ixgbe_api.c b/drivers/net/ixgbe/base/ixgbe_api.c > index 1786867..5b721af 100644 > --- a/drivers/net/ixgbe/base/ixgbe_api.c > +++ b/drivers/net/ixgbe/base/ixgbe_api.c > @@ -1090,7 +1090,7 @@ s32 ixgbe_set_vfta(struct ixgbe_hw *hw, u32 vlan, u32 vind, bool vlan_on, > bool vlvf_bypass) > { > return ixgbe_call_func(hw, hw->mac.ops.set_vfta, (hw, vlan, vind, > - vlan_on, vlvf_bypass), IXGBE_NOT_IMPLEMENTED); > + vlan_on, vlvf_bypass), IXGBE_NOT_IMPLEMENTED); > } > > /** > @@ -1100,7 +1100,7 @@ s32 ixgbe_set_vfta(struct ixgbe_hw *hw, u32 vlan, u32 vind, bool vlan_on, > * @vind: VMDq output index that maps queue to VLAN id in VLVFB > * @vlan_on: boolean flag to turn on/off VLAN in VLVF > * @vfta_delta: pointer to the difference between the current value of VFTA > - * and the desired value > + * and the desired value > * @vfta: the desired value of the VFTA > * @vlvf_bypass: boolean flag indicating updating the default pool is okay > * > @@ -1110,7 +1110,7 @@ s32 ixgbe_set_vlvf(struct ixgbe_hw *hw, u32 vlan, u32 vind, bool vlan_on, > u32 *vfta_delta, u32 vfta, bool vlvf_bypass) > { > return ixgbe_call_func(hw, hw->mac.ops.set_vlvf, (hw, vlan, vind, > - vlan_on, vfta_delta, vfta, vlvf_bypass), > + vlan_on, vfta_delta, vfta, vlvf_bypass), > IXGBE_NOT_IMPLEMENTED); > } > > @@ -1659,6 +1659,7 @@ void ixgbe_init_swfw_semaphore(struct ixgbe_hw *hw) > hw->mac.ops.init_swfw_sync(hw); > } > > + unrelated whitespace modifications > void ixgbe_disable_rx(struct ixgbe_hw *hw) > { > if (hw->mac.ops.disable_rx) > diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c > index 811875a..161bf32 100644 > --- a/drivers/net/ixgbe/base/ixgbe_common.c > +++ b/drivers/net/ixgbe/base/ixgbe_common.c > @@ -3967,7 +3967,7 @@ s32 ixgbe_set_vlvf_generic(struct ixgbe_hw *hw, u32 vlan, u32 vind, > * we run the risk of stray packets leaking into > * the PF via the default pool > */ > - if (vfta_delta) > + if (*vfta_delta) This seems only update mentioned in patch commit log. What about extracting all other clean up modifications into a new patch, other patches also have similar fixes, all can go into that cleanup patch? > IXGBE_WRITE_REG(hw, IXGBE_VFTA(vlan / 32), vfta); > > /* disable VLVF and clear remaining bit from pool */ >