From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F547A034E; Mon, 14 Feb 2022 17:53:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E20C41140; Mon, 14 Feb 2022 17:53:16 +0100 (CET) Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244]) by mails.dpdk.org (Postfix) with ESMTP id 4653A4067E for ; Mon, 14 Feb 2022 17:53:15 +0100 (CET) Received: from [IPv6:2001:67c:1220:80c:eb:e00e:9e81:ff5f] (unknown [IPv6:2001:67c:1220:80c:eb:e00e:9e81:ff5f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id 1A45D400074; Mon, 14 Feb 2022 17:53:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2-2020; t=1644857595; bh=Lyi1VSyIsxNr97lsZyRInq9mk2Pf5Om7724sUOrtpJ8=; h=Subject:From:To:Date:In-Reply-To:References; b=YA2RyH0G0V0A4AseHkDY/j+Z3UVNjEU1vUNCZoEXhuduIpHw8yB0NehQ6iRYfoohb Mv9KL/40gBbSqBHPSNuiJgb8FIwgSjWbNuKHwbUauGaXk1qdZGwUa9+S+ZXjOnu++u ctXluY3jX0e3jit/c7SwYlACymKRc9BLkrlUtUyApjzB4mREb1PEMxO1wSu7VUQM0C gN5x7bQ+G8X3w/TIvHdSp5nOADzmVEd9bjXSQZE9pHBgyKlxs7YN9ufYHCGTJDGD4n XJYB9RY4RshNufN/15iLv6a71KcbIYeA01Z+jEL14b0Q9K2nNimMD1uUCMb/Cglldy sjuE8RiNvVU8g== Message-ID: <9e543fe223f78405a72d36c2d244316510f9f169.camel@cesnet.cz> Subject: Re: [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst From: Martin Spinler To: Ferruh Yigit , dev@dpdk.org Date: Mon, 14 Feb 2022 17:53:14 +0100 In-Reply-To: <9ae7a914-fc0f-f2d9-5e48-00c56676eab1@intel.com> References: <20220214112541.29782-1-spinler@cesnet.cz> <20220214112541.29782-3-spinler@cesnet.cz> <9ae7a914-fc0f-f2d9-5e48-00c56676eab1@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 2022-02-14 at 13:35 +0000, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spinler@cesnet.cz wrote: > > From: Martin Spinler > > > > Zero-sized TX burst floods the log no more. > > > > If you want this patch to be backported, you can update > commit log as fix and add fixes & stable tags. I don't think it is a fix, rather an unplesant behaviour in a specific application. It doesn't happen in the test-pmd app. > > > Signed-off-by: Martin Spinler > > --- > > drivers/net/nfb/nfb_tx.h | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/nfb/nfb_tx.h b/drivers/net/nfb/nfb_tx.h > > index d3cbe3e6b3..910020e9e9 100644 > > --- a/drivers/net/nfb/nfb_tx.h > > +++ b/drivers/net/nfb/nfb_tx.h > > @@ -136,7 +136,10 @@ nfb_eth_ndp_tx(void *queue, > > > > struct ndp_packet packets[nb_pkts]; > > > > - if (unlikely(ndp->queue == NULL || nb_pkts == 0)) { > > + if (unlikely(nb_pkts == 0)) > > + return 0; > > + > > + if (unlikely(ndp->queue == NULL)) { > > RTE_LOG(ERR, PMD, "TX invalid arguments!\n"); > > return 0; > > } >