From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B3F9A04B1; Mon, 5 Oct 2020 17:17:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7C9E1B673; Mon, 5 Oct 2020 17:17:33 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B02871B671 for ; Mon, 5 Oct 2020 17:17:31 +0200 (CEST) IronPort-SDR: +ti3CfCm1v8tCVYVlw2EUfICeffrgOKuxD34mIMA4DbnHWYBwYd+BhW9MnqaD1yZnqsRzzavDK 1gBVbqbKmXBw== X-IronPort-AV: E=McAfee;i="6000,8403,9764"; a="151064068" X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="151064068" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP; 05 Oct 2020 08:17:27 -0700 IronPort-SDR: 0fojaWNIbUiUFM6T20ao3P2iBqYJDxrStq5EHKW5z1YPb+Pm0mMXIkuyDgEJP1j/upCV6ZsOnh U3XSCbqL9Fuw== X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="526121203" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.225.105]) ([10.213.225.105]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 08:14:05 -0700 To: Ajit Khaparde Cc: Thomas Monjalon , Andrew Rybchenko , "Wei Hu (Xavier)" , dpdk-dev References: <20201001181402.28327-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <9e5e82d2-c96f-fec2-df40-ca0cea8381a7@intel.com> Date: Mon, 5 Oct 2020 16:13:59 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: check if queues are allocated before getting info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/1/2020 8:40 PM, Ajit Khaparde wrote: > On Thu, Oct 1, 2020 at 11:14 AM Ferruh Yigit wrote: >> >> A crash is detected when '--txpkts=#' parameter provided to the testpmd, >> this is because queue information is requested before queues have been >> allocated. >> >> Adding check to queue info APIs >> ('rte_eth_rx_queue_info_get()' & 'rte_eth_tx_queue_info_get') >> to protect against similar cases. >> >> Fixes: ba2fb4f022fc ("ethdev: check if queue setup when getting queue info") >> >> Signed-off-by: Ferruh Yigit > > Reviewed-by: Ajit Khaparde > Applied to dpdk-next-net/main, thanks.