* [dpdk-dev] [PATCH] vhost: suppress error if numa is not available [not found] <CGME20180809160856eucas1p2e22900aa2de83e9b17f5843151557d7b@eucas1p2.samsung.com> @ 2018-08-09 16:09 ` Ilya Maximets 2018-08-10 3:03 ` Tiwei Bie [not found] ` <CGME20180810072408eucas1p2ab45e26b6540bdf5634efad9080391d5@eucas1p2.samsung.com> 0 siblings, 2 replies; 6+ messages in thread From: Ilya Maximets @ 2018-08-09 16:09 UTC (permalink / raw) To: dev; +Cc: Maxime Coquelin, Tiwei Bie, Zhihong Wang, Ilya Maximets It's a common case that 'get_mempolicy' fails on systems without NUMA support. No need to flag an error in log for this situation. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> --- lib/librte_vhost/vhost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index 3c9be10..91026b3 100644 --- a/lib/librte_vhost/vhost.c +++ b/lib/librte_vhost/vhost.c @@ -8,6 +8,7 @@ #include <stdint.h> #include <stdlib.h> #ifdef RTE_LIBRTE_VHOST_NUMA +#include <numa.h> #include <numaif.h> #endif @@ -480,7 +481,7 @@ rte_vhost_get_numa_node(int vid) int numa_node; int ret; - if (dev == NULL) + if (dev == NULL || numa_available() != 0) return -1; ret = get_mempolicy(&numa_node, NULL, 0, dev, -- 2.7.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: suppress error if numa is not available 2018-08-09 16:09 ` [dpdk-dev] [PATCH] vhost: suppress error if numa is not available Ilya Maximets @ 2018-08-10 3:03 ` Tiwei Bie 2018-08-10 7:24 ` Ilya Maximets [not found] ` <CGME20180810072408eucas1p2ab45e26b6540bdf5634efad9080391d5@eucas1p2.samsung.com> 1 sibling, 1 reply; 6+ messages in thread From: Tiwei Bie @ 2018-08-10 3:03 UTC (permalink / raw) To: Ilya Maximets; +Cc: dev, Maxime Coquelin, Zhihong Wang [PATCH] vhost: suppress error if numa is not available s/numa/NUMA/ Otherwise check-git-log.sh [1] will complain: Wrong headline lowercase: vhost: suppress error if numa is not available Apart from that, Reviewed-by: Tiwei Bie <tiwei.bie@intel.com> [1] https://github.com/DPDK/dpdk/blob/11a1f847d281/devtools/check-git-log.sh#L109 Thanks On Thu, Aug 09, 2018 at 07:09:38PM +0300, Ilya Maximets wrote: > It's a common case that 'get_mempolicy' fails on systems > without NUMA support. No need to flag an error in log for > this situation. > > Signed-off-by: Ilya Maximets <i.maximets@samsung.com> > --- > lib/librte_vhost/vhost.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c > index 3c9be10..91026b3 100644 > --- a/lib/librte_vhost/vhost.c > +++ b/lib/librte_vhost/vhost.c > @@ -8,6 +8,7 @@ > #include <stdint.h> > #include <stdlib.h> > #ifdef RTE_LIBRTE_VHOST_NUMA > +#include <numa.h> > #include <numaif.h> > #endif > > @@ -480,7 +481,7 @@ rte_vhost_get_numa_node(int vid) > int numa_node; > int ret; > > - if (dev == NULL) > + if (dev == NULL || numa_available() != 0) > return -1; > > ret = get_mempolicy(&numa_node, NULL, 0, dev, > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: suppress error if numa is not available 2018-08-10 3:03 ` Tiwei Bie @ 2018-08-10 7:24 ` Ilya Maximets 0 siblings, 0 replies; 6+ messages in thread From: Ilya Maximets @ 2018-08-10 7:24 UTC (permalink / raw) To: Tiwei Bie; +Cc: dev, Maxime Coquelin, Zhihong Wang On 10.08.2018 06:03, Tiwei Bie wrote: > > [PATCH] vhost: suppress error if numa is not available > > s/numa/NUMA/ > > Otherwise check-git-log.sh [1] will complain: > > Wrong headline lowercase: > vhost: suppress error if numa is not available Sure. Thanks for pointing that. I'll send v2. > > Apart from that, > > Reviewed-by: Tiwei Bie <tiwei.bie@intel.com> > > [1] https://github.com/DPDK/dpdk/blob/11a1f847d281/devtools/check-git-log.sh#L109 > > Thanks > > On Thu, Aug 09, 2018 at 07:09:38PM +0300, Ilya Maximets wrote: >> It's a common case that 'get_mempolicy' fails on systems >> without NUMA support. No need to flag an error in log for >> this situation. >> >> Signed-off-by: Ilya Maximets <i.maximets@samsung.com> >> --- >> lib/librte_vhost/vhost.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c >> index 3c9be10..91026b3 100644 >> --- a/lib/librte_vhost/vhost.c >> +++ b/lib/librte_vhost/vhost.c >> @@ -8,6 +8,7 @@ >> #include <stdint.h> >> #include <stdlib.h> >> #ifdef RTE_LIBRTE_VHOST_NUMA >> +#include <numa.h> >> #include <numaif.h> >> #endif >> >> @@ -480,7 +481,7 @@ rte_vhost_get_numa_node(int vid) >> int numa_node; >> int ret; >> >> - if (dev == NULL) >> + if (dev == NULL || numa_available() != 0) >> return -1; >> >> ret = get_mempolicy(&numa_node, NULL, 0, dev, >> -- >> 2.7.4 >> > > ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20180810072408eucas1p2ab45e26b6540bdf5634efad9080391d5@eucas1p2.samsung.com>]
* [dpdk-dev] [PATCH v2] vhost: suppress error if NUMA is not available [not found] ` <CGME20180810072408eucas1p2ab45e26b6540bdf5634efad9080391d5@eucas1p2.samsung.com> @ 2018-08-10 7:24 ` Ilya Maximets 2018-08-10 16:30 ` Maxime Coquelin 2018-08-10 16:38 ` Maxime Coquelin 0 siblings, 2 replies; 6+ messages in thread From: Ilya Maximets @ 2018-08-10 7:24 UTC (permalink / raw) To: dev; +Cc: Maxime Coquelin, Tiwei Bie, Zhihong Wang, Ilya Maximets It's a common case that 'get_mempolicy' fails on systems without NUMA support. No need to flag an error in log for this situation. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com> --- Version 2: * Fixed 'check-git-log.sh' warning. lib/librte_vhost/vhost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index 3c9be10..91026b3 100644 --- a/lib/librte_vhost/vhost.c +++ b/lib/librte_vhost/vhost.c @@ -8,6 +8,7 @@ #include <stdint.h> #include <stdlib.h> #ifdef RTE_LIBRTE_VHOST_NUMA +#include <numa.h> #include <numaif.h> #endif @@ -480,7 +481,7 @@ rte_vhost_get_numa_node(int vid) int numa_node; int ret; - if (dev == NULL) + if (dev == NULL || numa_available() != 0) return -1; ret = get_mempolicy(&numa_node, NULL, 0, dev, -- 2.7.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] vhost: suppress error if NUMA is not available 2018-08-10 7:24 ` [dpdk-dev] [PATCH v2] vhost: suppress error if NUMA " Ilya Maximets @ 2018-08-10 16:30 ` Maxime Coquelin 2018-08-10 16:38 ` Maxime Coquelin 1 sibling, 0 replies; 6+ messages in thread From: Maxime Coquelin @ 2018-08-10 16:30 UTC (permalink / raw) To: Ilya Maximets, dev; +Cc: Tiwei Bie, Zhihong Wang On 08/10/2018 09:24 AM, Ilya Maximets wrote: > It's a common case that 'get_mempolicy' fails on systems > without NUMA support. No need to flag an error in log for > this situation. > > Signed-off-by: Ilya Maximets <i.maximets@samsung.com> > Reviewed-by: Tiwei Bie <tiwei.bie@intel.com> > --- > > Version 2: > * Fixed 'check-git-log.sh' warning. > > lib/librte_vhost/vhost.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks! Maxime ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] vhost: suppress error if NUMA is not available 2018-08-10 7:24 ` [dpdk-dev] [PATCH v2] vhost: suppress error if NUMA " Ilya Maximets 2018-08-10 16:30 ` Maxime Coquelin @ 2018-08-10 16:38 ` Maxime Coquelin 1 sibling, 0 replies; 6+ messages in thread From: Maxime Coquelin @ 2018-08-10 16:38 UTC (permalink / raw) To: Ilya Maximets, dev; +Cc: Tiwei Bie, Zhihong Wang On 08/10/2018 09:24 AM, Ilya Maximets wrote: > It's a common case that 'get_mempolicy' fails on systems > without NUMA support. No need to flag an error in log for > this situation. > > Signed-off-by: Ilya Maximets <i.maximets@samsung.com> > Reviewed-by: Tiwei Bie <tiwei.bie@intel.com> > --- > > Version 2: > * Fixed 'check-git-log.sh' warning. > > lib/librte_vhost/vhost.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to dpdk-next-virtio Thanks, Maxime ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-10 16:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180809160856eucas1p2e22900aa2de83e9b17f5843151557d7b@eucas1p2.samsung.com>
2018-08-09 16:09 ` [dpdk-dev] [PATCH] vhost: suppress error if numa is not available Ilya Maximets
2018-08-10 3:03 ` Tiwei Bie
2018-08-10 7:24 ` Ilya Maximets
[not found] ` <CGME20180810072408eucas1p2ab45e26b6540bdf5634efad9080391d5@eucas1p2.samsung.com>
2018-08-10 7:24 ` [dpdk-dev] [PATCH v2] vhost: suppress error if NUMA " Ilya Maximets
2018-08-10 16:30 ` Maxime Coquelin
2018-08-10 16:38 ` Maxime Coquelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).