From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CB46A04C7; Tue, 15 Sep 2020 13:07:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B90C1BE8E; Tue, 15 Sep 2020 13:07:18 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5DD8EE07 for ; Tue, 15 Sep 2020 13:07:15 +0200 (CEST) IronPort-SDR: 673y8uVxbB/O0X2MEpX+3bGcL3ttdXZU3/WkoPl1Pa6WT0pPQNhcCJV5C2rQ7lhaMBk6QtLRbw TOVnhJoEmPhw== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="159284584" X-IronPort-AV: E=Sophos;i="5.76,429,1592895600"; d="scan'208";a="159284584" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 04:07:07 -0700 IronPort-SDR: lnh/C8bjK5HMAasXn+jq6yFFdNWSedf34OzhuYvsMR+GyuZ2P2F0RLuDF395vHrkhlnMAV9MHJ kPoh6mG9pSPA== X-IronPort-AV: E=Sophos;i="5.76,429,1592895600"; d="scan'208";a="482728669" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.215.1]) ([10.213.215.1]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 04:07:05 -0700 To: Ophir Munk , "dev@dpdk.org" , Wenzhuo Lu , Beilei Xing , Bernard Iremonger Cc: Ophir Munk , Raslan Darawsheh References: <20200729082905.19499-4-ophirmu@mellanox.com> <20200827070244.32392-1-ophirmu@nvidia.com> <20200827070244.32392-3-ophirmu@nvidia.com> <30fe788b-7447-1b83-b847-bdbe3cd7d4f3@intel.com> From: Ferruh Yigit Message-ID: <9e726d1f-1ca0-7e11-9fda-4866446caee4@intel.com> Date: Tue, 15 Sep 2020 12:07:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: enable configuring GENEVE port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/15/2020 9:46 AM, Ophir Munk wrote: > Hi Ferruh, > I don't think that having the flexibility to specify the Geneve protocol in the command line will have an added value. > The reason is that any Geneve setup has a fixed protocol number for the duration of the test lifetime (fixed and synched by all the peers in the lab). The protocol number is not dynamic. > So even if we could specify the protocol in the command line - it would be a onetime setting after testpmd startup. Therefore, it is simpler to have it as parameter only. > OK, if you think there is a value. Overall, not specific to this patch, it bothers me not having any guideline what to add as a parameter, and not able to say what is implemented as parameter without searching for it ... > Regards, > Ophir > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Monday, September 14, 2020 8:31 PM >> To: Ophir Munk ; dev@dpdk.org; Wenzhuo Lu >> ; Beilei Xing ; Bernard >> Iremonger >> Cc: Ophir Munk >> Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: enable configuring >> GENEVE port >> >> On 8/27/2020 8:02 AM, Ophir Munk wrote: >>> From: Ophir Munk >>> >>> IANA has assigned port 6081 as the fixed well-known destination port >>> for GENEVE. Nevertheless draft-ietf-nvo3-geneve-09 recommends that >>> implementations make this configurable. This commit enables >>> specifying any positive UDP destination port number for GENEVE. >>> >>> Signed-off-by: Ophir Munk >>> --- >>> app/test-pmd/parameters.c | 13 ++++++++++++- >>> 1 file changed, 12 insertions(+), 1 deletion(-) >>> >>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >>> index 7cb0e3d..0d135b0 100644 >>> --- a/app/test-pmd/parameters.c >>> +++ b/app/test-pmd/parameters.c >>> @@ -70,7 +70,8 @@ usage(char* progname) >>> "--rxpt= | --rxht= | --rxwt= | --rxfreet= | " >>> "--txpt= | --txht= | --txwt= | --txfreet= | " >>> "--txrst= | --tx-offloads= | | --rx-offloads= | " >>> - "--vxlan-gpe-port= ]\n", >>> + "--vxlan-gpe-port= ] " >>> + "--geneve-port= ]\n", >>> progname); >> >> Hi Ophir, >> >> Is there a command line to update the geneve port? >> >> I can see there are some parameter for other tunneling too, but do you find >> providing parameter useful? I think command line better since it is more >> flexible, what do you think?