From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7D57749E0; Fri, 9 Nov 2018 13:03:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Nov 2018 04:03:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,483,1534834800"; d="scan'208";a="278456883" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.143]) ([10.237.220.143]) by fmsmga005.fm.intel.com with ESMTP; 09 Nov 2018 04:03:31 -0800 To: Rami Rosen Cc: Ferruh Yigit , dev@dpdk.org, john.mcnamara@intel.com, stable@dpdk.org References: From: "Burakov, Anatoly" Message-ID: <9e7f9bd5-b71b-4758-133e-16b1c8e6abbe@intel.com> Date: Fri, 9 Nov 2018 12:03:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 12:03:34 -0000 On 08-Nov-18 8:38 PM, Rami Rosen wrote: > Hi, Anatoly, > > This is really minor nitpick, but in case you decide to send V2, I > believe it should say > >> + if ret != 0: > >> +            print("'lspci' not found - please install pciutils') > > as the name of the package containing lspci is pciutils in centos. Do all other distros have lspci in package called pciutils? If not, i prefer to keep it the way it is. > > Regards, > Rami Rosen > > -- Thanks, Anatoly