From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DB4CA00C3; Thu, 20 Jan 2022 11:46:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94575426DD; Thu, 20 Jan 2022 11:46:57 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id E9C0740042; Thu, 20 Jan 2022 11:46:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642675615; x=1674211615; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=SuxhLDzIZ3NRu+ASbihOU7rkRMcCgDn6odVRoi2+Xvk=; b=jTrJkFJs7v8wTrsqcxnLHUY7VbZrsf4tQH1gpIYKXgm0zmMypr13TffB pZZPzupmnJ029SgU0gEbvFa1bH7Bi1HfxTf5h+k3HFcyNHUzpkUC/OWoY ou84Nde/C6WT5X5OsCJHn/5KKITDLIt3ofq9JnVpT7RCUWtutb5iGwIpS hW1fvXYAb/sIaFnvAx10NfnqyvYso3YOmn+FAXFs1YdbJptN1ASQXKb4h KX0/U9VhHOA6GQadz+yZMBlQUkTYs0P8Z29jKDNwnvK8vqd1/iVRFloFq /HhcxaJtuDt1/V6LI5PgW0YOOf0pVdptWOeQWIhJeSvfbUWIIyMdnnmKo A==; X-IronPort-AV: E=McAfee;i="6200,9189,10232"; a="269722772" X-IronPort-AV: E=Sophos;i="5.88,302,1635231600"; d="scan'208";a="269722772" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 02:46:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,302,1635231600"; d="scan'208";a="493382536" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 20 Jan 2022 02:46:50 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 20 Jan 2022 02:46:49 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 20 Jan 2022 02:46:49 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 20 Jan 2022 02:46:49 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 20 Jan 2022 02:46:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddsIvVqyjP1qhJQlxFqLYT51SIbZRrne/yvPz/Bs2A7x/ebTgz4bu9qez+qStJAxfCsnHb85b1RIaDu2za4D5jVdoo0wfkjgIswEaTIjy2mBiboN0LWuDF9B4GqoxySuYDrIAFpDtwbhdBSoP05edBlv5TvPm2MHiISZK40mBkzs2O5PSa4rcSzKarZc/OCsFPlOb1WYGL1wlX3Adtt9MBej/GzT2gwp3M02OpbrwZ7XZv0yXPPmmrNKmftWAwrr5F+gtSbvQmvZSKKQrGsDmPCaYwKj/bvpstmZPqTlQyA+IttSE30WUEKXnG7kWkYWG/Mu4TIkE2ZtmQpxw5fIZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xB3U20Z103yVtVXVja4ueijz142sWffvRtAHvaR6ESU=; b=mV47YKcOuRY8PNuQz7FqF2CRtV5AqIunTzsk3wn++SOLuOrqiEPpJ9U6bzkxjRKXKyyxhAkERBqe7acmifzVY1Lro3aw2Ni2FIiesPxOn75sUns86N8lfLQtutIeGquG8uZ0z856RtyOupBzU8ciXuaZpZhFo10AD2Hoz6gt3l/Dwh/ZzioHsdNBS8Axoiyo72lRopAbk4pgZNGb7K7gDOa/OGxxJ970CSdJe/gmRikxi1iFvqMhAAAxiJ4VV2PixlSyJTb92/b4IabawCFqoipKMPquLUpoF9ybY4ztmTP2E+GiuhJBPV31sWwe+YJptRinZUNYiaUK8HFarCoxXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by DM4PR11MB5327.namprd11.prod.outlook.com (2603:10b6:5:392::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Thu, 20 Jan 2022 10:46:47 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::10c4:88fd:5820:cc2c]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::10c4:88fd:5820:cc2c%6]) with mapi id 15.20.4888.014; Thu, 20 Jan 2022 10:46:47 +0000 Message-ID: <9e8ec1b6-4131-8c26-c814-f46d56e76c28@intel.com> Date: Thu, 20 Jan 2022 16:16:35 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode To: Matan Azrad , Ferruh Yigit , Raja Zidane , "dev@dpdk.org" CC: "stable@dpdk.org" References: <20211205034450.7888-1-rzidane@nvidia.com> <4787802c-cefe-6d15-817f-6b906451ded8@intel.com> <6b4a6388-92b7-eeb5-f218-b007199e3ddf@intel.com> From: "Singh, Aman Deep" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PN0PR01CA0017.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:4f::22) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a7d012e1-2a36-42bf-8926-08d9dc0227f2 X-MS-TrafficTypeDiagnostic: DM4PR11MB5327:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HY8O9aXVu78EOC7boxoTN2UvJpKInBJ0VjUG7GYQJ7WxSyw6xG59xV+QxmrrjKUSXhgf1xEQEOFe5iizvn3W+rRYqvV2WsuCP1cEiwYA5G87bMhlKukrguE0ZNFb+tObKdB9wtr/N77gF/9g/8TwSU3uRuS5ePIyTR7w7YPoVKn8fyvFoL6zhC+7Lm/GpL203kBYsiVgbC8nIzqFwmQB5rmZOVlykJiQ4e4xqTpKb0SpMgaxwErn4nrvD+uTWgK6eVmR5J6s9Vn6ifXvTSlD6Tva9VqU8d+drtgAHd2NiQIVOjQ6LeNbUFCdMH3QWg+GxgUP37gYDnc6uoWhZy+4/T3VZeiUp7oGIMvBTDRilv4RKJQupdwYXWFGK9qurbS+q1JpY6s+OlDZzLuahgtsS9tQFZbAK1XXmmfoPeX57V/B84FzwrM+EwVKH0/9Zlpnpppdhqj2gb0tGicUtmaQq5NmtnYxOFIp8cEESenu+56vtynjiIAM5bAX7fZ3tkqqxli+FGAcH8p0RtrUfXgWd3zrU4x0K0sHsre18RCyOpghSBXkpG2spessfcrAF611XByve1gPpkGdMobVxZFIHVvzLkn00ZP14anW7rVz6BjepUgF3VfcTvrlIjvwSk+t9CoSvuejdDEqdmx8x9DkYi4abTFFIzFVubDY8i4ytn9HOY2tTfH6247CBKgGny2jhA0sjUmHL1GKUcIOd4auRQg+u8bK9cBO/rg5rTkoa74v8luEmnZPU4+5azxcWBOmpXgTVprGTZlTwRjGI+cWirnfNUEOC0nf6rvdRuJ537qQBVSGU9S2gfDzAKGs8UB7 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(8936002)(36756003)(8676002)(508600001)(53546011)(83380400001)(6486002)(6506007)(26005)(186003)(31686004)(6512007)(316002)(6666004)(2616005)(82960400001)(966005)(31696002)(66476007)(66556008)(66946007)(110136005)(86362001)(38100700002)(5660300002)(4326008)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekN1dXBpYWplVEo2L3ZIdXI2WUxmRE1PaHlSVDNJbVpmNm83ZHFQbHQ0bVda?= =?utf-8?B?bEovbjRRWUpnY3BkWGhlMk5DZEJQVTNOQWl0M29nRTJZRURCMW0wWUhValZZ?= =?utf-8?B?ZlRVb3ZpcnJ0ajNYaGxtYjREYWpiQ3lOM0FTWHRXWVRSUW9ndTdxRmZFM3R2?= =?utf-8?B?enZ1b3FWM1p1Rml6UGdWSTVkcjNSTHczRjZKTXdMWCtlVGpNM24yZmZWVWVY?= =?utf-8?B?OGUzOWVGdUZxTkh6dHQza1VkTitJV1IwRCt6bWpuN21PLzlzSk01SW1rUitY?= =?utf-8?B?WWVUaHFYYk5xKzlxaXJZNnJFMDBySE80bkhwMndBaXdOU1RYVWJiNmxlK3VK?= =?utf-8?B?Znc4Z1ZVcVhTU3dvMEVIYlNsVWRmbjVldkV4S0c5ZGlYOWZqY3ZiYjlycEJw?= =?utf-8?B?elU0YUNSK2FBdTh6bytGUmo4K1llV2FMTktId2RqNjRWR3lrS1hTK0lWNnp0?= =?utf-8?B?YmVQUnNIV2FUVEtvVlJlZ3BmaU5yQjhUREtVek8wY0Z4SDBzUDRhUTI5WUxI?= =?utf-8?B?NUVaV3ltRWM2YzdlNGQ0WWwyS1pXS1orRktDOUg4UEFQaGxKMzU4L2hPRFRt?= =?utf-8?B?NTU5YjQ5eHU1MUEzT3BmTldYOVF2TG9jZDdhbk1ralJjekZUYjVJZXRjOVpv?= =?utf-8?B?emVCVzR2UkhUSHFheEc1NUJOSnIwYlFHU0lOR2xmVHcyWkpuZ29nWW1ySHBC?= =?utf-8?B?SG1mM3B5M3JlRWZvU2FWTEF4T3dLRC9IWmVnbUJWaG9pOU5lRlp0cVlCNTRj?= =?utf-8?B?ODZ0OUNNR2lRTkQ2aDFKSWROUnJTYjhuUkk4czJac3JxblhQeGFrNDRmRk8r?= =?utf-8?B?eDJWS29MZWpSdm1pU2R1UWcxWlc0eTRFUS9qSWQwZHpuaUVHc3QrQnhrQm1E?= =?utf-8?B?bGZNL3lzT0dVTlNwQmlHd0FGMGlRNWVXcDR5Ym51ZmFaUDd4eWg0d0JaS2pY?= =?utf-8?B?SGRjcG42VldKdGNWK1p5NVp4S3BKWGczb1VMYkZ5eEJTQnlOaDcycFNzOTBE?= =?utf-8?B?ZUw3TnM4aTBBckpKM05lMFcycXNQVVRiZEppUjk1MXg0Ym1HWElZZnZqM002?= =?utf-8?B?STUzNjRjRGpJTjc4QitXeFBEZjVVVzZ1U25HUzl4cWFaUnQwcERWRURzNDN3?= =?utf-8?B?ZVd0em8yekJVbHdDSm9KVExySGR1N1B5SnNvMnNOWjk4ekJtSldmaVBKaGJo?= =?utf-8?B?dW1wQTRzRVQyQWhCbkpEWEJhUDBZU3ZpK0cwVGJldG1TdkpKV2crenJvc09G?= =?utf-8?B?Mnd2bHNxeGRPb2MzOGhiTUNyRmdHVlNzVFVXZzAyUVBMS0dFRDI3b242ZzRa?= =?utf-8?B?OHBVdjBMQkhZeTY3VnF4YTdkQi9HWWtqc2dVUVhEUlg3VFlrVUpBUFNuSkk2?= =?utf-8?B?SFZxVHN2VVNtaDFTNEhUY3daTXZ2UDdtaDRoUEszbDh2R0ZmcEc1VVRIcy9n?= =?utf-8?B?RjFONmZqL1NKakRON3VYSFpWYUNZWmVvRkIwcnQ3SnZIeml1c0d1UlpmWXRM?= =?utf-8?B?KzFsSktORkUyanJFNlBrSkZYaXlQcUdISmZRR0JJTWlqQWZ4OGwycHllSWRu?= =?utf-8?B?YjhjbjFqb2xmMFdGZ0pUNFJWTjZkZU52L2ZQYUxGTzlVN1F3U2RUUDR1VVBT?= =?utf-8?B?a09jY3pLblR5S0cwMUE1WG03ODArS01RcjZ3L1dDSk8rejFMcVRNWjFOYkpo?= =?utf-8?B?a0dmNVRkWHh4TC80bHlueGRPa25jbUZqc20yTE5iRGhpNHRPN08vemwxTUg4?= =?utf-8?B?S0p3N3lNR0x1eVpObkJYeUtoV2FtTFdhNFIxMmUrbjlTZ2djVVRtUG9ENjdv?= =?utf-8?B?UDhNZWNBZmUvc0dCV2ZDdERYNy8zWmV3UUVNa3JBQU1BSEd5UWtDZGNJSEli?= =?utf-8?B?RFFFZkdjVWdib2dzMUdvNkNhdnFJTVRVVVBpSGNsWVlJWVZvUXZBeFc2VVM1?= =?utf-8?B?bElUU3ZWTmdZMUhVOUNFVUNRTDlvUXV2NEN5L1pmZjRGQjZjU2ZvazEwaVFm?= =?utf-8?B?ajlkVEVPWG1MWWJTZG1EVW9Yb1E4LzRCaDBPNDZITzN6SG1EUmUvYUREQ3FV?= =?utf-8?B?ZHN0bE9xUllEV1dhMmRIU2hyOGhlNllEZE90SWRtcjFBQzZwbGQrNndqdllN?= =?utf-8?B?T09SaHNLWTdTSml0Y1VHRDlpT0tZNXhMSVFwTWI3YjdBRVE5ZUpOR2xSQmNY?= =?utf-8?B?bXdZNjRYOVl3dWlsQXFqelI3b2ZER0YxYm9Zc0k0a25PamhrY0ZJc3htWVFj?= =?utf-8?Q?OaEaerijTZqwzuxTyLc66rMrg6s6fD52k+8Lxsbwds=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a7d012e1-2a36-42bf-8926-08d9dc0227f2 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2022 10:46:47.2574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DGzv/nVM/iF1TRQC3O/d+ddHaOuiFrPZXlP56ZKmvPJllpdJx/z/0doc3dQg6GM3gkykiDU7eyGppF2T1W+sdX2I+AzTVsKZYBc6IqVniGg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5327 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/18/2022 6:49 PM, Matan Azrad wrote: > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, January 18, 2022 3:03 PM >> To: Matan Azrad ; Raja Zidane ; >> dev@dpdk.org >> Cc: stable@dpdk.org >> Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode >> >> External email: Use caution opening links or attachments >> >> >> On 1/18/2022 12:55 PM, Matan Azrad wrote: >>> >>>> -----Original Message----- >>>> From: Ferruh Yigit >>>> Sent: Tuesday, January 18, 2022 2:28 PM >>>> To: Matan Azrad ; Raja Zidane ; >>>> dev@dpdk.org >>>> Cc: stable@dpdk.org >>>> Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward >>>> mode >>>> >>>> External email: Use caution opening links or attachments >>>> >>>> >>>> On 1/18/2022 11:27 AM, Matan Azrad wrote: >>>>> >>>>>> -----Original Message----- >>>>>> From: Ferruh Yigit >>>>>> Sent: Tuesday, January 18, 2022 11:52 AM >>>>>> To: Raja Zidane ; dev@dpdk.org >>>>>> Cc: Matan Azrad ; stable@dpdk.org >>>>>> Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum >>>>>> forward mode >>>>>> >>>>>> External email: Use caution opening links or attachments >>>>>> >>>>>> >>>>>> On 12/5/2021 3:44 AM, Raja Zidane wrote: >>>>>>> The csum FWD mode parses any received packet to set mbuf offloads >>>>>>> for the transmitting burst, mainly in the checksum/TSO areas. >>>>>>> In the case of a tunnel header, the csum FWD tries to detect known >>>>>>> tunnels by the standard definition using the header'sdata and >>>>>>> fallback to check the packet type in the mbuf to see if the Rx >>>>>>> port driver already sign the packet as a tunnel. >>>>>>> In the fallback case, the csum assumes the tunnel is VXLAN and >>>>>>> parses the tunnel as VXLAN. >>>>>> As far as I can see there is a VXLAN port check in 'parse_vxlan()', >>>>>> why it is not helping? >>>>>> >>>>> The problem is not the vxlan check but the tunnel type in mbuf that >>>>> caused the >>>> packet to be detected as vxlan(default) before checking GENEVE tunnel case. >>>> Check is as following: >>>> >>>> if (udp_hdr->dst_port != _htons(RTE_VXLAN_DEFAULT_PORT) && >>>> RTE_ETH_IS_TUNNEL_PKT(pkt_type) == 0) >>>> return; >>>> >>>> Do you what is the intention for the "RTE_ETH_IS_TUNNEL_PKT(pkt_type) == >> 0" >>>> check? >>>> Why vxlan parsing doesn't stop when it is not default port? >>> Maybe some drivers set the tunnel type for vxlan packets coming after non- >> standard vxlan port. >> But checking the tunnel flag to say that it is vxlan is too broad, isn't it? >> And this is the problem you are having. >> >> Can there be any way to detect and check non-standard vxlan port? > Maybe yes, but it is probably more complex solusion. > > See this patch: > https://patches.dpdk.org/project/dpdk/patch/1423819371-24222-13-git-send-email-olivier.matz@6wind.com/ > > comments there: > 1. check udp destination port, 4789 is the default vxlan port (rfc7348). > 2. currently, this flag is set by i40e only if the packet is vxlan > > And maybe another driver assumes more ports here. > > Collecting all the non-standard ports can start from i40 maintainers😊 I think, here we should check for supported tunnel types only.  The i40 driver setting a Tunnel flag, does not means that it VxLan type only. As in your case those were GENEVE packets getting treated as VxLan. Making parse_vxlan() udp_dst_port specific can avoid this issue. >>>>>>> When the GENEVE tunnel was added to the known tunnels in csum, its >>>>>>> parsing trial was wrongly located after the pkt type detection, >>>>>>> causing the csum to parse the GENEVE header as VXLAN when the Rx >>>>>>> port set the tunnel packet type. >>>>>>> >>>>>>> Locate the GENEVE parsing trial before the packet type detection. >>>>>>> >>>>>>> Fixes: ea0e711b8ae0 ("app/testpmd: add GENEVE parsing") >>>>>>> Cc: stable@dpdk.org >>>>>>> >>>>>>> Signed-off-by: Raja Zidane >>>>>>> --- >>>>>>> Acked-by: Matan Azrad >>>>>> Ack should be before '---' to be part of the commit log, otherwise >>>>>> it is dropped when applied as comment. >>>>>> >>>>>>> app/test-pmd/csumonly.c | 16 ++++++++++------ >>>>>>> 1 file changed, 10 insertions(+), 6 deletions(-) >>>>>>> >>>>>>> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c >>>>>>> index 2aeea243b6..fe810fecdd 100644 >>>>>>> --- a/app/test-pmd/csumonly.c >>>>>>> +++ b/app/test-pmd/csumonly.c >>>>>>> @@ -254,7 +254,10 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, >>>>>>> info->l2_len += RTE_ETHER_GTP_HLEN; >>>>>>> } >>>>>>> >>>>>>> -/* Parse a vxlan header */ >>>>>>> +/* >>>>>>> + * Parse a vxlan header. >>>>>>> + * If a tunnel is detected in 'pkt_type' it will be parsed by default as vxlan. >>>>>>> + */ >>>>>>> static void >>>>>>> parse_vxlan(struct rte_udp_hdr *udp_hdr, >>>>>>> struct testpmd_offload_info *info, @@ -912,17 +915,18 >>>>>>> @@ pkt_burst_checksum_forward(struct fwd_stream *fs) >>>>>>> RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE; >>>>>>> goto tunnel_update; >>>>>>> } >>>>>>> - parse_vxlan(udp_hdr, &info, >>>>>>> - m->packet_type); >>>>>>> + parse_geneve(udp_hdr, &info); >>>>>>> if (info.is_tunnel) { >>>>>>> tx_ol_flags |= >>>>>>> - RTE_MBUF_F_TX_TUNNEL_VXLAN; >>>>>>> + >>>>>>> + RTE_MBUF_F_TX_TUNNEL_GENEVE; >>>>>>> goto tunnel_update; >>>>>>> } >>>>>>> - parse_geneve(udp_hdr, &info); >>>>>>> + /* Always keep last. */ >>>>>>> + parse_vxlan(udp_hdr, &info, >>>>>>> + m->packet_type); >>>>>>> if (info.is_tunnel) { >>>>>>> tx_ol_flags |= >>>>>>> - RTE_MBUF_F_TX_TUNNEL_GENEVE; >>>>>>> + >>>>>>> + RTE_MBUF_F_TX_TUNNEL_VXLAN; >>>>>>> goto tunnel_update; >>>>>>> } >>>>>>> } else if (info.l4_proto == IPPROTO_GRE) {