From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D214CA0032; Wed, 11 May 2022 04:26:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F404410F2; Wed, 11 May 2022 04:26:05 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id A41AF410EE for ; Wed, 11 May 2022 04:26:03 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Kydz50F2xz1JC6B; Wed, 11 May 2022 10:24:49 +0800 (CST) Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 11 May 2022 10:26:00 +0800 Subject: Re: [PATCH v3 1/3] examples/dma: fix MTU configuration From: fengchengwen To: , , , CC: References: <20220411025634.33032-1-fengchengwen@huawei.com> <20220424060741.33214-1-fengchengwen@huawei.com> <20220424060741.33214-2-fengchengwen@huawei.com> Message-ID: <9ed2ca68-6cdb-c7f0-e16c-c133bf8998e6@huawei.com> Date: Wed, 11 May 2022 10:26:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20220424060741.33214-2-fengchengwen@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh Could you please review this patch ? I notice many examples (e.g. l3fwd/l3fwd-acl/l3fwd-power/l3fwd-thread/l3fwd-graph) use the same approach (which define eth_dev_get_overhead_len/config_port_max_pkt_len). Thanks. On 2022/4/24 14:07, Chengwen Feng wrote: > From: Huisong Li > > The MTU in dma App can be configured by 'max_frame_size' parameters which > have a default value(1518). It's not reasonable to use it directly as MTU. > This patch fix it. > > Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > --- > examples/dma/dmafwd.c | 43 +++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 39 insertions(+), 4 deletions(-) > > diff --git a/examples/dma/dmafwd.c b/examples/dma/dmafwd.c > index 608487e35c..a03ca05129 100644 > --- a/examples/dma/dmafwd.c > +++ b/examples/dma/dmafwd.c > @@ -117,7 +117,7 @@ static uint16_t nb_txd = TX_DEFAULT_RINGSIZE; > static volatile bool force_quit; > > static uint32_t dma_batch_sz = MAX_PKT_BURST; > -static uint32_t max_frame_size = RTE_ETHER_MAX_LEN; > +static uint32_t max_frame_size; > > /* ethernet addresses of ports */ > static struct rte_ether_addr dma_ports_eth_addr[RTE_MAX_ETHPORTS]; > @@ -851,6 +851,38 @@ assign_rings(void) > } > /* >8 End of assigning ring structures for packet exchanging. */ > > +static uint32_t > +eth_dev_get_overhead_len(uint32_t max_rx_pktlen, uint16_t max_mtu) > +{ > + uint32_t overhead_len; > + > + if (max_mtu != UINT16_MAX && max_rx_pktlen > max_mtu) > + overhead_len = max_rx_pktlen - max_mtu; > + else > + overhead_len = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN; > + > + return overhead_len; > +} > + > +static int > +config_port_max_pkt_len(struct rte_eth_conf *conf, > + struct rte_eth_dev_info *dev_info) > +{ > + uint32_t overhead_len; > + > + if (max_frame_size == 0) > + return 0; > + > + if (max_frame_size < RTE_ETHER_MIN_LEN) > + return -1; > + > + overhead_len = eth_dev_get_overhead_len(dev_info->max_rx_pktlen, > + dev_info->max_mtu); > + conf->rxmode.mtu = max_frame_size - overhead_len; > + > + return 0; > +} > + > /* > * Initializes a given port using global settings and with the RX buffers > * coming from the mbuf_pool passed as a parameter. > @@ -878,9 +910,6 @@ port_init(uint16_t portid, struct rte_mempool *mbuf_pool, uint16_t nb_queues) > struct rte_eth_dev_info dev_info; > int ret, i; > > - if (max_frame_size > local_port_conf.rxmode.mtu) > - local_port_conf.rxmode.mtu = max_frame_size; > - > /* Skip ports that are not enabled */ > if ((dma_enabled_port_mask & (1 << portid)) == 0) { > printf("Skipping disabled port %u\n", portid); > @@ -895,6 +924,12 @@ port_init(uint16_t portid, struct rte_mempool *mbuf_pool, uint16_t nb_queues) > rte_exit(EXIT_FAILURE, "Cannot get device info: %s, port=%u\n", > rte_strerror(-ret), portid); > > + ret = config_port_max_pkt_len(&local_port_conf, &dev_info); > + if (ret != 0) > + rte_exit(EXIT_FAILURE, > + "Invalid max frame size: %u (port %u)\n", > + max_frame_size, portid); > + > local_port_conf.rx_adv_conf.rss_conf.rss_hf &= > dev_info.flow_type_rss_offloads; > ret = rte_eth_dev_configure(portid, nb_queues, 1, &local_port_conf); >