From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A87C43A13; Wed, 31 Jan 2024 00:09:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E82D840269; Wed, 31 Jan 2024 00:09:55 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id E1D7E40266 for ; Wed, 31 Jan 2024 00:09:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lJIN0D4/UpqROMlgL9ZIR1eivlWlsg969T4D64/yGuiv4TuahKyXWFw1s9wQ+ReSmAMCEtT3F4ug1xjpFCH39B6R96bgM2frZFfZxR3mI8Sljcxi+Xz4XY5d4Upp3DMmn+i1+nlPZ9s1ie/5uWXCRp0WIcZrnz1LrUXg4gha9jm6V3QCf1oan7wDBshWsDyOXjBQMVWIJ4yR20cO6tQkFcJ//dDHOWV0YLrs7WwF1XJM/As5t1Y4yHdF2HVuQqaw/Pw4d4tSU+MgCrST6oDriaQYOOY8NRTHIECS2q1+KpYxY2LI4C6/YMZhcW2evAi3CinADEaYxFCdkLOgIKiXKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pEbcsxot+zYuDosu3kP5G+ZDi7O4aolkgjlOVioyL+o=; b=WP1WnwSsXqEi+QmisCwWqOIqVfKYw0qX23VAIFeU0WXx/V+Q3fOSA5ckXftMk2jX22hiV14i0JeYy8ORP5Hx0/FBIDCVIIkTBQq5tzm9+OmG83+inNd9NeXPbZ7TpHlflsa2H9ux9NO05wl0v/7qpTTlXYRPJ+vjtc4UuLuuAowHE4dHA3R9HQrFZmkuHPQW9sNh98kRNKB7Uww6WHtAjFH5BfRpzem/wSmvqzZVCLdP7q21v4tk1NUKFMHTGkO7zmS9DYqtnqAevnLajSRFqhrnOniyXpfLfe2IB+Wn+2Sn6f3+wDyT+PQawONDIXn7BpFU8EXEThHiOhz84w6Jjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pEbcsxot+zYuDosu3kP5G+ZDi7O4aolkgjlOVioyL+o=; b=xG+Kn+2OQtg56xidr3iTQAMLFj3QS0/k5kqqKJu2zykelIn2rVpCvOuv9de+1mcmy0bq9JREVckBAGwKiP7D7g4wrtcBllDwUPCow7dRwRlfPJgN4fG8WRYuk5T7yvdL8zQQQTCQjtIxh3ESi4o542bPcmftN8GSQn/CBEpuDnc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4890.namprd12.prod.outlook.com (2603:10b6:610:63::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Tue, 30 Jan 2024 23:09:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7228.029; Tue, 30 Jan 2024 23:09:51 +0000 Message-ID: <9eddad36-4692-4439-aecf-731994bc2c7d@amd.com> Date: Tue, 30 Jan 2024 23:09:44 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [EXT] Re: [PATCH v4 1/1] ethdev: parsing multiple representor devargs string Content-Language: en-US To: Harman Kalra , "dev@dpdk.org" , Thomas Monjalon , Andrew Rybchenko , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Yuying Zhang , Beilei Xing , Qiming Yang , Qi Zhang , Wenjun Wu , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Chaoyong He References: <20240111064432.193119-1-hkalra@marvell.com> <20240121191908.156149-1-hkalra@marvell.com> <20240121191908.156149-2-hkalra@marvell.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0224.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4890:EE_ X-MS-Office365-Filtering-Correlation-Id: e87f8505-22e8-4e17-232e-08dc21e88fc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ScN2UoddlH4lVNnmbb8aDi1OYzSxFMbndgS5bsgyGjZTNZF9fg1aamwY6Yo/by0vkN2/POqKJoxT27NcLFKhQUYkEVhDu2OOfmVBjz0x7UP2Uj8B3qfzP/TUUPRBre1eTc+yYEe7FMG38Yxem5HLpQeWIqzRhFsY0ZBaKS28NWbzHg8DCKy0q2NTGBcw4oxH/9R0e6qYUM/QLZSH8RztORAzfmlYQvbYukXcccXJGDXn4yt/XtEW405Bf2zfJFB+TePIKh0BtyjR4DeK2k0Ld3G4s03BZfSvWuMWNPsc3172LzQKnd7akVTn6aSSioSkf+PS7dNw67TLRPUoQqFgbakw9EE+YI+iF3ak5LVh9NTNQ1CxAbKc9TC7kCEcBJ51Nj1s6y7khufJuZNYoaTfDahnqcr+GTcmz0lVQfD1ZYBdLBdLIu8oPPe5DUviJhTeeizNBqStsn2qjbhPS/1JLfR5Uzk/uybaSTffJk0oOoErsqECuvsXk8imPk40yjmOiuEa9UlRgUKYJCjfWnZrEiTHeZf0r/mo1nqD6O1qZi9pxV5VSA5lGvUwmLAdsXEQZSZ5Jss/HlXxjUG7Ii31cNa66DIi4jXxygJzeRIfcRk2cYbhI/ZwTBtfUE+UJFb9FuCECJEZzzsmZLoPaQdLmoNioBT/FJi66SS90xugDPAClaScdK7KSNySFCLzfooOqpwmVuug3KPCMif6sX1D4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(376002)(366004)(136003)(396003)(230173577357003)(230273577357003)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(110136005)(8676002)(8936002)(7416002)(2906002)(5660300002)(31696002)(86362001)(66476007)(44832011)(66556008)(66946007)(316002)(36756003)(6486002)(6666004)(38100700002)(6506007)(478600001)(53546011)(6512007)(83380400001)(26005)(2616005)(921011)(41300700001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWY1b2FZbE9Td0tIeU05M0lZd0xlTkFiVy9rSi9MUHh4TCtiZVBJTGhmZWhi?= =?utf-8?B?cEQ4TnU2OHc3UUNHdWl3NlRPYXUydnZlSjh6UXhYRG1xK2tqSUlsOVdKNjNR?= =?utf-8?B?b1AzamxXK0NLcGk2LzRPSHVYTkhJYkhSYVNoZ2NoVXVTTnlLTmpFd0N4eEN0?= =?utf-8?B?anJyQmhubjdFeUJqaWNTdnhqdm1meFFDVnVqbXRteFA2SFhReitwMUlJY3Nk?= =?utf-8?B?RE00dlZGLy9lSnNvZUVBSFNYek5WbW9ueGJNZDJBcFU1RnV3ZkVEZlpXbEh0?= =?utf-8?B?dC9hNDZNTlFReHhEVHgwY2FhR0N5eFlITGhuUXhYT0tHSFFDOVB4MEFpa3d0?= =?utf-8?B?R2hqLzR0MHdNNEZuSnhFNFpHSm1nV0ppQU1nOXB1bFJVM3BJN0xQYTVLOSt3?= =?utf-8?B?WVNtaHVEOHF5TUFmdThqUEk1Qk5haHV3UWJRSnZzTnVYY2ttdFFDdVhiUmRm?= =?utf-8?B?Ykhkd0ZnaWpQWDd0OUd2d0lwYlpvS3lXdHV2MkFIOWZtTzNzRGQ4VjZlbkdL?= =?utf-8?B?Uk9jb1RhbE5veDQxeFhTR1hGTlpGTjFLU29qcmhnaUZ1Y3cvL3lnYkg1Q1RI?= =?utf-8?B?OS83RXlkR2tUb1hQcE5lWkg3akpjemRtN1U2aysrdWthV0VtRFZsZlJQUGFs?= =?utf-8?B?M3V1U3psTnNnMktrOFZLMnNBNjR2am5yZVF6VFQ2SDBvWEdkdVFTUDJudFR3?= =?utf-8?B?MS9TS2s1L2NTRUJvUXB1eVZFZElZcEZDTElYb1pja3FjRVcrbTF4SlBDMDZh?= =?utf-8?B?TjVTbnF0QzlSTGFXNmRIQVV4dWREbi9ZZmZ5a2RLdTU3ZmlUNHJzRFJvNi96?= =?utf-8?B?K2NFVUtwTm5rdDVwanFlbXJlQ0JkR054WDFNc2ZVblE3Qm9OUENXdXEzeGlL?= =?utf-8?B?TFN3a0xvdG4wK0RIbGZQaWlDQ0QwTlVXTHRMNVpTODVUbFFmMmduVGg0SCti?= =?utf-8?B?UGxCTXRTcjFacm5ZZlZCYllIb2lObFYyeWh3bUp5T01JRkVnYkR1NDZmTHd0?= =?utf-8?B?RS9BNjRBdzZlYTFIMlJ3Mk52d3VucmRlMC9YYmg0VHlIY2J1c2ZWOWt5ZDR4?= =?utf-8?B?dUpYOHU1SFV3WGR5bmZsSk9JMUhFanJEd2Q2Q3dGUEV4Mm5ENWs0bVR6aWY1?= =?utf-8?B?Vnl1dDhZczB4cC9KcTFtUklHZkxEQklnVVAvQXZjVmFLTWt2SVgzY2NObTBO?= =?utf-8?B?NC9DSVdnd210MEdNVVhhd2RVYVlsbmt2eG5VdGpaWmlKa21vVGg4c3c0NUQw?= =?utf-8?B?N1pvOXNGazVGWHh2NW9nNVkyKzk5bW5DSTk5SWJzVEpwR3BBRUZaWXJhNyt6?= =?utf-8?B?dGp0NHFDdW9HTTVFR3FEL1cxdHRHcFYrNGcrT0FFSmdiMGVCb2tEYURzWVY4?= =?utf-8?B?WVlSbittVnd5VHJkR1pUbXhCTzQ2NFhQdzYvczg5UXNFU09CbUk3bnZMbElj?= =?utf-8?B?WTBTWFQxQUhEZ2VuRWpaNTE1YmYzN21hQkdwSmc5SWFYUkpiR3B0N2RnOXNV?= =?utf-8?B?QTVpaW5IZXhXVGIvRVBmY0JGRWM0WHR6Q01Jc0doNG9Cc04vQWZ2ajNCcUlW?= =?utf-8?B?Zk5peFc0cHlxa3RUamlKRVNrNXRiVHNlS1MvY0J4bWh4S2hYa3d0MUZGeisw?= =?utf-8?B?RnFqSTFYd0ZKaXpUdjR2RmhORnMwM0lOOUk3bUZLWithb042a290M2xPSnJo?= =?utf-8?B?T3U4L1JUUzhRbWZXRmRycW1nQ3p5U1grdFp2UitNejNsU0drSEdCOTdKM1Jk?= =?utf-8?B?ak1zbmc0TWNWcXRGSEZRbmVQWEVYRmZ1ZHY4NGl1RG4rdGtQZ2pkNWh2dUJY?= =?utf-8?B?UVVTaGpqdUhOa1dSaVA5c2JBSm8rOThsTmpQa1RwWGdkdkUrenhxK2VNbk52?= =?utf-8?B?Y0VOK3JQTURZbGJtUGFudUhXUDJWOU40cHdodkcwT1F1VkV4Ty9waUQ4UCt0?= =?utf-8?B?dFk4dWxFVjVMN2xsYWJrMEFab2U2enRlbGxpeUZOTVd0MDhxUVdENzhzOHhm?= =?utf-8?B?aThwdnphcERxQWptaFk1QnRNU1JzSzZjd0MyZ1lQbzRPRnZOMkdkUVEzd2pQ?= =?utf-8?B?MERaUzFwdlAzakY2Y2tINVlnci9teVlzc1dib3ZRU08xUTkyd2tGckdHeFZC?= =?utf-8?Q?vPMaPFINZj6SCUzYCIzSPbCNi?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e87f8505-22e8-4e17-232e-08dc21e88fc3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 23:09:51.1029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fqln3KsFfTVN3MeusHSGcqoLCVFfz8mBCrby8vqehV6IJm4dUxflzLgVTov0Qkjk X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4890 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/29/2024 6:20 PM, Harman Kalra wrote: > Hi Ferruh > > Thanks for the review > Please find response inline > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, January 26, 2024 7:13 PM >> To: Harman Kalra ; dev@dpdk.org; Thomas Monjalon >> ; Andrew Rybchenko >> ; Ajit Khaparde >> ; Somnath Kotur >> ; John Daley ; >> Hyong Youb Kim ; Yuying Zhang >> ; Beilei Xing ; Qiming Yang >> ; Qi Zhang ; Wenjun Wu >> ; Dariusz Sosnowski ; >> Viacheslav Ovsiienko ; Ori Kam >> ; Suanming Mou ; Matan >> Azrad ; Chaoyong He >> Subject: [EXT] Re: [PATCH v4 1/1] ethdev: parsing multiple representor >> devargs string >> >> External Email >> >> ---------------------------------------------------------------------- >> On 1/21/2024 7:19 PM, Harman Kalra wrote: >>> Adding support for parsing multiple representor devargs strings passed >>> to a PCI BDF. There may be scenario where port representors for >>> various PFs or VFs under PFs are required and all these are >>> representor ports shall be backed by single pci device. In such case >>> port representors can be created using devargs string: >>> ,representor=[pf[0-1],pf2vf[1,2-3],[4-5]] >>> >> >> This patch is to be able to parse multiple representor device argument, but I >> am concerned how it is used. > > In Marvell CNXK port representor solution all representors are backed by a single > PCI device (we call it as eswitch device). Eswitch device is not DPDK ethdev device > but an internal device with NIC capabilities and is configured with as many no of > Rxqs and Txqs as port representor required. > Hence each port representor will have dedicated RxQ/TxQ pair to communicate with > respective represented PF or VF. > ack, thanks for clarification. Just to double check, is the cnxk driver support of new syntax planned for this release? It helps if the RFC is out before merging this patch. > >> >> When there are multiple representor ports backed up by same device, can't >> it cause syncronization issues, like if two representor interfaces used for >> conflicting configurations. Or if datapath will be supported, what if two >> representator used simultaneously. > > As I mentioned above, each port representor will have dedicated RxQ and TxQ, > worker cores can poll on respective queues without any synchronization issue. > I hope I am able to explain the use case. > ack >> >> > > > > >> >> Meanwhile please check some comments below related to the parser code. >> >> <...> >> >>> @@ -459,9 +460,26 @@ eth_dev_devargs_tokenise(struct rte_kvargs >> *arglist, const char *str_in) >>> break; >>> >>> case 3: /* Parsing list */ >>> - if (*letter == ']') >>> - state = 2; >>> - else if (*letter == '\0') >>> + if (*letter == ']') { >>> + /* For devargs having singles lists move to >> state 2 once letter >>> + * becomes ']' so each can be considered as >> different pair key >>> + * value. But in nested lists case e.g. multiple >> representors >>> + * case i.e. [pf[0-3],pfvf[3,4-6]], complete >> nested list should >>> + * be considered as one pair value, hence >> checking if end of outer >>> + * list ']' is reached else stay on state 3. >>> + */ >>> + if ((strcmp("representor", pair->key) == 0) >> && >>> + (*(letter + 1) != '\0' && *(letter + 2) != '\0' >> && >>> + *(letter + 3) != '\0') && >>> + ((*(letter + 2) == 'p' && *(letter + 3) == 'f') >> || >>> + (*(letter + 2) == 'v' && *(letter + 3) == 'f') >> || >>> + (*(letter + 2) == 's' && *(letter + 3) == 'f') >> || >>> + (*(letter + 2) == 'c' && isdigit(*(letter + 3))) >> || >>> + (*(letter + 2) == '[' && isdigit(*(letter + >> 3))))) >>> >> >> Above is hard to understand but there are some assumptions in the input, >> can we list supported syntax in the comment to make it more clear. >> >> For example following seems not support, can you please check if >> intentional: >> [vf0,vf1] // I am aware this can be put as vf[0,1] too [vf[0,1],3] [vf[0],vf[1]] > > Intention behind above change is just to detect if its nested list i.e. multiple > devargs (constituting lists as well) or a single devarg with a list. > > pf0vf[1-4] is a single list devarg example, while [pf[0-3],pfvf[3,4-6]] is > nested list example, where multiple devargs pf[0-3] and pfvf[3,4-6] > (which are also lists) are bind to a list of devargs. > > And as I mentioned in the comment, complete "nested list should be considered > as one pair value", hence entire list i.e. [vf[0,1],3] [vf[0],vf[1]] will be one > value of arglist and later eth_dev_tokenise_representor_list() will tokenize > and feed to rte_eth_devargs_parse_representor_ports(). > > Whether any format is supported or not should be handled by > rte_eth_devargs_parse_representor_ports() > Agree but this is something user facing, user should know the syntax to use it but some corner cases are not documented well and not trivial to grasp from above code. What do you think about adding some unit tests for parser, it can be some pointer to the intention of what should be supported and what not, also increases our confidence to the code? > >> >> I am not saying above should be supported, but syntax should be clear what >> is supported what is not. >> >> >> Also I can't check but is the redundant input verified, like: >> [vf[0-3],vf[3,4]] > > IMO, this should be handled by PMD, if any representor already created should > return an error. > fair enough