From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 803C643709;
	Sat, 16 Dec 2023 11:10:33 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E6A1440691;
	Sat, 16 Dec 2023 11:10:32 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D84AE402AA
 for <dev@dpdk.org>; Sat, 16 Dec 2023 11:10:31 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 5AFDB66;
 Sat, 16 Dec 2023 13:10:31 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 5AFDB66
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1702721431;
 bh=KktuCwGm4BFVpiqe50a7jepJxFUwiINm/bxzCzp0onQ=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=BK8NYqw8yomQHOtggXY1W1G3/JJxMuvCcB88vqXXrIgJ+JtKXWN+o1APFE0By25ol
 +FnOQou/IXSR73ont12OuVrEafmESzZTebR+4XERueNta7PuIQAgBCFLgthWikGhFH
 Cx2lJJXZe7jxc3l3A0uj7NbGoSfbX6ztGiOAAXYQ=
Message-ID: <9edfbffe-df1e-4074-9eef-56a352b4a4f3@oktetlabs.ru>
Date: Sat, 16 Dec 2023 13:10:31 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 5/5] bus/vdev: check result of rte_vdev_device_name
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Sinan Kaya <okaya@kernel.org>, Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@amd.com>
References: <20230120044140.95975-1-okaya@kernel.org>
 <20230710170800.12478-1-stephen@networkplumber.org>
 <20230710170800.12478-6-stephen@networkplumber.org>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20230710170800.12478-6-stephen@networkplumber.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 7/10/23 20:08, Stephen Hemminger wrote:
> From: Sinan Kaya <okaya@kernel.org>
> 
> In rte_eth_vdev_allocate result of call to rte_vdev_device_name is
> dereferenced here and may be null.
> 
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Patch summary should be human-readable and do not mention
internals (function name).

Other than that:
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>