From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 24E68A00C4;
	Wed,  9 Nov 2022 11:43:55 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C43FF40143;
	Wed,  9 Nov 2022 11:43:54 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 7DA39400EF
 for <dev@dpdk.org>; Wed,  9 Nov 2022 11:43:53 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 0356966;
 Wed,  9 Nov 2022 13:43:52 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 0356966
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1667990633;
 bh=5gdNODHEdJdC30y9Z1Q84PMgtqOEIoI/iP4wm6aVzaY=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=UyzVlxSX2xtNr5US+GmGNH67VvtE9lVe9+42wsLs313onRfV6uxiQuHVBnC+6hM90
 XBVWEsv0CyAsYYe+Bpd2mkVFKDyYzGzlrBpyLf6sF9rbWP66K49ePJglxnzygTaTgW
 pGIgfKq0IKz5YoRTbAkycGEeTJr3toLpF1DY7AdE=
Message-ID: <9ef19e02-946a-7017-196e-e60c1b514a70@oktetlabs.ru>
Date: Wed, 9 Nov 2022 13:43:52 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] app/testpmd: fix flow list for async flows
Content-Language: en-US
To: Alexander Kozyrev <akozyrev@nvidia.com>, dev@dpdk.org
Cc: rasland@nvidia.com, michaelba@nvidia.com, aman.deep.singh@intel.com,
 yuying.zhang@intel.com
References: <20221107131616.2578401-1-akozyrev@nvidia.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20221107131616.2578401-1-akozyrev@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 11/7/22 16:16, Alexander Kozyrev wrote:
> Flows created with the new asynchronous Flow API lack attributes
> (direction, priority, group number). These attributes are part of
> a template table for flows created via rte_flow_async_create().
> 
> When testpmd tries to list all the flows it accesses flow
> attributes via pointer and crashes. Save flow attributes during
> the template table creation and use them in the "flow list" output.
> 
> Fixes: ecdc927b99 ("app/testpmd: add async flow create/destroy operations")
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Applied to dpdk-next-net/main, thanks.