From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AFC5A00C2; Mon, 22 Aug 2022 10:32:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA33A40DFD; Mon, 22 Aug 2022 10:32:34 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 31ABE40DDA for ; Thu, 18 Aug 2022 04:51:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660791106; x=1692327106; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=gCspS/vCvUhiiX5n0YzFvVojJD3iIyDO502jty3Iya0=; b=ILSitpKHgUH5QQRvbgwGXUj1dZyIkCKwoRK1xFwNReSn4NV3K8ed5LY0 CceVTyHPTM9xEVD5DZobftzPzZO4nSqVFhi3AVHRdZ9ytZXHqwQAyjadp fsRKzHIOvTCgRe+blGStrNT1rRCB9Ht5GLBbw2IyyKKBH1FoSPi7rpMk6 Q3vyrDWN1PvFh8bxyNdU5AfWCpa9jwY76HtusurO1fV3vBZfZmiIJ6yf0 CZmfLANSpq7h2CZ/KK15ckf9iTip1S8S20fYaAyPUcSlC4EaPSnw6mwOy XJ0yciZeUJOGMigoZSe3FZz3cDjSsAFdTxHY5UebkZnrtKclLSVneGmXE w==; X-IronPort-AV: E=McAfee;i="6500,9779,10442"; a="290218503" X-IronPort-AV: E=Sophos;i="5.93,245,1654585200"; d="scan'208";a="290218503" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2022 19:51:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,245,1654585200"; d="scan'208";a="667897269" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 17 Aug 2022 19:51:45 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 17 Aug 2022 19:51:44 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 17 Aug 2022 19:51:44 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Wed, 17 Aug 2022 19:51:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=benzpMbWEKC+aVsQPXTDaBcF+V5nWFDkqNoLNgqt+F/+tuuoJ0x44Je+VzetG5TIS6/dG54xrnq5wO4kkyXK3Sk8+3mJzgjFxfaBc8ycb/QgkPvWoMqU8HIE5LKzhYdn2+Fw3vpsjRl24lXh3oC2+5Ga2PNE1uwGwELaaRprTOGE1jWugXKeytKiaGzdkmBfKfQ/X4SV1A5+KM9ywoCaTwhsnkeAN7VuIFQ0GkxZTV8/naa3Jj16jZazzcSQeuze9xDCxp04yLPjR+kA9FULEPX9Ftc728y7cK5NWJvhi7vuzb5iNw+9P0z/VXj7fwLwJeH0/8qqBwWA/P+Fki7Ubw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gCspS/vCvUhiiX5n0YzFvVojJD3iIyDO502jty3Iya0=; b=ZrQJkqtaMqPmO5npH+c1ZSW71ETffcMrJtiQfoju3TNUeBeVvfnQd+VGB+3ORPmsIcFepf/q+8+AA0cQKi0CVopOb9TT8T3XWUn/2A4cj9YuYMX2CnKydn/DPENpGpzYpH4m+GvM0LBCiHG6/4Dj1nfukVgZoKj0h/LRrSLnfkDZZcIE9ieSpnC7lYl0vjG4sxb9LDuCHpJrrgxvT855wxdxVoK1SPbXPY91awrtumaqnK6w0saF3Ne8ZnPc1ynIYPAI8g2MLjZphQ5sJpjhM3VHKudPzV0fkvL/16OUzzhxqwJXqz89nsdCjOUwMSLX6CE+WetK1aEDaGZAHBwWaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SN6PR11MB3517.namprd11.prod.outlook.com (2603:10b6:805:dc::17) by BL1PR11MB5256.namprd11.prod.outlook.com (2603:10b6:208:30a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Thu, 18 Aug 2022 02:51:42 +0000 Received: from SN6PR11MB3517.namprd11.prod.outlook.com ([fe80::f52b:bf5c:2545:3e0a]) by SN6PR11MB3517.namprd11.prod.outlook.com ([fe80::f52b:bf5c:2545:3e0a%4]) with mapi id 15.20.5525.019; Thu, 18 Aug 2022 02:51:42 +0000 Message-ID: <9ef88d1a-b175-abcf-491f-eadf145f0877@intel.com> Date: Thu, 18 Aug 2022 10:51:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.1.2 Subject: Re: [dpdk-kmods v2] windows/netuio: fix BAR parsing To: Pallavi Kadam , CC: , , , , References: <20220802191058.1779-1-pallavi.kadam@intel.com> <20220811221723.2124-1-pallavi.kadam@intel.com> From: "Liu, Qiao" In-Reply-To: <20220811221723.2124-1-pallavi.kadam@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR01CA0155.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::35) To SN6PR11MB3517.namprd11.prod.outlook.com (2603:10b6:805:dc::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ee00e5e-88ca-4f96-4fa1-08da80c494a2 X-MS-TrafficTypeDiagnostic: BL1PR11MB5256:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H1DIlTcxkAiKUuzH0NgBbLhu1ivvU7THXNfTurKSF5fYWx7qQq49qKZHp2CZ/0XRHM546HrY9g8CJk5BPBVDzPehvzZZhef9vVChj0+qInai2bjPiT9hdejszPVl5jc7gCxaxYes45I2hnnZNUYBO9jfuZjEHIANV+6tXMTCrX1vUEYm33ehVgucu5vvDaeQhHeXN7S0Hc2+RozSEm+BfcdIU7osh1b2SpxtymqdEhPnbKdF7ZaFyAsQWpYF9lBY7tyZzkogbnw73i7r7Y2nfVvIvEinouagd5YuQTFgIJPYxBI4QR4c0GZksppHAUQyoEoENt8CbN8u8vHvvqeGY+NLKwMFKwjnUk9K5IF7z1N5Z9xWXqVNlwzyNe1lrE76dCTyF2DnSLaLPMNHYr7hp3MYT3CVX7jXu80gnHIigMDCtWPff1YXq556r0WadQxVLOtmRi2ddph6KWriMpfr59J3IS3DKDI/tWah5L5AcRyF7EPfYRwoLbjkTdEeZL6vrf0j2sjLRbXPbvGi3tNyZ3VDUs7zpodK7lL3Lq9m+rh9MjsxYBkVZl+CEA41pKJ0XsO9GYisV7SMnzFspk4MIYfMkP091dDXuCdKEyuwVqkA7cmSZlKguciJvWQz4G0ZtwqVRGrfPFQfh/ww/G1tdyBWS9M/1RUGybIxp88WyD0dBnGceUxUtlFj5pEuFc2d5qJ/O2znoRwCE0q57ZK5ZSOEKC7a5VL0rJWtIQmaqZiWim1ZulcRx90W/S7P2LJOCE3g/gNQfT3qYwfdfEafs8IhNXMx6fHXeQIm5KWIxg8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3517.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(366004)(396003)(376002)(136003)(346002)(26005)(86362001)(186003)(31696002)(36756003)(31686004)(2616005)(6512007)(82960400001)(6506007)(6666004)(316002)(4744005)(478600001)(41300700001)(66476007)(66556008)(8936002)(66946007)(8676002)(5660300002)(2906002)(4326008)(38100700002)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0JQZlQ3d0JuK2lwVGtLemsrVzBnNU5La2hYcDlibWxJejZ6RVJFWjVQM2Yx?= =?utf-8?B?OVRwa1N1elY4dHJVREFxTHFSUUR2NWwzYjVJZGpMaUtZVWlYLzRaL3FQczg4?= =?utf-8?B?TkNndmhhOEFqdi9WTHZZTDdKbUFIMWlTZVRrZ1FGYjh0UHpzUnZJM1Jlem9x?= =?utf-8?B?aDl1Z3BFZmRqUGoyWkpMWjNoQXpOa3lYQWFvWVBzaElBRVlzWDByYU9pY1Er?= =?utf-8?B?UCtoZUNYSDFTWS9OREhnUnh5Yi9NQTNWUThRMzVzakQ3WTBhdUVqa0N0Nm4z?= =?utf-8?B?Ym4xbmp3KzJ0U1pycHNtK29GZVV3bW1iblBTZDBuMTIwSTlOZTAydUkycUM1?= =?utf-8?B?cnBKUXJJd1VERUZiWEN0S203QkdVZFFYaHFmWHNMTDd3bklqQk4ycGdIQWsy?= =?utf-8?B?ejRqV2ZWdDV3VFp2VExUc0taZmtMdDc2L2l6cnRjYjdodjhaZ05jeVY5UlRH?= =?utf-8?B?ZlNJT2Mvc2NyRkM5RXVrVkxuNGRlZndyY0xWaVFVbkxvUnZUOWh1SHpkWUZ4?= =?utf-8?B?d05ha2lLaWJaRTVNd3Faa0RSd3c4aUJLdUVDSzFWTE13aUpLaUprdkptcnpY?= =?utf-8?B?SVYyTkZrY3I2VFgyd2d5TEp1dGtKc2RMRDF1Nm5tbFEvL1ovcG5ZRnB1WXQr?= =?utf-8?B?MjVmYm1NNStMOWZjVXJBR0JhNFpheXFGMndSL3RsTzdka1FZUWg0bmE4M0JY?= =?utf-8?B?SmFaMklKK2JJZWZiaTNKdFBKNE5zOFh4Q2QvUDhPeVp2UGhBekRqVGEyOTYr?= =?utf-8?B?eXN2UzF4ZUZ2UmlPK2NVWWhjMWdibDFqNThrZ3diOFpRY2p1Q1hqM2NIeExB?= =?utf-8?B?NTFYR1Z4dmdnUGhwRWxadEljd2pUWVJKL1pyWXhicStTams4eFlZc0lWMnBp?= =?utf-8?B?VFZHeVF4RTdXQkRlL3BOMDUrRnRKVU01bDlURDFNUzVFdTFPenB2dU0yTGxh?= =?utf-8?B?YS92RW9Bb0ZURmgvVGxDVjdXZ0JSUjRqcEtKS3BQQ0UwcW5xY3NLSFVyOFNH?= =?utf-8?B?K29OZkdWeVpEL3RlYmxubzhoRlI3UnliMko0cTJlemltM01hcHJqb0d0Z3lB?= =?utf-8?B?QnR5MVZmWWZrT0luNGpmZTN4OXQ1U2FvRVVLK2JSU2ZkQ1Nsb1hFYzFJU05k?= =?utf-8?B?dDF5N3JFUC95bWVOckttdjhCd3pVQ09ablVIZDBFc21hSFpJb0JSbnRaMkNO?= =?utf-8?B?MDBUMm9MUVZRcFpHUHR4ODhPeG90WkozdXpkNEJaTWhUT0FrWWoyVjkvMVM2?= =?utf-8?B?eWFDbUIxVVRuL2hZK0ZEcDcxSk1BMURiUzYzaXpmVCtQbVptQjZVWkpJVVlM?= =?utf-8?B?MzdSWEMzVUhyYTNlNEwrajRndEZtbHp5Z2lyYTVGcE9MQWVnQXJrQXE2TWQ3?= =?utf-8?B?bFozYTFlbFVqMU5uaTltcDlxbk9iQkRJeG1mWEhBWGZ4WUNPNzBCTDhBeCs4?= =?utf-8?B?dDgrWWFpRENLeml3eU93WGMwcGhqQ2p0YmJkRUExQ3AyOHZaaS9vSE5HQ1ZZ?= =?utf-8?B?Q3hDY3FXd0tIeUFNUzNCRStZdjNFZVlCa3hQY1RiWGNQMWh1SzFpVUF0cE1U?= =?utf-8?B?TmFyS2tBb3h0UzFsZCtadXliamduWFFGK2d6Z2M1NGRlUDVRS0MzSnRvanFS?= =?utf-8?B?ckRTci9sMWtZWFIxZFZxVEVMTXp6L1VYK0NHYXRjV2lNaTZHcmtwWTdxVE1u?= =?utf-8?B?SEc2MlppUi95aFdwQk43S0doRnpDdnA2RnZBVjFWYmhiWEdPaTlYQWI5dkZW?= =?utf-8?B?NEx2NEY3cjZaL1lkc3Q2aTZoOXA2Z1QrQTBMcFpTbDQwVGE2RlgvaExwU0xJ?= =?utf-8?B?R1p6bFIwZXJHNml6ZGJ3YUNUZEJkdmRUVXBkSVlRdnhDT2lvZ1crSTYrcjFy?= =?utf-8?B?TFZ4dU1nRlpTWStnMWVsTlFGWkViSjlpSFROdlU4VHBhc25wRkJLK01YVmU1?= =?utf-8?B?bDVxZlNUNWVGQ2xEUVFHZ00xWjlUbDlZdDlkSENQWlQ3VlZnSE5tb1Z0dmdv?= =?utf-8?B?UHowMm5NTStNOUxXUTlSR3hwcmZRcktuenBCZ1g3TnJPSVlYeS9WaGdmK2RS?= =?utf-8?B?ZW14cklyTWtQR1lkSUl1azRjdG5jVW5aZ1ZTK0o1Q01ld3ZMRkdTSWJvdFF2?= =?utf-8?Q?Ws8chqFEsfKB8Eg6Whg/E6z2c?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9ee00e5e-88ca-4f96-4fa1-08da80c494a2 X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3517.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 02:51:42.5863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g5XbVnFlZtLdH1nRDF/GDvwkhRTGgf9CMOgJ6o+p54Wo2UnIjlqZCLEGo2XNIIF+qQE/FJjp7KN0l83ZdKyGkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5256 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Mon, 22 Aug 2022 10:32:34 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2022/8/12 6:17, Pallavi Kadam 写道: > Current code was always checking the 'prev_bar & PCI_TYPE_64BIT' > though only the first BAR slot of a 64-bit BAR contains flags. > Also for certain PCIe devices, BAR values were not continuous. > This patch fixes this incorrectness and maps the BAR addresses > correctly. > > Reported-by: Qiao Liu > Suggested-by: Dmitry Kozlyuk > Signed-off-by: Dmitry Kozlyuk > Tested-by: Pallavi Kadam > --- Acked-by: Qiao Liu