From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 17F55A04C0;
	Fri, 25 Sep 2020 18:38:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 418F21E91D;
	Fri, 25 Sep 2020 18:38:41 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id E289F1E90D
 for <dev@dpdk.org>; Fri, 25 Sep 2020 18:38:39 +0200 (CEST)
IronPort-SDR: KrellOKfO8Iv2HdAMGpI0PL4BmMiDSpVGLyCV2+JSZlldDCAh0ibMaF+O33wCxnue27yB8KIgA
 SlboEjc4DBFw==
X-IronPort-AV: E=McAfee;i="6000,8403,9755"; a="225737184"
X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="225737184"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Sep 2020 09:38:37 -0700
IronPort-SDR: wbZkaLYak5Uet9iL0BzYKb8mSnoD4Ht66MeKQuNyvSWlTv+GKmnmTHZK8V7eqTvdog0+CzF+WR
 BhOsVYG1d2vg==
X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="487532950"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.10.211])
 ([10.252.10.211])
 by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Sep 2020 09:38:35 -0700
To: Stephen Hemminger <stephen@networkplumber.org>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: "Min Hu (Connor)" <humin29@huawei.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, dpdk-dev <dev@dpdk.org>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, linuxarm@huawei.com
References: <1599534347-20430-1-git-send-email-humin29@huawei.com>
 <1600952745-55993-1-git-send-email-humin29@huawei.com>
 <1600952745-55993-2-git-send-email-humin29@huawei.com>
 <ccf46bbf-2159-6e74-1cde-8c6a7847ca02@solarflare.com>
 <ce2c5d78-518a-f341-e152-8c1b4f8af24c@huawei.com>
 <CACZ4nhuoWh9ty7JtYp=Qv7ra+Y_1deQKMZdvA1m+Dg+qUk3+fA@mail.gmail.com>
 <20200925091229.6fc8fb43@hermes.lan>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9f07a776-60b8-6534-4356-ed4aa8912d8e@intel.com>
Date: Fri, 25 Sep 2020 17:38:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.2
MIME-Version: 1.0
In-Reply-To: <20200925091229.6fc8fb43@hermes.lan>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH V12 1/4] ethdev: introduce FEC API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/25/2020 5:12 PM, Stephen Hemminger wrote:
> On Fri, 25 Sep 2020 08:36:06 -0700
> Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:
> 
>>>
>>> WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
>>> #264: FILE: drivers/net/hns3/hns3_ethdev.c:5601:
>>> +       /* fallthrough */
>> Try /* FALLTHROUGH */
> 
> That won't work either.
> 
> This is a new warning from upstream Linux kernel checkpatch.
> The Linux kernel has converted code to use a new macro.
> 
> The warning should be silenced by the DPDK checkpatch script.
> 
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 78a408ef9823..923ff6f7d9ee 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
>   PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
>   SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
>   LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> -NEW_TYPEDEFS,COMPARISON_TO_NULL"
> +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
>   options="$options $DPDK_CHECKPATCH_OPTIONS"
> 

It should be already applied: https://patches.dpdk.org/patch/75173/
https://git.dpdk.org/dpdk/commit/?id=fcea4c8e29b6